Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 694982 - sci-mathematics/minisat-2.2.0_p20130925: header fix inserts incomplete path
Summary: sci-mathematics/minisat-2.2.0_p20130925: header fix inserts incomplete path
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: Normal normal (vote)
Assignee: Gentoo Science Related Packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-09-19 19:04 UTC by phlo
Modified: 2019-10-21 14:32 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description phlo 2019-09-19 19:04:55 UTC
The ebuild contains an erroneous fix, changing the includes of internal library header files, which drops the specified standard system include subdirectory.

The substitution in minisat-2.2.0_p20130925.ebuild:39

sed -i -e 's:#include "minisat/\([^"]*\)":#include <\1>:g' "${file}" || die

should be changed to:

sed -i -e 's:#include "minisat/\([^"]*\)":#include <minisat/\1>:g' "${file}" || die

Reproducible: Always

Steps to Reproduce:
1. write some code using libminisat, e.g.:

   #include <minisat/core/Solver.h>
   int main () { return 0; }

2. build
Actual Results:  
Build fails due to Solver.h not being able to include any other library header:

/usr/include/minisat/core/Solver.h:24:10: fatal error: mtl/Vec.h: No such file or directory
 #include <mtl/Vec.h>
          ^~~~~~~~~~~
compilation terminated.

Expected Results:  
Build passes without an error.
Comment 1 Larry the Git Cow gentoo-dev 2019-10-21 14:32:24 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=494768fd4f91286c04abcac0cb06c6042720cd1f

commit 494768fd4f91286c04abcac0cb06c6042720cd1f
Author:     Jeffrey Lin <jeffrey@icurse.nl>
AuthorDate: 2019-01-04 03:37:59 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2019-10-21 14:32:09 +0000

    sci-mathematics/minisat: fix sed in header files
    
    Bug: https://bugs.gentoo.org/697562
    Closes: https://bugs.gentoo.org/694982
    Package-Manager: Portage-2.3.53, Repoman-2.3.12
    Signed-off-by: Jeffrey Lin <jeffrey@icurse.nl>
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 ...minisat-2.2.0_p20130925.ebuild => minisat-2.2.0_p20130925-r1.ebuild} | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)