Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 694838 - net-firewall/nftables: QA issues
Summary: net-firewall/nftables: QA issues
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Francisco Blas Izquierdo Riera (RETIRED)
URL: https://qa-reports.gentoo.org/output/...
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2019-09-18 16:27 UTC by Michał Górny
Modified: 2019-12-03 16:10 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2019-09-18 16:27:42 UTC
net-firewall/nftables
  RedundantVersion: version 0.9.0-r4: slot(0) keywords are overshadowed by version: 0.9.0-r5
  RedundantVersion: version 0.9.1-r1: slot(0) keywords are overshadowed by version: 0.9.2-r1
**  UnderscoreInUseFlag: USE flag 'modern_kernel' uses reserved underscore character **
**  ExecutableFile: unnecessary executable bit: 'files/libexec/nftables.sh' **
Comment 1 Larry the Git Cow gentoo-dev 2019-09-19 15:29:26 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3d0ddd7edd1076fa80ac4f7ed18f97e729889339

commit 3d0ddd7edd1076fa80ac4f7ed18f97e729889339
Author:     Mike Gilbert <floppym@gentoo.org>
AuthorDate: 2019-09-19 15:14:37 +0000
Commit:     Mike Gilbert <floppym@gentoo.org>
CommitDate: 2019-09-19 15:29:02 +0000

    net-firewall/nftables: chmod -x files/libexec/nftables.sh
    
    Bug: https://bugs.gentoo.org/694838
    Signed-off-by: Mike Gilbert <floppym@gentoo.org>

 net-firewall/nftables/files/libexec/nftables.sh | 0
 1 file changed, 0 insertions(+), 0 deletions(-)
Comment 2 Francisco Blas Izquierdo Riera (RETIRED) gentoo-dev 2019-12-02 19:01:11 UTC
Michał I'd rather keep 0.9.1-r1 if possible so that any bugs can be more easily tracked. 0.9.0-r4 has been dropped as it was vulnerable.



I need to read on how to rename use flags so I will probably get this solved a bit later on (I hope I have enough time by X-mas).
Comment 3 Larry the Git Cow gentoo-dev 2019-12-03 16:10:27 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=269ef5357b7faf75145b073997908e74e9c18ea5

commit 269ef5357b7faf75145b073997908e74e9c18ea5
Author:     Francisco Blas (klondike) Izquierdo Riera <klondike@gentoo.org>
AuthorDate: 2019-12-03 00:39:53 +0000
Commit:     Matthew Thode <prometheanfire@gentoo.org>
CommitDate: 2019-12-03 16:10:20 +0000

    net-firewall/nftables: rename modern_kernel use flag
    
    When the new scripts supporting atomic updates on modern kernels
    where introduced, usage of the new scripts was controlled by the
    modern_kernel USE flag.
    
    QA has requested that we avoid using underscores on USE flags as
    they are a reserved character.
    
    Rename the modern_kernel USE flag to modern-kernel to address
    this issue.
    
    Closes: https://bugs.gentoo.org/694838
    Signed-off-by: Francisco Blas Izquierdo Riera (klondike) <klondike@gentoo.org>
    Package-Manager: Portage-2.3.76, Repoman-2.3.11
    Signed-off-by: Matthew Thode <prometheanfire@gentoo.org>

 net-firewall/nftables/metadata.xml             | 2 +-
 net-firewall/nftables/nftables-0.9.0-r5.ebuild | 8 ++++----
 net-firewall/nftables/nftables-0.9.1-r1.ebuild | 8 ++++----
 net-firewall/nftables/nftables-0.9.2-r1.ebuild | 8 ++++----
 4 files changed, 13 insertions(+), 13 deletions(-)