Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 694708 - app-admin/helm: incomplete LICENSE
Summary: app-admin/helm: incomplete LICENSE
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal with 1 vote (vote)
Assignee: William Hubbs
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 694792
  Show dependency tree
 
Reported: 2019-09-17 14:28 UTC by Michał Górny
Modified: 2022-11-29 12:14 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2019-09-17 14:28:34 UTC
The package bundles dependencies whose respective licenses are missing in LICENSE, at least (according to ninka):

Apache-2
BSD3
GPLv2+
MIToldwithoutSellandNoDocumentationRequi
MITX11
MPLv2
spdxBSD2
spdxBSD2,spdxMIT
spdxBSD3
spdxBSD3,spdxMIT
spdxMIT
spdxMIT,spdxMIT,Apache-2,Apache-2,Apache-2

Also:

CC-SA-4.0-International
CC0-1.0
|| ( Apache-2.0 LGPL-3+ )

yaml is apparently LGPL-3 with exception for static linking.
Comment 1 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2019-09-17 14:34:54 UTC
> CC-SA-4.0-International

I missed BY-.
Comment 2 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2019-11-03 19:59:03 UTC
Ping.
Comment 3 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2022-11-19 10:37:04 UTC
Ping.  This bug is being ignored for 3 years now.
Comment 4 Larry the Git Cow gentoo-dev 2022-11-27 20:04:17 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=4cca97c003a0e5515369f8372d6ea6b3320ff795

commit 4cca97c003a0e5515369f8372d6ea6b3320ff795
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: 2022-11-27 17:03:20 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2022-11-27 20:00:36 +0000

    package.mask: Last rite app-admin/helm
    
    Bug: https://bugs.gentoo.org/694708
    Signed-off-by: Michał Górny <mgorny@gentoo.org>

 profiles/package.mask | 5 +++++
 1 file changed, 5 insertions(+)
Comment 5 cono 2022-11-28 12:49:24 UTC
wow, this is unfortunate. So useful package nowdays. Would be so bad to loose it from repo.
Comment 6 Rafael Umbelino 2022-11-28 14:08:53 UTC
If this is a simple fix (adding the respective licenses in a file) could anyone do it?

I need this package and if I can do it I would be glad to do it.
Comment 7 John Helmert III archtester Gentoo Infrastructure gentoo-dev Security 2022-11-28 15:09:05 UTC
Anyone can make PRs for any package on Github. Feel free if you have a bug to fix.
Comment 8 Rafael Umbelino 2022-11-28 16:51:26 UTC
Would you mind showing an example of a package with a similar situation but that it's done correctly?
I'll do my best to replicate and push a fix to the repo.
Comment 10 Ulrich Müller gentoo-dev 2022-11-28 18:06:10 UTC
I see the following in README* and LICENSE* files:

Apache-2.0
BSD
BSD-2
CC-BY-4.0
CC-BY-SA-4.0
ISC
MIT
ZLIB


(In reply to Michał Górny from comment #0)
> Also:
> 
> CC-SA-4.0-International
> CC0-1.0
> || ( Apache-2.0 LGPL-3+ )
> 
> yaml is apparently LGPL-3 with exception for static linking.

I see GPL only in testdata (which presumably isn't installed), and I don't see LGPL anywhere.


So AFAICS, the ebuild should have:
LICENSE="Apache-2.0 BSD BSD-2 CC-BY-4.0 CC-BY-SA-4.0 ISC MIT ZLIB"
Comment 11 Larry the Git Cow gentoo-dev 2022-11-29 10:25:34 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6097493a806801b9e7fca5a4252430387206df04

commit 6097493a806801b9e7fca5a4252430387206df04
Author:     Ulrich Müller <ulm@gentoo.org>
AuthorDate: 2022-11-29 10:23:53 +0000
Commit:     Ulrich Müller <ulm@gentoo.org>
CommitDate: 2022-11-29 10:25:15 +0000

    app-admin/helm: Fix LICENSE
    
    Bug: https://bugs.gentoo.org/694708
    Signed-off-by: Ulrich Müller <ulm@gentoo.org>

 app-admin/helm/helm-3.10.1.ebuild | 2 +-
 app-admin/helm/helm-3.8.1.ebuild  | 2 +-
 app-admin/helm/helm-3.9.4.ebuild  | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)
Comment 12 Ulrich Müller gentoo-dev 2022-11-29 10:26:54 UTC
LICENSE should be fixed now.

@treecleaners: Can this package be unmasked?
Comment 13 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2022-11-29 10:55:43 UTC
(In reply to Ulrich Müller from comment #12)
> LICENSE should be fixed now.
> 
> @treecleaners: Can this package be unmasked?

Sure.
Comment 14 Larry the Git Cow gentoo-dev 2022-11-29 12:13:13 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=db75ffb9108e6688320254b1b82ce1692bf34e6c

commit db75ffb9108e6688320254b1b82ce1692bf34e6c
Author:     Ulrich Müller <ulm@gentoo.org>
AuthorDate: 2022-11-29 12:12:31 +0000
Commit:     Ulrich Müller <ulm@gentoo.org>
CommitDate: 2022-11-29 12:12:31 +0000

    profiles: Remove mask for app-admin/helm
    
    Closes: https://bugs.gentoo.org/694708
    Signed-off-by: Ulrich Müller <ulm@gentoo.org>

 profiles/package.mask | 5 -----
 1 file changed, 5 deletions(-)