Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 694654 - net-irc/inspircd: QA issues
Summary: net-irc/inspircd: QA issues
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Wade Cline
URL: https://qa-reports.gentoo.org/output/...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-09-17 13:16 UTC by Michał Górny
Modified: 2019-10-28 13:15 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Fix most QA issues (0001-net-irc-inspircd-Fix-QA-issues.patch,25.75 KB, patch)
2019-09-19 05:42 UTC, Wade Cline
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2019-09-17 13:16:49 UTC
net-irc/inspircd
  UnnecessarySlashStrip: version 3.3.0: ${D%/} unnecessary slash strip on line: 86
  DuplicateFiles: duplicate identical files in FILESDIR: 'files/inspircd-2.0.27-fix-path-builds.patch', 'files/inspircd-2.0.28-fix-path-builds.patch'
  DuplicateFiles: duplicate identical files in FILESDIR: 'files/inspircd-3.2.0-fix-path-builds.patch', 'files/inspircd-3.3.0-fix-path-builds.patch'
  ProbableGlobalUSE: local USE flag closely matches a global: 'pcre'
  RedundantVersion: version 2.0.28: slot(0) keywords are overshadowed by versions: 3.3.0, 3.2.0
Comment 1 Wade Cline 2019-09-19 05:42:23 UTC
Created attachment 590358 [details, diff]
Fix most QA issues
Comment 2 Wade Cline 2019-09-19 05:44:01 UTC
I believe that this will fix most QA issues except 'RedundantVersion'.  The 2.0.28 version isn't actually redundant because it's an LTS version (http://www.inspircd.org/2019/06/01/v20-maintenance-schedule.html) and migration is non-trivial.
Comment 3 Larry the Git Cow gentoo-dev 2019-10-25 05:29:51 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2e53c3a2137cb2c47807af09d15e8eb83eddcbc0

commit 2e53c3a2137cb2c47807af09d15e8eb83eddcbc0
Author:     Wade Cline <wadecline@hotmail.com>
AuthorDate: 2019-09-19 05:36:33 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2019-10-25 05:29:20 +0000

    net-irc/inspircd: Fix QA issues
    
    Signed-off-by: Wade Cline <wadecline@hotmail.com>
    Closes: https://bugs.gentoo.org/694654
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 .../files/inspircd-2.0.28-fix-path-builds.patch    | 258 +-------------------
 .../files/inspircd-3.3.0-fix-path-builds.patch     | 268 +--------------------
 net-irc/inspircd/inspircd-3.3.0.ebuild             |   2 +-
 net-irc/inspircd/metadata.xml                      |   4 +-
 4 files changed, 5 insertions(+), 527 deletions(-)
Comment 4 Brian Evans (RETIRED) gentoo-dev 2019-10-25 19:15:31 UTC
https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2e53c3a2137cb2c47807af09d15e8eb83eddcbc0

net-irc/inspircd: Drop illegal symlinks
Non-maintainer commit

Remove symlinks from files/ which are banned by policy.
Adjust ebuilds to patch the intended files.

This prevents infra problems popping up like in the last 14 hours

Package-Manager: Portage-2.3.78, Repoman-2.3.17
Signed-off-by: Brian Evans <grknight@gentoo.org>
Comment 5 Brian Evans (RETIRED) gentoo-dev 2019-10-28 13:15:45 UTC
(In reply to Brian Evans from comment #4)
> https://gitweb.gentoo.org/repo/gentoo.git/commit/
> ?id=2e53c3a2137cb2c47807af09d15e8eb83eddcbc0

This should be:
https://gitweb.gentoo.org/repo/gentoo.git/commit/net-irc/inspircd?id=bd529668785ccde6d2b74600b9410512776b8d40