Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 694402 - app-portage/mgorny-dev-scripts-1: lr-add-pmask uses Michal's information for package.mask entries
Summary: app-portage/mgorny-dev-scripts-1: lr-add-pmask uses Michal's information for ...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Michał Górny
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-09-14 21:59 UTC by Pacho Ramos
Modified: 2019-09-15 05:28 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Pacho Ramos gentoo-dev 2019-09-14 21:59:33 UTC
Hello

At first thanks a lot for sharing your scripts, I was reviewing all them and I think I will use some of them a lot. Thanks.

While I was reading lr-add-pmask I noticed that it hard codes your information to fill the mask entry. 

In my system I still have the old ECHANGELOG_USER variable exported, for current setups, I am unsure if maybe we could rely on running $(git config user.name) and $(git config user.email) for similar purposes.

Thanks and regards
Comment 1 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2019-09-15 05:09:53 UTC
Heh, I looked for all hardcodes paths but forgot about this one.  Thanks, I'll try to find a reasonable chain of fallbacks.
Comment 2 Larry the Git Cow gentoo-dev 2019-09-15 05:28:36 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8a8544469d68e5c7bdd9c86b72a65936e71aef44

commit 8a8544469d68e5c7bdd9c86b72a65936e71aef44
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: 2019-09-15 05:27:52 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2019-09-15 05:28:21 +0000

    app-portage/mgorny-dev-scripts: Bump to v2
    
    Closes: https://bugs.gentoo.org/694402
    Signed-off-by: Michał Górny <mgorny@gentoo.org>

 app-portage/mgorny-dev-scripts/Manifest            |  1 +
 .../mgorny-dev-scripts/mgorny-dev-scripts-2.ebuild | 25 ++++++++++++++++++++++
 2 files changed, 26 insertions(+)