Splitting bug #652040 into smaller bugs. LICENSE="IDEA || ( IDEA_Academic IDEA_Classroom IDEA_OpenSource IDEA_Personal )" 1. This entirely misses the lot of bundled libraries. 2. IDEA is 'commercial license', while IDEA_* are other variants. It really makes no sense to require user to accept simultaneously commercial and some other license. 3. All licenses prohibit redistribution. However, ebuild misses restrictions.
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=043d79248de91244401c2cb8a7b351c620990401 commit 043d79248de91244401c2cb8a7b351c620990401 Author: Michał Górny <mgorny@gentoo.org> AuthorDate: 2019-09-13 06:57:18 +0000 Commit: Michał Górny <mgorny@gentoo.org> CommitDate: 2019-09-13 07:10:08 +0000 dev-util/goland: Add bindist&mirror restrictions Bug: https://bugs.gentoo.org/694268 Signed-off-by: Michał Górny <mgorny@gentoo.org> dev-util/goland/goland-2019.1.2.ebuild | 1 + 1 file changed, 1 insertion(+)
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e0742f118eca89d0fb18310e7ba4eb8396610368 commit e0742f118eca89d0fb18310e7ba4eb8396610368 Author: Michał Górny <mgorny@gentoo.org> AuthorDate: 2019-12-01 20:05:08 +0000 Commit: Michał Górny <mgorny@gentoo.org> CommitDate: 2019-12-01 20:19:35 +0000 package.mask: Last rite dev-util/goland Bug: https://bugs.gentoo.org/694268 Signed-off-by: Michał Górny <mgorny@gentoo.org> profiles/package.mask | 5 +++++ 1 file changed, 5 insertions(+)
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=559992972a2e5e2f6785233c74415d78e1b33846 commit 559992972a2e5e2f6785233c74415d78e1b33846 Author: Jason A. Donenfeld <zx2c4@gentoo.org> AuthorDate: 2019-12-03 10:16:05 +0000 Commit: Jason A. Donenfeld <zx2c4@gentoo.org> CommitDate: 2019-12-03 10:18:09 +0000 dev-util/goland: bump to 2019.3 This actually is maintained, so removing package mask and responding to bug report. Bug: https://bugs.gentoo.org/694268 Package-Manager: Portage-2.3.79, Repoman-2.3.18 Signed-off-by: Jason A. Donenfeld <zx2c4@gentoo.org> dev-util/goland/Manifest | 2 +- dev-util/goland/{goland-2019.1.2.ebuild => goland-2019.3.ebuild} | 0 profiles/package.mask | 5 ----- 3 files changed, 1 insertion(+), 6 deletions(-)
I'm not quite sure what we're supposed to do with the license field. Any suggestion?
The underlying problem has not been resolved.
(In reply to Jason A. Donenfeld from comment #4) > I'm not quite sure what we're supposed to do with the license field. Any > suggestion? Figure out what the actual upstream license is. Express it correctly in LICENSE field. Figure out licenses of all bundled libraries. Express them in LICENSE field. Why do I even need to explain that?
Oh, that's what you meant. Sure, I'll do some research on the package and make sure the license specifier is coherent. FTR, this wasn't my package originally.
You may look at other JetBrains packages. I think at least one of them has been fixed by a proxied maintainer, so may serve as a good starting point.
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c75c2264cc73439fd4e59c87158c39f57d7e7bf7 commit c75c2264cc73439fd4e59c87158c39f57d7e7bf7 Author: Jason A. Donenfeld <zx2c4@gentoo.org> AuthorDate: 2019-12-05 15:41:02 +0000 Commit: Jason A. Donenfeld <zx2c4@gentoo.org> CommitDate: 2019-12-05 15:42:03 +0000 dev-util/goland: update licenses Bug: https://bugs.gentoo.org/694268 Package-Manager: Portage-2.3.80, Repoman-2.3.19 Signed-off-by: Jason A. Donenfeld <zx2c4@gentoo.org> dev-util/goland/goland-2019.3.ebuild | 3 +- licenses/JetBrains-business | 105 +++++++++++++++++++++++++++++++++++ licenses/JetBrains-classroom | 87 +++++++++++++++++++++++++++++ licenses/JetBrains-educational | 94 +++++++++++++++++++++++++++++++ licenses/JetBrains-individual | 101 +++++++++++++++++++++++++++++++++ 5 files changed, 388 insertions(+), 2 deletions(-)
I've updated the package to reflect the latest licenses from JetBrains. It's up to JetBrains to encapsulate any details of bundled dependencies or other derivative code inside of their own licenses. As I'm not a lawyer and also don't have any insight into JetBrains' specific agreements with various dependency providers, I don't feel comfortable presupposing any particular details of their arrangements for distributing these various dependencies to users, outside of what they already provide in their existing licenses.
It's an established Gentoo policy that LICENSE must reflect every single file installed by the package. Therefore, as long as bundled dependencies are installed along with the package they must also be explicitly listed.
(In reply to Michał Górny from comment #11) > It's an established Gentoo policy that LICENSE must reflect every single > file installed by the package. Therefore, as long as bundled dependencies > are installed along with the package they must also be explicitly listed. The files inside of the tarball `SRC_URI="http://download.jetbrains.com/go/${P}.tar.gz"` are provided to users under the licenses specified by the ebuild. If one of those files is also made available by somebody else from elsewhere under a different license, that has no barring on how it's been licensed to the user who downloads `SRC_URI="http://download.jetbrains.com/go/${P}.tar.gz"`. I don't feel comfortable making any legal presumptions beyond that. If you disagree with that, I'd recommend CCing into this bug whoever Gentoo's legal council is for helping out with these matters. I won't accept the personal liability in making the changes you're asking me to do, sorry.
Please do not close the bug until the 'discussion has reached a conclusion'. According to the license you've committed: | 8. THIRD-PARTY SOFTWARE | 8.1. The Products include code and libraries licensed to Us by third parties, including open source software (“Third-Party Software”). A list of Third-Party Software included in each Product is available in the Product documentation. All Third-Party Software is provided to You under the respective terms stipulated in the Product documentation.X The license is *incomplete* without that list.
(In reply to Michał Górny from comment #13) > Please do not close the bug until the 'discussion has reached a conclusion'. > > According to the license you've committed: > > | 8. THIRD-PARTY SOFTWARE > | 8.1. The Products include code and libraries licensed to Us by third > parties, > including open source software (“Third-Party Software”). A list of > Third-Party Software included in each Product is available in the Product > documentation. All Third-Party Software is provided to You under the > respective terms stipulated in the Product documentation.X > > > The license is *incomplete* without that list. Ahhh! You're right. I'll find that "Product documentation" and copy the list there.
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=12a234d9b3c8164da57ca038e920ba4813e62ecb commit 12a234d9b3c8164da57ca038e920ba4813e62ecb Author: Jason A. Donenfeld <zx2c4@gentoo.org> AuthorDate: 2019-12-05 19:58:03 +0000 Commit: Jason A. Donenfeld <zx2c4@gentoo.org> CommitDate: 2019-12-05 19:58:35 +0000 dev-util/goland: include licenses of bundled libraries Bug: https://bugs.gentoo.org/694268 Package-Manager: Portage-2.3.80, Repoman-2.3.19 Signed-off-by: Jason A. Donenfeld <zx2c4@gentoo.org> dev-util/goland/goland-2019.3.ebuild | 18 +++++++++++++++++- 1 file changed, 17 insertions(+), 1 deletion(-)
Okay I think we're all set now. I'll leave this bug to you to mark as "fixed" because it seems like you have more specific criteria than me.
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=06bed999ff1616a050c48fddcb4123a997258107 commit 06bed999ff1616a050c48fddcb4123a997258107 Author: Jason A. Donenfeld <zx2c4@gentoo.org> AuthorDate: 2019-12-05 20:01:30 +0000 Commit: Jason A. Donenfeld <zx2c4@gentoo.org> CommitDate: 2019-12-05 20:01:32 +0000 dev-util/goland: add bottom-of-list missing license Bug: https://bugs.gentoo.org/694268 Package-Manager: Portage-2.3.80, Repoman-2.3.19 Signed-off-by: Jason A. Donenfeld <zx2c4@gentoo.org> dev-util/goland/goland-2019.3.ebuild | 1 + 1 file changed, 1 insertion(+)
Thank you, that was what I was asking for.
