Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 694046 - dev-lang/perl - myconf() ... "${myconf[@]}" call duplicates some flags
Summary: dev-lang/perl - myconf() ... "${myconf[@]}" call duplicates some flags
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Perl team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-09-11 15:46 UTC by Jeroen Roovers (RETIRED)
Modified: 2021-10-26 16:23 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jeroen Roovers (RETIRED) gentoo-dev 2019-09-11 15:46:24 UTC
A minor issue really. I noticed that the Configure call duplicated some configuration flags:

sh Configure -des -Dinstallprefix=/usr -Dinstallusrbinperl=n -Ui_xlocale -Di_ndbm -Di_gdbm -Di_db -Dusethreads -DDEBUGGING=-g -Dd_u32align='define' -Dnoextensions=ODBM_File -Duseshrplib -Darchname=hppa2.0-linux-thread -Dcc=hppa2.0-unknown-linux-gnu-gcc -Doptimize=-mschedule=8000 -march=2.0 -ggdb -Wall -O2 -pipe -Wno-comment -Dldflags=-Wl,-O1 -Wl,--hash-style=gnu -Wl,--as-needed -Wl,--no-keep-memory -Dprefix=/usr -Dsiteprefix=/usr/local -Dvendorprefix=/usr -Dscriptdir=/usr/bin -Dprivlib=/usr/lib/perl5/5.30.0 -Darchlib=/usr/lib/perl5/5.30.0/hppa2.0-linux-thread-multi -Dsitelib=/usr/local/lib/perl5/5.30.0 -Dsitearch=/usr/local/lib/perl5/5.30.0/hppa2.0-linux-thread-multi -Dvendorlib=/usr/lib/perl5/vendor_perl/5.30.0 -Dvendorarch=/usr/lib/perl5/vendor_perl/5.30.0/hppa2.0-linux-thread-multi -Dman1dir=/usr/share/man/man1 -Dman3dir=/usr/share/man/man3 -Dsiteman1dir=/usr/local/man/man1 -Dsiteman3dir=/usr/local/man/man3 -Dvendorman1dir=/usr/share/man/man1 -Dvendorman3dir=/usr/share/man/man3 -Dman1ext=1 -Dman3ext=3pm -Dlibperl=libperl.so.5.30.0 -Dlocincpth=/usr/include  -Dglibpth=/lib /usr/lib  -Duselargefiles -Dd_semctl_semun -Dcf_by=Gentoo -Dmyhostname=localhost -Dperladmin=root@localhost -Ud_csh -Dsh=/bin/sh -Dtargetsh=/bin/sh -Uusenm -Ui_xlocale -Di_ndbm -Di_gdbm -Di_db -Dusethreads -DDEBUGGING=-g -Dd_u32align='define' -Dnoextensions=ODBM_File

and it turns out that the myconf() (shell function) is called with "${myconf[@]}" (bash array) as argument, so that some of the enabled flags turn up at the start and also at the end of the argument list.
Comment 1 Larry the Git Cow gentoo-dev 2021-10-23 16:17:22 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c14fc41a02097c315b7f99849af169029477771f

commit c14fc41a02097c315b7f99849af169029477771f
Author:     Andreas K. Hüttel <dilfridge@gentoo.org>
AuthorDate: 2021-10-23 16:16:58 +0000
Commit:     Andreas K. Hüttel <dilfridge@gentoo.org>
CommitDate: 2021-10-23 16:17:12 +0000

    dev-lang/perl: Various experimental improvements
    
    * do not duplicate configure flags
    * set -Dccflags="${CFLAGS}"
    * hardwire SINGLE_SLOT for simplification
    
    Bug: https://bugs.gentoo.org/694046
    Bug: https://bugs.gentoo.org/806619
    Package-Manager: Portage-3.0.28, Repoman-3.0.3
    Signed-off-by: Andreas K. Hüttel <dilfridge@gentoo.org>

 dev-lang/perl/perl-5.34.0-r4.ebuild | 812 ++++++++++++++++++++++++++++++++++++
 1 file changed, 812 insertions(+)
Comment 2 Larry the Git Cow gentoo-dev 2021-10-26 16:23:38 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=4b0050c7770f26eba5b5e704bc67ffcf82af2052

commit 4b0050c7770f26eba5b5e704bc67ffcf82af2052
Author:     Andreas K. Hüttel <dilfridge@gentoo.org>
AuthorDate: 2021-10-26 16:23:02 +0000
Commit:     Andreas K. Hüttel <dilfridge@gentoo.org>
CommitDate: 2021-10-26 16:23:02 +0000

    dev-lang/perl: Re-keyword -r5
    
    * Set -Dccflags="${CFLAGS}", bug 806619
    * Drop duplicate configure flags, bug 694046
    * Hardcode SINGLE_SLOT for simplification
    
    Closes: https://bugs.gentoo.org/694046
    Closes: https://bugs.gentoo.org/806619
    Bug: https://bugs.gentoo.org/261375
    Package-Manager: Portage-3.0.28, Repoman-3.0.3
    Signed-off-by: Andreas K. Hüttel <dilfridge@gentoo.org>

 dev-lang/perl/perl-5.34.0-r5.ebuild | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)