wxGTK provides a GUI toolkit that can be enabled via "--enable-gui". Right now, this is enabled implicitly if the 'X' or 'aqua' USE flags are set, but it would be useful to have an explicit option (e.g. 'guitk' or similar) to do so for packages that depend on the functionality. See also the discussion on the Odamex 0.8.1 version bump pull request: https://github.com/gentoo/gentoo/pull/12863#discussion_r320943226
This just introduces unnecessary REQUIRED_USE constructs imho (ones that people hit much easier and often, as it doesn't involve a rarely set USE=aqua). Usually the consumers would also need to have a similar USE flag set (especially aqua) to adapt the build for it, and then it's a natural [aqua?,X?] dep. Have you actually tested your thing against aqua, or are just guessing it works? I don't think aqua is something you can just blindly add untested and think it'll work. In fact, I don't have a clue USE=aqua actually works on wxGTK and have contemplated removing it; plus it's actually wxOSX at that point, not wxGTK..
Sorry, it's actually still wxGTK; hit the button too soon. It uses the gtk OSX port then. But you can also see that gtk+ doesn't have a USE=guitk, but X, wayland and aqua USE flags.
I haven't tested my package yet with USE=aqua, so you may be right that it might not work. Perhaps it would be best to follow the GTK+ ebuild as you say and simply require an explicit X or aqua flag. I'm also not very familiar with the wxGTK build options. What does "--enable-gui" actually enable in terms of the ABI (i.e. which functions, structures, etc.)?
I believe without USE=X or USE=aqua you get only wxBase - libwx_baseu-3.0.so and such.
Sorry if I was off the mark with this one. I felt the suggested REQUIRED_USE wouldn't get in the way because it would still build the GUI stuff is when USE="-gui X". I also expected aqua would just work all in cases where X does. It would be great is someone from prefix could confirm this or at least whether wxGTK[aqua] still works at all.
My understanding is that for wxGTK, aqua controls the dep-set not to pull in X, but just gtk[aqua]. That is, you still have wxGTK (not wxOSX), but GTK uses OSX native window manager, iso X. I may be wrong here. In any case, dropping USE=aqua for this package is an option for sure.
(In reply to Fabian Groffen from comment #6) > My understanding is that for wxGTK, aqua controls the dep-set not to pull in > X, but just gtk[aqua]. That is, you still have wxGTK (not wxOSX), but GTK > uses OSX native window manager, iso X. I may be wrong here. In any case, > dropping USE=aqua for this package is an option for sure. That's what I thought it did but the real question is does it still work? :)
(In reply to James Le Cuirot from comment #7) > That's what I thought it did but the real question is does it still work? :) I can't even get a clean deptree, so why don't we assume it does *not* work (anymore). I know for sure this code isn't used for years, so please drop it.
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8ca68c043e93652c6d8737f6de784997cfda143d commit 8ca68c043e93652c6d8737f6de784997cfda143d Author: Fabian Groffen <grobian@gentoo.org> AuthorDate: 2021-01-18 19:28:57 +0000 Commit: Fabian Groffen <grobian@gentoo.org> CommitDate: 2021-01-18 19:29:24 +0000 x11-libs/wxGTK: drop ppc-macos/USE=aqua code Closes: https://bugs.gentoo.org/693636 Package-Manager: Portage-3.0.12, Repoman-3.0.2 Signed-off-by: Fabian Groffen <grobian@gentoo.org> x11-libs/wxGTK/wxGTK-3.0.4-r2.ebuild | 22 +++------------------- x11-libs/wxGTK/wxGTK-3.0.4-r302.ebuild | 22 +++------------------- 2 files changed, 6 insertions(+), 38 deletions(-)
