Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 693592 - www-apache/mod_authz_unixgroup-1.1.0 - An Apache2 authentication DSO using external programs
Summary: www-apache/mod_authz_unixgroup-1.1.0 - An Apache2 authentication DSO using ex...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Default Assignee for New Packages
URL: https://github.com/phokz/mod-auth-ext...
Whiteboard:
Keywords: EBUILD
Depends on:
Blocks:
 
Reported: 2019-09-06 07:09 UTC by Joakim Tjernlund
Modified: 2019-09-06 14:43 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Ebuild for package (mod_authz_unixgroup-1.1.0.ebuild,767 bytes, text/plain)
2019-09-06 07:11 UTC, Joakim Tjernlund
Details
files/10_mod_authz_unixgroup.conf (10_mod_authz_unixgroup.conf,987 bytes, text/plain)
2019-09-06 07:12 UTC, Joakim Tjernlund
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Joakim Tjernlund 2019-09-06 07:09:49 UTC
https://github.com/phokz/mod-auth-external

Use to authorize against unix groups:
 Require unix-group grp1 grp2
Comment 1 Joakim Tjernlund 2019-09-06 07:11:35 UTC
Created attachment 589162 [details]
Ebuild for package
Comment 2 Joakim Tjernlund 2019-09-06 07:12:23 UTC
Created attachment 589164 [details]
files/10_mod_authz_unixgroup.conf
Comment 3 Joakim Tjernlund 2019-09-06 07:17:24 UTC
Craig, since this pkg is from the same place as mod_authnz_external I figured
you might want to maintain this pkg?
Comment 4 Jeroen Roovers (RETIRED) gentoo-dev 2019-09-06 07:21:43 UTC
Comment on attachment 589162 [details]
Ebuild for package

># Copyright 1999-2019 Gentoo Authors
># Distributed under the terms of the GNU General Public License v2
>
>EAPI=6
>inherit apache-module
>
>if [[ ${PV} == *9999 ]] ; then
>	EGIT_REPO_URI="https://github.com/phokz/mod-auth-external.git"

Github URIs do not require the ".git" suffix these days.

>	inherit git-r3
>	S="${WORKDIR}/${P}/mod_authnz_external"
>else
>	SRC_URI="https://github.com/phokz/mod-auth-external/archive/${P}.tar.gz"
>	KEYWORDS="amd64 x86"

Straight to stable?

>	S="${WORKDIR}/mod-auth-external-${P}"
>fi
>
>DESCRIPTION="An Apache2 authentication DSO using external programs"
>HOMEPAGE="https://github.com/phokz/mod-auth-external"
>
>LICENSE="Apache-1.1"
>SLOT="2"

Why have this specific SLOT when you can start at "0"?

>IUSE=""

No need to set an empty IUSE

>need_apache2_4
>
>DOCFILES="CHANGES INSTALL README NOTICE"
>
>APACHE2_MOD_CONF="10_${PN}"
>APACHE2_MOD_DEFINE="AUTHNZ_EXTERNAL"
>
>pkg_setup() {
>	_init_apache2
>	_init_apache2_late

Those are marked "INTERNAL" in depend.apache.eclass. According to that eclass they should not be used directly.

>}
Comment 5 Joakim Tjernlund 2019-09-06 08:26:44 UTC
(In reply to Jeroen Roovers from comment #4)
> Comment on attachment 589162 [details]
> Ebuild for package
> 
> ># Copyright 1999-2019 Gentoo Authors
> ># Distributed under the terms of the GNU General Public License v2
> >
> >EAPI=6
> >inherit apache-module
> >
> >if [[ ${PV} == *9999 ]] ; then
> >	EGIT_REPO_URI="https://github.com/phokz/mod-auth-external.git"
> 
> Github URIs do not require the ".git" suffix these days.
> 
> >	inherit git-r3
> >	S="${WORKDIR}/${P}/mod_authnz_external"
> >else
> >	SRC_URI="https://github.com/phokz/mod-auth-external/archive/${P}.tar.gz"
> >	KEYWORDS="amd64 x86"
> 
> Straight to stable?
> 
> >	S="${WORKDIR}/mod-auth-external-${P}"
> >fi
> >
> >DESCRIPTION="An Apache2 authentication DSO using external programs"
> >HOMEPAGE="https://github.com/phokz/mod-auth-external"
> >
> >LICENSE="Apache-1.1"
> >SLOT="2"
> 
> Why have this specific SLOT when you can start at "0"?
> 
> >IUSE=""
> 
> No need to set an empty IUSE
> 
> >need_apache2_4
> >
> >DOCFILES="CHANGES INSTALL README NOTICE"
> >
> >APACHE2_MOD_CONF="10_${PN}"
> >APACHE2_MOD_DEFINE="AUTHNZ_EXTERNAL"
> >
> >pkg_setup() {
> >	_init_apache2
> >	_init_apache2_late
> 
> Those are marked "INTERNAL" in depend.apache.eclass. According to that
> eclass they should not be used directly.
> 
> >}

I modelled this ebuild after mod_authnz_external as this pkg comes from the
same source. All your points above comes from that ebuild, I hope 
Craig can respond to them?
Comment 6 Larry the Git Cow gentoo-dev 2019-09-06 14:43:34 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c96c2de5113e1c6d4741c4c1f9df4256e7210bc2

commit c96c2de5113e1c6d4741c4c1f9df4256e7210bc2
Author:     Craig Andrews <candrews@gentoo.org>
AuthorDate: 2019-09-06 14:42:31 +0000
Commit:     Craig Andrews <candrews@gentoo.org>
CommitDate: 2019-09-06 14:43:06 +0000

    www-apache/mod_authz_unixgroup: An Apache2 authorization DSO using unix groups
    
    Closes: https://bugs.gentoo.org/693592
    Package-Manager: Portage-2.3.75, Repoman-2.3.17
    Signed-off-by: Craig Andrews <candrews@gentoo.org>

 www-apache/mod_authz_unixgroup/Manifest            |  1 +
 .../files/10_mod_authz_unixgroup.conf              | 11 ++++++++
 www-apache/mod_authz_unixgroup/metadata.xml        | 11 ++++++++
 .../mod_authz_unixgroup-1.1.0.ebuild               | 32 ++++++++++++++++++++++
 .../mod_authz_unixgroup-9999.ebuild                | 32 ++++++++++++++++++++++
 5 files changed, 87 insertions(+)