Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 693526 - app-misc/neofetch - QA Notice: the following files are outside of the prefix: /usr /usr/bin /usr/bin/neofetch /usr/share /usr/share/man /usr/share/man/man1 /usr/share/man/man1/neofetch.1
Summary: app-misc/neofetch - QA Notice: the following files are outside of the prefix:...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Muhammad Herdiansyah
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2019-09-04 23:31 UTC by Jan Breig
Modified: 2021-02-05 07:00 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
ebuild-patch.diff (file_693526.txt,308 bytes, text/plain)
2019-09-04 23:31 UTC, Jan Breig 		Details
emerge --info (file_693526.txt,5.96 KB, text/plain)
2019-09-04 23:32 UTC, Jan Breig 		Details
build.log (file_693526.txt,2.62 KB, text/plain)
2019-09-04 23:33 UTC, Jan Breig 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Breig 2019-09-04 23:31:23 UTC 
Created attachment 589070 [details]
ebuild-patch.diff

Emerge on prefix fails with:

 * QA Notice: the following files are outside of the prefix:
 * /usr
 * /usr/bin
 * /usr/bin/neofetch
 * /usr/share
 * /usr/share/man
 * /usr/share/man/man1
 * /usr/share/man/man1/neofetch.1
 * ERROR: app-misc/neofetch-6.0.0::gentoo failed:
 *   Aborting due to QA concerns: there are files installed outside the prefix
 * 
 * Call stack:
 *   misc-functions.sh, line 586:  Called install_qa_check
 *   misc-functions.sh, line 132:  Called source 'install_symlink_html_docs'
 *            05prefix, line 114:  Called install_qa_check_prefix
 *            05prefix, line  27:  Called die
 * The specific snippet of code:
 *                      die "Aborting due to QA concerns: there are files installed outside the prefix"

The attached patch for the ebuild resolves the issue for neofetch.

The src_install of EAPI 6+ defaults to 'emake DESTDIR="${D}" install'.
The 'installed outside of prefix' error basically occurs on any package that uses the default src_install. The ebuild function should probably default to 'emake DESTDIR="${ED}" install' to avoid this error on all of these packages.
Comment 1 Jan Breig 2019-09-04 23:32:24 UTC 
Created attachment 589072 [details]
emerge --info
Comment 2 Jan Breig 2019-09-04 23:33:24 UTC 
Created attachment 589074 [details]
build.log
Comment 3 Larry the Git Cow gentoo-dev 2021-02-05 07:00:47 UTC 
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=bb7b6b0caf02195a62ba5aeefade48dab6bf421f

commit bb7b6b0caf02195a62ba5aeefade48dab6bf421f
Author:     WuYiyang <xgreenlandforwyy@gmail.com>
AuthorDate: 2021-02-05 06:05:22 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2021-02-05 07:00:44 +0000

    app-misc/neofetch: Gentoo Prefix support
    
    * Move install location inside prefix
    * hprefixify neofetch to recognize prefix environment
    * Modify neofetch to enable counting packages installed by portage in prefix
    (this will also keep the host system's packages manager's information, except
    for using gentoo prefix upon gentoo)
    
    Closes: https://bugs.gentoo.org/693526
    Package-Manager: Portage-3.0.14, Repoman-3.0.2
    Signed-off-by: Yiyang Wu <xgreenlandforwyy@gmail.com>
    Closes: https://github.com/gentoo/gentoo/pull/19341
    Signed-off-by: Sam James <sam@gentoo.org>

 app-misc/neofetch/neofetch-7.1.0.ebuild | 14 +++++++++++++-
 app-misc/neofetch/neofetch-9999.ebuild  | 14 +++++++++++++-
 2 files changed, 26 insertions(+), 2 deletions(-)