Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 693244 - app-editors/nano: the split-usr use flag adds no value
Summary: app-editors/nano: the split-usr use flag adds no value
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal with 1 vote (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-09-01 00:26 UTC by William Hubbs
Modified: 2022-12-06 19:04 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
0001-app-editors-nano-remove-the-split-usr-use-flag.patch (0001-app-editors-nano-remove-the-split-usr-use-flag.patch,3.86 KB, patch)
2019-09-01 00:31 UTC, William Hubbs
Details | Diff
nano-4.4-r1.ebuild (nano-4.4-r1.ebuild,2.09 KB, text/plain)
2019-09-01 19:38 UTC, William Hubbs
Details

Note You need to log in before you can comment on or make changes to this bug.
Description William Hubbs gentoo-dev 2019-09-01 00:26:34 UTC
I looked at the ebuild for nano and noticed that the split-usr use flag
adds a symbolic link to /usr/bin/nano in /bin.

I do not see the value in having nano in /usr/bin and /bin since they
are both in the path.
both are in the path.

This patch removes the use flag. I think it should be safe to remove it
all the way across the board.
Comment 1 William Hubbs gentoo-dev 2019-09-01 00:31:57 UTC
Created attachment 588610 [details, diff]
0001-app-editors-nano-remove-the-split-usr-use-flag.patch


Here is the patch.
Comment 2 Mike Gilbert gentoo-dev 2019-09-01 17:40:09 UTC
This may cause some small amount of confusion for anybody who has EDITOR=/usr/bin/nano set in their environment. I expect this population is quite tiny.
Comment 3 William Hubbs gentoo-dev 2019-09-01 19:38:47 UTC
Created attachment 588642 [details]
nano-4.4-r1.ebuild

If you forget about the previous patch, another possibility is to move
nano bac to /usr/bin as shown in this revbump.

This is nano-4.4-r1.ebuild.
Comment 4 Matt Whitlock 2022-11-17 09:36:09 UTC
Maybe there was some confusion back in 2019 regarding the purpose of USE="split-usr"?

Rationally, the app-editors/nano ebuild should make this change:

local myconfargs=(
	$(usex split-usr --bindir="${EPREFIX}/bin" '')
	...
)

This means, if USE="split-usr", then the nano binary will be installed to /bin/nano, where it can be used even without /usr mounted. However, if USE="-split-usr", then the nano binary will be installed to the autoconf-default location of /usr/bin/nano, which is expected to live in the same file system as /bin.

Furthermore, on a merged-usr system (which is the intended use case for USE="-split-usr"), /bin is a symlink to /usr/bin, so /bin/nano will resolve to /usr/bin/nano, and thus either of those path names will work as EDITOR.
Comment 5 Larry the Git Cow gentoo-dev 2022-12-06 19:04:07 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6afd21d9b4340c875b2739ee7d8f0275914921e1

commit 6afd21d9b4340c875b2739ee7d8f0275914921e1
Author:     Mike Gilbert <floppym@gentoo.org>
AuthorDate: 2022-12-06 19:01:05 +0000
Commit:     Mike Gilbert <floppym@gentoo.org>
CommitDate: 2022-12-06 19:03:25 +0000

    app-editors/nano: drop /usr/bin/nano symlink
    
    Closes: https://bugs.gentoo.org/693244
    Signed-off-by: Mike Gilbert <floppym@gentoo.org>

 app-editors/nano/{nano-7.0.ebuild => nano-7.0-r1.ebuild} | 4 +---
 app-editors/nano/nano-9999.ebuild                        | 4 +---
 2 files changed, 2 insertions(+), 6 deletions(-)