Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 693160 - [mozilla overlay] mail-client/thunderbird-68.0-r1: Missing file(s): bin/defaults/pref/all-gentoo.js with PGO builds
Summary: [mozilla overlay] mail-client/thunderbird-68.0-r1: Missing file(s): bin/defau...
Status: RESOLVED TEST-REQUEST
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Overlays (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Mozilla Gentoo Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-08-31 05:29 UTC by Perfect Gentleman
Modified: 2023-04-25 17:10 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log.xz (build.log.xz,297.94 KB, application/x-xz)
2019-08-31 05:29 UTC, Perfect Gentleman
Details
unbreak pgo builds (0001-mail-client-thunderbird-68.0-don-t-error-on-missing-.patch,1.04 KB, patch)
2019-08-31 23:17 UTC, Jory A. Pratt
Details | Diff
Patch fixes freezing during profile generation phase (thunderbird-pgo_freeze_fix.patch,469 bytes, patch)
2021-11-11 02:27 UTC, Perfect Gentleman
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Perfect Gentleman 2019-08-31 05:29:07 UTC
Created attachment 588570 [details]
build.log.xz

~ $ emerge --info
Portage 2.3.73 (python 3.7.4-final-0, default/linux/amd64/17.1/no-multilib, gcc-9.2.0, glibc-2.30, 5.2.11-gentoo x86_64)
=================================================================
System uname: Linux-5.2.11-gentoo-x86_64-Intel-R-_Core-TM-_i7-4770K_CPU_@_3.50GHz-with-gentoo-2.6
KiB Mem:    15832264 total,   4796044 free
KiB Swap:   13720572 total,  13398268 free
Head commit of repository palemoon: c353cebac96eb62e45dc5e94a254ba3cf90cb8bc

Head commit of repository gnome: d6c0a730d416f1f7ae2393c7eac9b6e5eb715eb5

Head commit of repository gentoo: 60bf9902b8cc53c5452fc40814fa23f392005389

Head commit of repository mozilla: 440bb323a15511b83195d71fee93958819cd4f5e

Head commit of repository qt: 5ef48b743de735a133387696ccec388f1ca76be2

Head commit of repository kde: dedef6b81895e259d585fa235b2ac9c81bb077e1

Head commit of repository pg_overlay: b4a82d477cfa7724535db389357d884fe85abe58

sh bash 5.0_p9
ld GNU gold (Gentoo 2.32 p2 2.32.0) 1.16
ccache version 3.7.3 [disabled]
app-shells/bash:          5.0_p9::gentoo
dev-lang/perl:            5.30.0::gentoo
dev-lang/python:          2.7.16::gentoo, 3.7.4-r1::gentoo
dev-util/ccache:          3.7.3::gentoo
dev-util/cmake:           3.15.2::gentoo
sys-apps/baselayout:      2.6-r1::gentoo
sys-apps/openrc:          0.42.1::gentoo
sys-apps/sandbox:         2.18::gentoo
sys-devel/autoconf:       2.13-r1::gentoo, 2.69-r4::gentoo
sys-devel/automake:       1.16.1-r1::gentoo
sys-devel/binutils:       2.32-r1::gentoo
sys-devel/gcc:            9.2.0::gentoo
sys-devel/gcc-config:     2.0::gentoo
sys-devel/libtool:        2.4.6-r5::gentoo
sys-devel/make:           4.2.1-r4::gentoo
sys-kernel/linux-headers: 5.2::gentoo (virtual/os-headers)
sys-libs/glibc:           2.30::gentoo
Repositories:

palemoon
    location: /usr/portage/overlay/palemoon
    sync-type: git
    sync-uri: https://github.com/deu/palemoon-overlay.git
    masters: gentoo
    priority: -1
    eclass-overrides: gnome mozilla gentoo qt kde pg_overlay

gnome
    location: /usr/portage/proj/gnome
    sync-type: git
    sync-uri: https://anongit.gentoo.org/git/proj/gnome.git
    masters: gentoo
    priority: 3
    eclass-overrides: gnome mozilla gentoo qt kde pg_overlay

gentoo
    location: /usr/portage
    sync-type: git
    sync-uri: https://anongit.gentoo.org/git/repo/gentoo.git
    priority: 5
    eclass-overrides: gnome mozilla gentoo qt kde pg_overlay
    sync-git-clone-extra-opts: --depth 1 --single-branch --branch master

mozilla
    location: /usr/portage/proj/mozilla
    sync-type: git
    sync-uri: https://anongit.gentoo.org/git/proj/mozilla.git
    masters: gentoo
    priority: 7
    eclass-overrides: gnome mozilla gentoo qt kde pg_overlay

qt
    location: /usr/portage/proj/qt
    sync-type: git
    sync-uri: https://anongit.gentoo.org/git/proj/qt.git
    masters: gentoo
    priority: 9
    eclass-overrides: gnome mozilla gentoo qt kde pg_overlay

kde
    location: /usr/portage/proj/kde
    sync-type: git
    sync-uri: https://anongit.gentoo.org/git/proj/kde.git
    masters: gentoo
    priority: 11
    eclass-overrides: gnome mozilla gentoo qt kde pg_overlay

pg_overlay
    location: /usr/portage/overlay/pg_overlay
    sync-type: git
    sync-uri: https://github.com/perfect7gentleman/pg_overlay.git
    masters: gentoo
    priority: 13
    eclass-overrides: gnome mozilla gentoo qt kde pg_overlay

ACCEPT_KEYWORDS="amd64 ~amd64"
ACCEPT_LICENSE="*"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-march=native -mtune=native -O2 -pipe -fomit-frame-pointer -fno-plt -fno-stack-protector -ftree-vectorize -flto=9 -fuse-linker-plugin -s"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/lib64/libreoffice/program/sofficerc /usr/share/config /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo"
CXXFLAGS="-march=native -mtune=native -O2 -pipe -fomit-frame-pointer -fno-plt -fno-stack-protector -ftree-vectorize -flto=9 -fuse-linker-plugin -s"
DISTDIR="/usr/portage/distfiles"
ENV_UNSET="DBUS_SESSION_BUS_ADDRESS DISPLAY GOBIN PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR"
FCFLAGS="-march=native -mtune=native -O2 -pipe -fomit-frame-pointer -fno-plt -fno-stack-protector -ftree-vectorize -flto=9 -fuse-linker-plugin -s"
FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs config-protect-if-modified distlocks ebuild-locks fixlafiles ipc-sandbox merge-sync multilib-strict network-sandbox news parallel-fetch parallel-install pid-sandbox preserve-libs protect-owned sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS="-march=native -mtune=native -O2 -pipe -fomit-frame-pointer -fno-plt -fno-stack-protector -ftree-vectorize -flto=9 -fuse-linker-plugin -s"
GENTOO_MIRRORS="http://distfiles.gentoo.org"
INSTALL_MASK="/lib/systemd /usr/lib/systemd"
LANG="en_US.utf8"
LDFLAGS="-Wl,-O2 -Wl,--as-needed -Wl,--sort-common -Wl,--strip-debug -flto=9 -fuse-linker-plugin"
LINGUAS="en en_US ru ru_RU"
MAKEOPTS="-j9"
PKGDIR="/usr/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/tmp"
USE="X acl alsa amd64 bash-completion bzip2 cairo cli cups custom-cflags cxx dbus dri elogind ffmpeg flac fontconfig gdbm gif gmp iconv icu introspection jpeg kde lcms libtirpc lzma lzo mmap mtp ncurses nls nptl opengl openmp orc pam pch pcre png pulseaudio readline seccomp split-usr ssl svg symlink threads tiff truetype udev unicode vaapi wavpack webp xattr xcb xft xmpp zip zlib zstd" ABI_X86="64" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="karbon sheets words" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="aes avx avx2 f16c fma3 mmx mmxext pclmul popcnt sse sse2 sse3 sse4_1 sse4_2 ssse3" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="libinput" KERNEL="linux" L10N="en en_US ru ru_RU" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" NETBEANS_MODULES="apisupport cnd groovy gsf harness ide identity j2ee java mobility nb php profiler soa visualweb webcommon websvccommon xml" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php7-2" POSTGRES_TARGETS="postgres10 postgres11" PYTHON_SINGLE_TARGET="python3_7" PYTHON_TARGETS="python3_7" RUBY_TARGETS="ruby26" USERLAND="GNU" VIDEO_CARDS="intel i965" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CC, CPPFLAGS, CTARGET, CXX, EMERGE_DEFAULT_OPTS, LC_ALL, PORTAGE_BINHOST, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPT

-------------------------------------------------------------------------------

 ~ $ cat /etc/portage/env/clang_lto 
CC="clang"
CXX="clang++"
COMMON_FLAGS="-march=native -mtune=native -O3 -pipe -fomit-frame-pointer -fno-plt -fno-stack-protector -flto -flto=full"
CFLAGS="${COMMON_FLAGS}"
CXXFLAGS="${COMMON_FLAGS} -stdlib=libc++"
FCFLAGS="${COMMON_FLAGS}"
FFLAGS="${COMMON_FLAGS}"
LDFLAGS="-Wl,-O2 -Wl,--as-needed -Wl,--strip-debug -flto -flto=full -fuse-ld=lld"
AR="llvm-ar"
NM="llvm-nm"
RANLIB="llvm-ranlib
Comment 1 Jory A. Pratt gentoo-dev 2019-08-31 16:49:01 UTC
Sat Aug 31 10:52
anarchy@bull thunderbird $ emerge thunderbird
Calculating dependencies... done!
>>> Verifying ebuild manifests
>>> Running pre-merge checks for mail-client/thunderbird-68.0-r1
 * Checking for at least 4 GiB disk space at "/var/tmp/portage/mail-client/thunderbird-68.0-r1/temp" ...                                                 [ ok ]
>>> Emerging (1 of 1) mail-client/thunderbird-68.0-r1::mozilla
>>> Installing (1 of 1) mail-client/thunderbird-68.0-r1::mozilla
>>> Jobs: 1 of 1 complete                           Load avg: 1.80, 2.00, 2.69

 * Messages for package mail-client/thunderbird-68.0-r1:

 * You are enabling official branding. You may not redistribute this build
 * to any users on your network or the internet. Doing so puts yourself into
 * a legal problem with Mozilla Foundation.
 * You can disable it by emerging thunderbird _with_ the bindist USE-flag.
 * User patches applied.
>>> Auto-cleaning packages...

>>> No outdated packages were found on your system.

 * GNU info directory index is up-to-date.
Sat Aug 31 11:31
anarchy@bull thunderbird
Comment 2 Jory A. Pratt gentoo-dev 2019-08-31 23:17:20 UTC
Created attachment 588608 [details, diff]
unbreak pgo builds

If you would please test and let me know. I do not use PGO or LTO builds hense I am not seeing the failure. If the over sight on my upgrade is fixed with this patch, I will re-add to the overlay and get tb-68 moved into the tree.
Comment 3 Jory A. Pratt gentoo-dev 2019-09-01 12:57:07 UTC
Feel free to reopen if you are still having issues.
Comment 4 Larry the Git Cow gentoo-dev 2019-09-01 23:57:03 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e3442ec85f155852d3e0474dcdbe838d94852b52

commit e3442ec85f155852d3e0474dcdbe838d94852b52
Author:     Thomas Deutschmann <whissi@gentoo.org>
AuthorDate: 2019-09-01 23:54:54 +0000
Commit:     Thomas Deutschmann <whissi@gentoo.org>
CommitDate: 2019-09-01 23:54:54 +0000

    profiles: base: Add mail-client/thunderbird[pgo] to package.use.mask
    
    Bug: https://bugs.gentoo.org/693160
    Signed-off-by: Thomas Deutschmann <whissi@gentoo.org>

 profiles/base/package.use.mask | 4 ++++
 1 file changed, 4 insertions(+)
Comment 5 Perfect Gentleman 2019-09-02 12:57:00 UTC
I'll test it.
Comment 6 Perfect Gentleman 2019-09-03 07:07:51 UTC
the bug is gone.
but when built with PGO, build system launches default browser for test which after several minutes does nothing, and compiling halts.
Comment 7 Alexandra Parker 2021-11-07 07:05:37 UTC
I unmasked pgo for thunderbird 91.3.0 and it compiles and runs fine. Maybe time to unmask that flag for testing?

profiles/base/package.use.mask:

# Thomas Deutschmann <whissi88@gentoo.org> (2019-09-02)
# PGO not yet supported for comm-central, bug #693160
>=mail-client/thunderbird-68 pgo
Comment 8 Joonas Niilola gentoo-dev 2021-11-10 13:37:34 UTC
(In reply to Alexandra Parker from comment #7)
> I unmasked pgo for thunderbird 91.3.0 and it compiles and runs fine. Maybe
> time to unmask that flag for testing?
> 
> profiles/base/package.use.mask:
> 
> # Thomas Deutschmann <whissi88@gentoo.org> (2019-09-02)
> # PGO not yet supported for comm-central, bug #693160
> >=mail-client/thunderbird-68 pgo

It hangs for me, especially with gcc (didn't get to clang yet). Do you use clang or gcc?

I guess it needs some patches that have landed to firefox already.
Comment 9 Perfect Gentleman 2021-11-11 02:27:04 UTC
Created attachment 750246 [details, diff]
Patch fixes freezing during profile generation phase
Comment 10 Alexandra Parker 2021-11-11 02:44:36 UTC
(In reply to Joonas Niilola from comment #8)
> (In reply to Alexandra Parker from comment #7)
> > I unmasked pgo for thunderbird 91.3.0 and it compiles and runs fine. Maybe
> > time to unmask that flag for testing?
> > 
> > profiles/base/package.use.mask:
> > 
> > # Thomas Deutschmann <whissi88@gentoo.org> (2019-09-02)
> > # PGO not yet supported for comm-central, bug #693160
> > >=mail-client/thunderbird-68 pgo
> 
> It hangs for me, especially with gcc (didn't get to clang yet). Do you use
> clang or gcc?
> 
> I guess it needs some patches that have landed to firefox already.

I used clang... I think the Firefox ebuild only allows pgo with clang, too, right?
Comment 11 Joonas Niilola gentoo-dev 2021-11-11 16:33:40 UTC
(In reply to Alexandra Parker from comment #10)
> 
> I used clang... I think the Firefox ebuild only allows pgo with clang, too,
> right?

It works with both now. There was a moment when it only worked with clang.


(In reply to Perfect Gentleman from comment #9)
> Created attachment 750246 [details, diff] [details, diff]
> Patch fixes freezing during profile generation phase

That doesn't look very legit :P Overall I think we came to a conclusion that upstream currently does not enable pgo builds, so so shouldn't we. We'll end up hunting patches from release to another if upstream doesn't want to fix it.
Comment 12 Perfect Gentleman 2021-11-11 16:41:45 UTC
(In reply to Joonas Niilola from comment #11)
> (In reply to Perfect Gentleman from comment #9)
> > Created attachment 750246 [details, diff] [details, diff] [details, diff]
> > Patch fixes freezing during profile generation phase
> 
> That doesn't look very legit :P Overall I think we came to a conclusion that
> upstream currently does not enable pgo builds, so so shouldn't we. We'll end
> up hunting patches from release to another if upstream doesn't want to fix
> it.

I created it for older version of TB like in the subject. It didn't worked on previous versions 71 and 78, but it starts working again on 91.3.
I don't know what it exactly does. It seems to that it make build system do not wait the completion of on of the tests.
Comment 13 Alexandra Parker 2021-12-19 18:06:46 UTC
I found another problem: thunderbird and firefox both have a build/pgo/profileserver.py that binds to 8888, so you can't build them at the same time