Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 692860 - circular dependency between menu-cache and libfm emerging lxde
Summary: circular dependency between menu-cache and libfm emerging lxde
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: Normal normal
Assignee: LXDE team (DEFUNCT)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-08-25 21:54 UTC by Steve Arnold
Modified: 2019-09-22 13:51 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Arnold archtester gentoo-dev 2019-08-25 21:54:39 UTC
The deps are currently unresolvable and neither will build without the other in place, however, both libfm-extra and menu-cache will build in that order.

I would recommend changing the dep in lxde-base/menu-cache to libfm-extra instead of libfm *and* libfm-extra (or at least make libfm-extra the first option).
Comment 1 Hanno Böck gentoo-dev 2019-08-26 06:49:11 UTC
It seems this dependency was introduced here:
https://gitweb.gentoo.org/repo/gentoo.git/commit/lxde-base/menu-cache?id=312ab0254c4a4c576c61fdf14e17a3a7d0a603b8

CCing author and commiter, maybe they can comment on the motivation for this change.

I agree this looks wrong. Given libfm depends on libfm-extra this ||-dep seems pointless and should probably be changed back to only depend on libfm-extra.
Comment 2 Larry the Git Cow gentoo-dev 2019-09-22 13:51:07 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e769cc5a9b4ed8d835cdec8a2391eb3ccf7d61e9

commit e769cc5a9b4ed8d835cdec8a2391eb3ccf7d61e9
Author:     Hanno <hanno@gentoo.org>
AuthorDate: 2019-09-22 13:50:59 +0000
Commit:     Hanno <hanno@gentoo.org>
CommitDate: 2019-09-22 13:50:59 +0000

    lxde-base/menu-cache: Simplify dependencies.
    
    There's no need for the || dependency as libfm always
    depends in libfm-extra.
    
    Closes: https://bugs.gentoo.org/692860
    Signed-off-by: Hanno Boeck <hanno@gentoo.org>
    Package-Manager: Portage-2.3.76, Repoman-2.3.17

 lxde-base/menu-cache/menu-cache-1.1.0.ebuild | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)