Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 692648 - gnome-base/gdm : xinitrc.d/50-ssh-agent should not modify ${command} variable
Summary: gnome-base/gdm : xinitrc.d/50-ssh-agent should not modify ${command} variable
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-08-20 22:20 UTC by Alexander Tsoy
Modified: 2021-04-30 16:08 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Tsoy 2019-08-20 22:20:02 UTC
xinitrc.d scripts should not modify ${command} variable. The only exception is "80-dbus" script from sys-apps/dbus. The following is caused by xinitrc.d/50-ssh-agent script:

/etc/gdm/Xsession: Setup done, will execute: /usr/bin/ssh-agent -- /usr/bin/gnome-session

$ pgrep -a ssh-agent
1814 /usr/bin/ssh-agent -- /usr/bin/gnome-session


I don't quite understand how this doesn't prevent gnome-session from starting. %) Maybe it is starting via /etc/X11/Sessions/Gnome or /etc/X11/xinit/xinitrc scripts (50-ssh-agent do nothing on second run because SSH_AUTH_SOCK is defined).
Comment 1 Alexander Tsoy 2019-08-20 22:47:33 UTC
(In reply to Alexander Tsoy from comment #0)
> The only exception is "80-dbus" script from sys-apps/dbus.
And consolekit of course.
Comment 2 Matt Turner gentoo-dev 2021-04-30 15:21:59 UTC
Suggest a fix?
Comment 3 Larry the Git Cow gentoo-dev 2021-04-30 16:08:47 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b7cbef6cf8bcca85cbb0594e62226c8a6a262b69

commit b7cbef6cf8bcca85cbb0594e62226c8a6a262b69
Author:     Matt Turner <mattst88@gentoo.org>
AuthorDate: 2021-04-30 02:27:41 +0000
Commit:     Matt Turner <mattst88@gentoo.org>
CommitDate: 2021-04-30 16:08:16 +0000

    gnome-base/gdm: Version bump to 40.0
    
    * Drop 49-keychain and 50-ssh-agent files (bugs #549102, #692648)
    * Switch to Meson (resolves bug #585976)
    ** Remove unnecessary fontconfig, libXext, iso-codes, libgudev,
       libXinerama dependencies
    * Remove unused introspection, smartcard, xinerama USE flags
    * Depend on xorg-server[-minimal] (bug #660546)
    * Resolve bug #613222, resolved upstream in v40.0
    * Resolve bug #733708, resolved upstream in v3.38
    
    Bug: https://bugs.gentoo.org/762460
    Closes: https://bugs.gentoo.org/549102
    Closes: https://bugs.gentoo.org/585976
    Closes: https://bugs.gentoo.org/613222
    Closes: https://bugs.gentoo.org/660546
    Closes: https://bugs.gentoo.org/692648
    Closes: https://bugs.gentoo.org/733708
    Signed-off-by: Matt Turner <mattst88@gentoo.org>

 gnome-base/gdm/Manifest                            |   1 +
 ...dm-40.0-meson-allow-building-with-elogind.patch | 211 +++++++++++++++++++++
 gnome-base/gdm/gdm-40.0.ebuild                     | 207 ++++++++++++++++++++
 3 files changed, 419 insertions(+)