Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 692520 - app-emacs/emacs-common-gentoo-1.6-r2 : .../temp/environment: line 1434: gnome2_icon_savelist: command not found
Summary: app-emacs/emacs-common-gentoo-1.6-r2 : .../temp/environment: line 1434: gnome...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: GNU Emacs project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 692410
  Show dependency tree
 
Reported: 2019-08-19 12:58 UTC by Stephan Hartmann (RETIRED)
Modified: 2019-08-22 12:50 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Stephan Hartmann (RETIRED) gentoo-dev 2019-08-19 12:58:16 UTC
Portage 2.3.69 (python 3.6.5-final-0, default/linux/arm64/17.0, gcc-8.3.0, glibc-2.29-r2, 4.19.30-gentoo aarch64)
=================================================================
System uname: Linux-4.19.30-gentoo-aarch64-with-gentoo-2.6
KiB Mem:   131981664 total,  88342764 free
KiB Swap:  536870908 total, 536058864 free
Timestamp of repository gentoo: Mon, 19 Aug 2019 03:45:01 +0000
Head commit of repository gentoo: 5f12ee75995848414886424f745d36c7f62f68d0
sh bash 4.4_p23-r1
ld GNU ld (Gentoo 2.32 p2) 2.32.0
app-shells/bash:          4.4_p23-r1::gentoo
dev-java/java-config:     2.2.0-r4::gentoo
dev-lang/perl:            5.28.2-r1::gentoo
dev-lang/python:          2.7.15::gentoo, 3.6.5::gentoo
dev-util/cmake:           3.14.6::gentoo
sys-apps/baselayout:      2.6-r1::gentoo
sys-apps/openrc:          0.41.2::gentoo
sys-apps/sandbox:         2.13::gentoo
sys-devel/autoconf:       2.69-r4::gentoo
sys-devel/automake:       1.16.1-r1::gentoo
sys-devel/binutils:       2.32-r1::gentoo
sys-devel/gcc:            8.3.0-r1::gentoo
sys-devel/gcc-config:     2.0::gentoo
sys-devel/libtool:        2.4.6-r3::gentoo
sys-devel/make:           4.2.1-r4::gentoo
sys-kernel/linux-headers: 4.19::gentoo (virtual/os-headers)
sys-libs/glibc:           2.29-r2::gentoo
Repositories:

gentoo
    location: /usr/portage
    sync-type: rsync
    sync-uri: rsync://rsync.gentoo.org/gentoo-portage
    priority: -1000
    sync-rsync-verify-jobs: 1
    sync-rsync-verify-metamanifest: no
    sync-rsync-verify-max-age: 24
    sync-rsync-extra-opts: 

local
    location: /usr/local/portage
    masters: gentoo
    priority: 0

ACCEPT_KEYWORDS="arm64"
ACCEPT_LICENSE="@FREE"
CBUILD="aarch64-unknown-linux-gnu"
CFLAGS="-O2 -pipe -fomit-frame-pointer"
CHOST="aarch64-unknown-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/sandbox.d /etc/terminfo"
CXXFLAGS="-O2 -pipe -fomit-frame-pointer"
DISTDIR="/var/tmp/distfiles"
ENV_UNSET="DBUS_SESSION_BUS_ADDRESS DISPLAY GOBIN PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR"
FCFLAGS="-O2 -pipe -fomit-frame-pointer"
FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs buildpkg config-protect-if-modified distlocks ebuild-locks fixlafiles ipc-sandbox merge-sync multilib-strict network-sandbox news parallel-fetch preserve-libs protect-owned sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS="-O2 -pipe -fomit-frame-pointer"
GENTOO_MIRRORS="http://mirror.netcologne.de/gentoo/ http://ftp.halifax.rwth-aachen.de/gentoo/"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
LINGUAS="de en"
MAKEOPTS="-j12"
PKGDIR="/var/tmp/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/var/tmp"
USE="acl arm64 berkdb bzip2 cli crypt cxx dri fortran gdbm iconv ipv6 libtirpc ncurses nls nptl openmp pam pcre readline seccomp split-usr ssl tcpd unicode xattr zlib" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="karbon sheets words" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_ARM="edsp neon thumb thumb2 v4 v5 v6 v7 v8 vfp vfp-d32 vfpv3 vfpv4" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="libinput keyboard mouse" KERNEL="linux" L10N="de en" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" NETBEANS_MODULES="apisupport cnd groovy gsf harness ide identity j2ee java mobility nb php profiler soa visualweb webcommon websvccommon xml" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php7-2" POSTGRES_TARGETS="postgres10 postgres11" PYTHON_SINGLE_TARGET="python3_6" PYTHON_TARGETS="python2_7 python3_6" RUBY_TARGETS="ruby24 ruby25" USERLAND="GNU" VIDEO_CARDS="fbdev dummy v4l" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CC, CPPFLAGS, CTARGET, CXX, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LANG, LC_ALL, PORTAGE_BINHOST, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS
Comment 1 Jeroen Roovers (RETIRED) gentoo-dev 2019-08-22 08:26:21 UTC
>>> Creating Manifest for /home/jer/git/gentoo/app-emacs/emacs-common-gentoo
 * emacs-common-gentoo-1.6.tar.xz BLAKE2B SHA512 size ;-) ...                                                                                           [ ok ]
>>> Unpacking source...
>>> Unpacking emacs-common-gentoo-1.6.tar.xz to /home/jer/portage/app-emacs/emacs-common-gentoo-1.6-r2/work
>>> Source unpacked in /home/jer/portage/app-emacs/emacs-common-gentoo-1.6-r2/work
>>> Preparing source in /home/jer/portage/app-emacs/emacs-common-gentoo-1.6-r2/work/emacs-common-gentoo-1.6 ...
>>> Source prepared.
>>> Configuring source in /home/jer/portage/app-emacs/emacs-common-gentoo-1.6-r2/work/emacs-common-gentoo-1.6 ...
>>> Source configured.
>>> Compiling source in /home/jer/portage/app-emacs/emacs-common-gentoo-1.6-r2/work/emacs-common-gentoo-1.6 ...
>>> Source compiled.
>>> Test phase [not enabled]: app-emacs/emacs-common-gentoo-1.6-r2

>>> Install app-emacs/emacs-common-gentoo-1.6-r2 into /home/jer/portage/app-emacs/emacs-common-gentoo-1.6-r2/image
/home/jer/portage/app-emacs/emacs-common-gentoo-1.6-r2/work/emacs-common-gentoo-1.6/icons /home/jer/portage/app-emacs/emacs-common-gentoo-1.6-r2/work/emacs-common-gentoo-1.6
/home/jer/portage/app-emacs/emacs-common-gentoo-1.6-r2/work/emacs-common-gentoo-1.6
/home/jer/portage/app-emacs/emacs-common-gentoo-1.6-r2/temp/environment: line 1434: gnome2_icon_savelist: command not found
>>> Completed installing app-emacs/emacs-common-gentoo-1.6-r2 into /home/jer/portage/app-emacs/emacs-common-gentoo-1.6-r2/image

 * Final size of build directory: 156 KiB
 * Final size of installed tree:  248 KiB

 * QA Notice: command not found:
 *
 *      /home/jer/portage/app-emacs/emacs-common-gentoo-1.6-r2/temp/environment: line 1434: gnome2_icon_savelist: command not found
Comment 2 Stephan Hartmann (RETIRED) gentoo-dev 2019-08-22 11:18:40 UTC
How this one was stabilized without seeing these issues is a miracle.

gnome2_icon_savelist is not defined in EAPI=7. Also it should be in pkg_preinst() and is used in src_install(). Later gnome2_icon_cache_update is called, which is also not defined in EAPI=7. I guess gnome2_icon_savelist together with 'inherit' gnome2-utils can be removed. gnome2_icon_cache_update should be replaced with xdg_icon_cache_update.
Comment 3 Ulrich Müller gentoo-dev 2019-08-22 12:49:47 UTC
(In reply to Stephan Hartmann from comment #2)
> How this one was stabilized without seeing these issues is a miracle.

Yes, maintainer's fault (i.e., mine). Looks like I've missed the change in gnome2-utils when bumping the ebuild to EAPI 7.

> gnome2_icon_savelist is not defined in EAPI=7. Also it should be in
> pkg_preinst() and is used in src_install().

It doesn't really matter in which of these functions it is called, because the function will only affect the environment. In fact, we moved it from preinst to install at some point (and I'm pretty sure that was with an ack from the gnome team):
https://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/app-emacs/emacs-common-gentoo/emacs-common-gentoo-1.0.ebuild?hideattic=0&r1=1.12&r2=1.13
Comment 4 Larry the Git Cow gentoo-dev 2019-08-22 12:50:14 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=66bd2c16de5af5d58a7413ba7cbb89e6b6c2f5aa

commit 66bd2c16de5af5d58a7413ba7cbb89e6b6c2f5aa
Author:     Ulrich Müller <ulm@gentoo.org>
AuthorDate: 2019-08-22 12:34:36 +0000
Commit:     Ulrich Müller <ulm@gentoo.org>
CommitDate: 2019-08-22 12:44:18 +0000

    app-emacs/emacs-common-gentoo: Drop gnome2-utils.
    
    gnome2_icon_savelist() and gnome2_icon_cache_update() are no longer
    defined in EAPI 7. Use xdg_icon_cache_update as replacement.
    
    Closes: https://bugs.gentoo.org/692520
    Reported-by: Stephan Hartmann <stha09@googlemail.com>
    Package-Manager: Portage-2.3.71, Repoman-2.3.17
    Signed-off-by: Ulrich Müller <ulm@gentoo.org>

 ...mon-gentoo-1.6-r2.ebuild => emacs-common-gentoo-1.6-r3.ebuild} | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)