The last version bump unfixed my prefix changes: * ERROR: app-emulation/wine-vanilla-4.14::gentoo failed: * Aborting due to QA concerns: double prefix files installed * * Call stack: * misc-functions.sh, line 586: Called install_qa_check * misc-functions.sh, line 132: Called source 'install_symlink_html_docs' * 05prefix, line 114: Called install_qa_check_prefix * 05prefix, line 19: Called die * The specific snippet of code: * die "Aborting due to QA concerns: double prefix files installed" Please apply the commit below in the overlay and to 4.14 to avoid breaking prefix again. Thank you. https://gitweb.gentoo.org/repo/gentoo.git/commit/app-emulation/wine-vanilla?id=738ec2a42dee7491d1198a20f5ade88df22f8b39
In the future, please do not modify the wine project ebuilds without contacting the wine team. We have a workflow that includes updating the wine overlay and then copying the ebuilds to ::gentoo. That was not followed by your commit, causing the change to be lost in the revbump.
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/proj/wine.git/commit/?id=6bddcf8783c273d9ff4c9ec496d9119a4a2243ef commit 6bddcf8783c273d9ff4c9ec496d9119a4a2243ef Author: Nick Sarnie <sarnex@gentoo.org> AuthorDate: 2019-08-19 22:41:19 +0000 Commit: Nick Sarnie <sarnex@gentoo.org> CommitDate: 2019-08-19 22:41:19 +0000 app-emulation/wine-vanilla: Apply rogue commit to revbump Fixes: https://bugs.gentoo.org/692502 Package-Manager: Portage-2.3.71, Repoman-2.3.17 Signed-off-by: Nick Sarnie <sarnex@gentoo.org> app-emulation/wine-vanilla/wine-vanilla-4.14.ebuild | 7 +++++-- app-emulation/wine-vanilla/wine-vanilla-9999.ebuild | 7 +++++-- 2 files changed, 10 insertions(+), 4 deletions(-) Additionally, it has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/proj/wine.git/commit/?id=c5819f01ddb24b27830cb9a6b56dc4dba6b6e966 commit c5819f01ddb24b27830cb9a6b56dc4dba6b6e966 Author: Nick Sarnie <sarnex@gentoo.org> AuthorDate: 2019-08-19 22:43:11 +0000 Commit: Nick Sarnie <sarnex@gentoo.org> CommitDate: 2019-08-19 22:43:42 +0000 app-emulation/wine-staging: Port change from vanilla Bug: https://bugs.gentoo.org/692502 Package-Manager: Portage-2.3.71, Repoman-2.3.17 Signed-off-by: Nick Sarnie <sarnex@gentoo.org> app-emulation/wine-staging/wine-staging-4.14.ebuild | 7 +++++-- app-emulation/wine-staging/wine-staging-9999.ebuild | 7 +++++-- 2 files changed, 10 insertions(+), 4 deletions(-)
I did contact the wine team. I created a pull request on GitHub: https://github.com/gentoo/gentoo/pull/12592, then asked in IRC for review. Maintainers for other packages reviewed my prefix changes, and I pushed them, but after more than a week I had no answer from wine maintainers, so I just pushed the fixes for wine in the end as well. In any case, it might make sense to sync your overlay both ways, from the main tree into ::wine, then back. That way you can get tree-wide changes or fixes like the one from prefix. Cheers,
Via IRC, I replied with "Perhaps a bug with patches that apply on the project repo ( https://gitweb.gentoo.org/repo/proj/wine.git/ ), or a pull request via https://github.com/gentoo/repo-proj-wine" because I knew sarnex and the others who are better for reviewing this kind of things will notice this kind of things better that way. :] (It might also have helped if the Wine project, or just sarnex for example was mentioned in the pull request.) I understand it can be frustrating when you're not getting the attention of people in a timely fashion, but I imagine often times just pushing without said attention will at the very least create some confusion.
Thanks Chiitoo. Yes, in the future please mention me or the wine team in the PR, and the PR should be on the ::wine repository. I'm not sure how I'm supposed to have found that PR without going through every open PR. IRC messages are easy to go through the cracks.
Fair enough. I don't have the IRC logs, but I did give a link to the PR to both of you, I just wanted an ack before creating the PR against ::wine. I will create a PR directly against ::wine next time. Cheers,
Yeah, I was going to take a better look at it at a better time, and at the very least poke sarnex about it, but I pretty much forgot all about it. :\ Sorry about that!
