Created attachment 587366 [details] build.log When I go to the build directory and run the testsuite it works fine. Portage 2.3.69 (python 3.6.5-final-0, default/linux/sparc/17.0, gcc-8.3.0, glibc-2.29-r2, 5.2.5 sparc64) ================================================================= System uname: Linux-5.2.5-sparc64-sun4v-with-gentoo-2.4.1 KiB Mem: 33129592 total, 5864664 free KiB Swap: 0 total, 0 free Timestamp of repository gentoo: Sun, 18 Aug 2019 00:15:01 +0000 sh bash 4.4_p23-r1 ld GNU ld (Gentoo 2.32 p2) 2.32.0 ccache version 3.7.2 [disabled] app-shells/bash: 4.4_p23-r1::gentoo dev-lang/perl: 5.26.2::gentoo dev-lang/python: 2.7.15::gentoo, 3.6.5::gentoo dev-util/ccache: 3.7.2::gentoo dev-util/cmake: 3.14.6::gentoo sys-apps/baselayout: 2.4.1-r2::gentoo sys-apps/openrc: 0.38.3-r1::gentoo sys-apps/sandbox: 2.13::gentoo sys-devel/autoconf: 2.13-r1::gentoo, 2.69-r4::gentoo sys-devel/automake: 1.11.6-r3::gentoo, 1.13.4-r2::gentoo, 1.16.1-r1::gentoo sys-devel/binutils: 2.32-r1::gentoo sys-devel/gcc: 8.3.0-r1::gentoo sys-devel/gcc-config: 2.0::gentoo sys-devel/libtool: 2.4.6-r3::gentoo sys-devel/make: 4.2.1-r4::gentoo sys-kernel/linux-headers: 4.19::gentoo (virtual/os-headers) sys-libs/glibc: 2.29-r2::gentoo Repositories: gentoo location: /usr/portage sync-type: git sync-uri: https://anongit.gentoo.org/git/repo/sync/gentoo.git priority: -1000 sync-git-verify-commit-signature: yes ACCEPT_KEYWORDS="sparc" ACCEPT_LICENSE="* -@EULA" CBUILD="sparc-unknown-linux-gnu" CFLAGS="-O2 -mcpu=niagara2 -pipe -Wcast-align" CHOST="sparc-unknown-linux-gnu" CONFIG_PROTECT="/etc /usr/share/gnupg/qualified.txt /var/spool/torque" CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/php/apache2-php5.6/ext-active/ /etc/php/apache2-php7.1/ext-active/ /etc/php/apache2-php7.2/ext-active/ /etc/php/apache2-php7.3/ext-active/ /etc/php/cgi-php5.6/ext-active/ /etc/php/cgi-php7.1/ext-active/ /etc/php/cgi-php7.2/ext-active/ /etc/php/cgi-php7.3/ext-active/ /etc/php/cli-php5.6/ext-active/ /etc/php/cli-php7.1/ext-active/ /etc/php/cli-php7.2/ext-active/ /etc/php/cli-php7.3/ext-active/ /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c" CXXFLAGS="-O2 -mcpu=niagara2 -pipe -Wcast-align" DISTDIR="/usr/portage/distfiles" ENV_UNSET="DBUS_SESSION_BUS_ADDRESS DISPLAY GOBIN PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR" FCFLAGS="" FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs config-protect-if-modified distlocks ebuild-locks fixlafiles ipc-sandbox merge-sync network-sandbox news parallel-fetch pid-sandbox preserve-libs protect-owned sandbox sfperms strict strict-keepdir unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr" FFLAGS="" GENTOO_MIRRORS="ftp://ftp.wh2.tu-dresden.de/pub/mirrors/gentoo ftp://ftp.join.uni-muenster.de/pub/linux/distributions/gentoo" LANG="en_US.UTF-8" LDFLAGS="-Wl,-O1 -Wl,--as-needed" MAKEOPTS="-j20 -l40" PKGDIR="/usr/portage/packages" PORTAGE_CONFIGROOT="/" PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git" PORTAGE_TMPDIR="/var/tmp" USE="acl berkdb big-endian bzip2 cli crypt cxx dri fortran gdbm iconv ipv6 libtirpc ncurses nls nptl openmp pam pcre readline sparc split-usr ssl tcpd unicode xattr zlib" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="karbon sheets words" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="libinput keyboard mouse" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" NETBEANS_MODULES="apisupport cnd groovy gsf harness ide identity j2ee java mobility nb php profiler soa visualweb webcommon websvccommon xml" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php7-2" POSTGRES_TARGETS="postgres10 postgres11" PYTHON_SINGLE_TARGET="python3_6" PYTHON_TARGETS="python2_7 python3_6" RUBY_TARGETS="ruby24" USERLAND="GNU" VIDEO_CARDS="fbdev glint mga r128 radeon dummy v4l" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account" Unset: CC, CPPFLAGS, CTARGET, CXX, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LC_ALL, LINGUAS, PORTAGE_BINHOST, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS
does it run fine with -j1?
> [32;01m*[0m Applying gtest-1.9.0_pre20190607-add-mmap-stack-flag.patch ... > [33;01m*[0m Unable to trace static ELF: /usr/bin/patch: patch -p1 -f -s -g0 --no-backup-if-mismatch > [A[256C [34;01m[ [32;01mok[34;01m ][0m It doesn't look like it's applying the patch. I don't think this is a gtest problem.
(In reply to Peter Levine from comment #2) > > [32;01m*[0m Applying gtest-1.9.0_pre20190607-add-mmap-stack-flag.patch ... > > [33;01m*[0m Unable to trace static ELF: /usr/bin/patch: patch -p1 -f -s -g0 --no-backup-if-mismatch > > [A[256C [34;01m[ [32;01mok[34;01m ][0m > > It doesn't look like it's applying the patch. I don't think this is a gtest > problem. Can you reproduce the issue with FEATURES="-sandbox"?
The problem is probably specific to SPARC (and maybe some other architectures)...
(In reply to Arfrever Frehtes Taifersar Arahesis from comment #4) > The problem is probably specific to SPARC (and maybe some other > architectures)... The patch being applied, at the point at which the elf message is being emitted, conditionally passes MAP_GROWSDOWN to mmap if the stack grows downwards in memory. AFAIK, on sparc64 it does. The concern is whether the patch is actually being applied when the message 'Unable to trace static ELF: /usr/bin/patch' is being emitted. If not, it is an error with sandbox and/or sys-devel/patch that is unrelated to gtest. Otherwise, it is a problem with gtest and sandbox that can likely be solved by reverting the patch to its former behavior (passing a larger stack to clone()). I suppose rebuilding with FEATURES=-sandbox isn't really a solution since the problem the patch, itself, is supposed to fix is this very error. Perhaps one can test by ebuilding the 'prepare' stage, changing directory to ${S}, manually trying to patch, and then resuming to ebuild the 'test' stage and confirming it passes. If one can manually patch without issue and the 'test' stage passes, the problem is with sys-devel/patch and or gtest. Otherwise, I should likely revert the patch. Not sure if a testcase failure is enough reason to block stabilization.
"Unable to trace static ELF" is a harmless message generated by sandbox when any static executable is called. These executables still do their job, just without sandbox protection. (In this case, you can test sys-devel/patch with USE="static"...)
(In reply to Arfrever Frehtes Taifersar Arahesis from comment #6) > "Unable to trace static ELF" is a harmless message generated by sandbox when > any static executable is called. These executables still do their job, just > without sandbox protection. > (In this case, you can test sys-devel/patch with USE="static"...) I see. Does the test failure itself inhibit stabilization? It's really a corner-case of sandbox (AFAIK usersandbox) with a constrained stack in a call to clone(). Or should I push a PR with an alternate patch and resubmit a stabilization request?
dev-cpp/gtest-1.9.0_pre20190607 has already been stabilized on sparc. If I understand correctly, the previous approach ('stack_size = getpagesize() * 10') has been working on sparc. I do not know if there is something special in implementation of stacks on sparc, or in implementation of mmap() on sparc...
Created attachment 587386 [details, diff] Patch Rolf Eike Beer: Please test if this patch happens to help...
(In reply to Arfrever Frehtes Taifersar Arahesis from comment #8) > dev-cpp/gtest-1.9.0_pre20190607 has already been stabilized on sparc. > > If I understand correctly, the previous approach ('stack_size = > getpagesize() * 10') has been working on sparc. > I do not know if there is something special in implementation of stacks on > sparc, or in implementation of mmap() on sparc... The patch was changed to a more simple approach, to have the mmaped memory auto-resize by passing the MAP_GROWSDOWN flag to mmap() on Linux platforms in which the stack grows downward in memory, instead of requesting a larger fixed-size mmaped region. It appears that that approach was a bad idea. I incorrectly assumed that the stack overflow bug was only an issue on such platforms.
Works with the patch.
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=aa4cea02ac7bb486979ce96d29b0dc6c76491184 commit aa4cea02ac7bb486979ce96d29b0dc6c76491184 Author: Peter Levine <plevine457@gmail.com> AuthorDate: 2019-08-20 05:56:41 +0000 Commit: Joonas Niilola <juippis@gentoo.org> CommitDate: 2019-08-21 05:06:55 +0000 dev-cpp/gtest: Fix test failure on sparc64 sparc64 exhibits the same usersandbox stack overflow bug and its stack can apparently grow upwards in memory. Revert back to allocating 10 pages of mapped memory for the offending call to clone(). Bug: https://bugs.gentoo.org/692464 Reported-by: Rolf Eike Beer <gentoo-bug@opensource.sf-tec.de> Package-Manager: Portage-2.3.71, Repoman-2.3.17 Signed-off-by: Peter Levine <plevine457@gmail.com> Signed-off-by: Joonas Niilola <juippis@gentoo.org> .../gtest-1.9.0_pre20190607-add-mmap-stack-flag.patch | 15 --------------- ...test-1.9.0_pre20190607-increase-clone-stack-size.patch | 13 +++++++++++++ dev-cpp/gtest/gtest-1.9.0_pre20190607.ebuild | 2 +- dev-cpp/gtest/gtest-9999.ebuild | 2 +- 4 files changed, 15 insertions(+), 17 deletions(-)
