Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 692326 - media-gfx/digikam-6.2.0 fails to build against ImageMagick-7.0.8.60
Summary: media-gfx/digikam-6.2.0 fails to build against ImageMagick-7.0.8.60
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Andreas K. Hüttel
URL:
Whiteboard:
Keywords: PATCH, PullRequest
: 693082 (view as bug list)
Depends on:
Blocks:
 
Reported: 2019-08-17 06:04 UTC by David Haller
Modified: 2019-08-29 19:19 UTC (History)
13 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch for the trivial rename module to magick_module (digikam-6.2.0-ImageMagick-7.0.8.60.patch,652 bytes, patch)
2019-08-17 06:04 UTC, David Haller
Details | Diff
Enhanced patch for the trivial rename module to magick_module (digikam-6.2.0-ImageMagick-7.0.8.60.patch,818 bytes, patch)
2019-08-19 01:27 UTC, David Haller
Details | Diff
Enhanced patch for the trivial rename module to magick_module (supersede) (digikam-6.2.0-ImageMagick-7.0.8.60.patch,751 bytes, patch)
2019-08-19 01:30 UTC, David Haller
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Haller 2019-08-17 06:04:23 UTC
Created attachment 587086 [details, diff]
Patch for the trivial rename module to magick_module

Due to conflicts with the C++20 keyword, IM renamed the "module" member of "MagickInfo" (aka "struct _MagickInfo" to "magick_module", thus stuff needs to be adjusted...
Comment 1 John Bowler 2019-08-17 22:37:55 UTC
The patch works and digikam builds, however to use it in /etc/portage/patches it is necessary to change the file name lines to work with patch -p1:

--- a/core/tests/dimg/magickloader.cpp
+++ b/core/tests/dimg/magickloader.cpp
Comment 2 Ole Langbehn 2019-08-18 11:08:59 UTC
I created a pull request on github with the corrected patch:

https://github.com/gentoo/gentoo/pull/12740
Comment 3 Andreas Sturmlechner gentoo-dev 2019-08-18 11:09:48 UTC
Is that patch upstream?
Comment 4 David Haller 2019-08-19 01:27:34 UTC
Created attachment 587382 [details, diff]
Enhanced patch for the trivial rename module to magick_module

I've changed the patch to work with stable IM-7.0.8.56 as well...

And no, it's not upstreamed (and not fixed in git either).
Comment 5 David Haller 2019-08-19 01:30:21 UTC
Created attachment 587384 [details, diff]
Enhanced patch for the trivial rename module to magick_module (supersede)

*argh* left some testing stuff in .. ;( Time for bed ...
Comment 6 Larry the Git Cow gentoo-dev 2019-08-22 14:16:30 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=95c14433ba569fcc4dba0279e7a1e71b8eff676c

commit 95c14433ba569fcc4dba0279e7a1e71b8eff676c
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2019-08-22 12:46:04 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2019-08-22 14:15:37 +0000

    media-gfx/digikam: Fix build with ImageMagick-7.0.8.60
    
    Thanks-to: David Haller <gentoo@dhaller.de>
    Closes: https://bugs.gentoo.org/692326
    Package-Manager: Portage-2.3.72, Repoman-2.3.17
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 media-gfx/digikam/digikam-6.2.0.ebuild                     |  1 +
 .../digikam/files/digikam-6.2.0-imagemagick-7.0.8.60.patch | 14 ++++++++++++++
 2 files changed, 15 insertions(+)
Comment 7 Brian Evans (RETIRED) gentoo-dev 2019-08-29 17:50:27 UTC
*** Bug 693082 has been marked as a duplicate of this bug. ***