Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 692214 - mail-client/trojita-9999 - Add USE=abook
Summary: mail-client/trojita-9999 - Add USE=abook
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Jan Kundrát
URL:
Whiteboard:
Keywords: EBUILD
Depends on:
Blocks:
 
Reported: 2019-08-15 11:55 UTC by Raphaël Barrois
Modified: 2019-09-08 16:29 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Add IUSE=abook to trojita-9999.ebuild (trojita-9999.ebuild.patch,687 bytes, patch)
2019-08-15 11:55 UTC, Raphaël Barrois
Details | Diff
Updated metadata.xml with description of USE=abook (metadata.xml.patch,505 bytes, patch)
2019-08-15 11:57 UTC, Raphaël Barrois
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Raphaël Barrois 2019-08-15 11:55:21 UTC
Created attachment 586818 [details, diff]
Add IUSE=abook to trojita-9999.ebuild

A recent version of trojita has added support for akonadi-based address book, in addition to the initial abook plugin.

The 'addressbook' USE flag has been added to select the akonadi address book; however, there is no option to opt for the abook-based address book - which is useful when running trojita outside a full-blown KDE environment, and was the only available option in past versions.

The attached patch proposes the addition of an 'abook' USE that enables the abook-based addressbook plugin; I can confirm that the resulting program works as intended.

As far as I can see, the project code allows having both plugins compiled.
Comment 1 Raphaël Barrois 2019-08-15 11:57:42 UTC
Created attachment 586820 [details, diff]
Updated metadata.xml with description of USE=abook
Comment 2 Raphaël Barrois 2019-08-15 11:59:49 UTC
Note: USE=abook already exists, with an identical meaning, in net-mail/lbdb:

 * Found these USE flags for net-mail/lbdb-0.41:
     abook  : Enables app-misc/abook support
Comment 3 Jan Kundrát 2019-08-26 14:44:02 UTC
The abook plugin should have been always enabled; it's a mistake that it got disabled starting this May. I've open a pull request with a fix, https://github.com/gentoo/gentoo/pull/12794 .
Comment 4 Larry the Git Cow gentoo-dev 2019-09-08 16:29:42 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c6c53388179e5e54a951db2f2a983684ded2c608

commit c6c53388179e5e54a951db2f2a983684ded2c608
Author:     Jan Kundrát <jkt@kde.org>
AuthorDate: 2019-08-26 14:32:40 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2019-09-08 16:23:03 +0000

    mail-client/trojita: Unconditionally enable the abook plugin
    
    Trojita supports different implementations of an "address book" via
    plugins that are loaded at runtime. Only one plugin can be active at a
    time, but any number of them can be built and installed. The user can
    pick and select an appropriate plugin via a GUI configuration.
    
    There is no need to disable the "abook" plugin, and upstream expects
    this plugin to be always available. There are no external dependencies,
    and the `abook` binary is not used.
    
    Fixes: e0e382d4f9341 (mail-client/trojita: Add USE addressbook)
    Closes: https://bugs.gentoo.org/692214
    Signed-off-by: Jan Kundrát <jkt@kde.org>
    Closes: https://github.com/gentoo/gentoo/pull/12794
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 mail-client/trojita/trojita-9999.ebuild | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)