Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 692074 - net-libs/nodejs: wrong python eclass?
Summary: net-libs/nodejs: wrong python eclass?
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Jeroen Roovers (RETIRED)
URL:
Whiteboard:
Keywords: NeedPatch, PullRequest
Depends on:
Blocks:
 
Reported: 2019-08-13 13:53 UTC by Michał Górny
Modified: 2019-10-07 09:11 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2019-08-13 13:53:26 UTC
The package uses python-single-r1.  However, it neither lists Python in RDEPEND nor appears to install anything using it.  Did you mean to use python-any-r1?
Comment 1 Jeroen Roovers (RETIRED) gentoo-dev 2019-08-14 04:32:53 UTC
(In reply to Michał Górny from comment #0)
> The package uses python-single-r1.  However, it neither lists Python in
> RDEPEND nor appears to install anything using it.  Did you mean to use
> python-any-r1?

Who do you think is "you"? So many people worked on the nodejs ebuilds, including you! Indeed, it looks like nodejs-0.12.2-r1.ebuild used python-any-r1 and nodejs-0.12.2-r2.ebuild first used python-single-r1, more than four years ago. You actually committed an unrelated change to nodejs-0.12.2-r2.ebuild at the time. (I started maintaining this package around three years ago.)

Perhaps you should rather spend your time explaining why using python-single-r1 is wrong in this case and why python-any-r1 is right. Or just propose a patch.
Comment 2 Larry the Git Cow gentoo-dev 2019-08-14 05:47:56 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=37ec456ffe51429e00c9dccfedd8686543046568

commit 37ec456ffe51429e00c9dccfedd8686543046568
Author:     Jeroen Roovers <jer@gentoo.org>
AuthorDate: 2019-08-14 05:45:20 +0000
Commit:     Jeroen Roovers <jer@gentoo.org>
CommitDate: 2019-08-14 05:47:53 +0000

    net-libs/nodejs: Inherit python-any-r1 instead of python-single-r1
    
    Package-Manager: Portage-2.3.71, Repoman-2.3.17
    Bug: https://bugs.gentoo.org/692074
    Signed-off-by: Jeroen Roovers <jer@gentoo.org>

 net-libs/nodejs/nodejs-0.12.18.ebuild  | 5 ++---
 net-libs/nodejs/nodejs-10.15.3.ebuild  | 3 +--
 net-libs/nodejs/nodejs-10.16.0.ebuild  | 3 +--
 net-libs/nodejs/nodejs-10.16.2.ebuild  | 3 +--
 net-libs/nodejs/nodejs-11.14.0.ebuild  | 3 +--
 net-libs/nodejs/nodejs-11.15.0.ebuild  | 3 +--
 net-libs/nodejs/nodejs-12.7.0.ebuild   | 3 +--
 net-libs/nodejs/nodejs-12.8.0.ebuild   | 3 +--
 net-libs/nodejs/nodejs-4.9.1.ebuild    | 5 ++---
 net-libs/nodejs/nodejs-6.14.4.ebuild   | 5 ++---
 net-libs/nodejs/nodejs-6.17.1.ebuild   | 3 +--
 net-libs/nodejs/nodejs-8.12.0.ebuild   | 5 ++---
 net-libs/nodejs/nodejs-8.16.0.ebuild   | 3 +--
 net-libs/nodejs/nodejs-99999999.ebuild | 3 +--
 14 files changed, 18 insertions(+), 32 deletions(-)
Comment 3 Mike Gilbert gentoo-dev 2019-08-14 08:53:18 UTC
It looks like python is only used in the build system?

For the ebuilds using EAPI 7, PYTHON_DEPS should probably be moved from DEPEND to BDEPEND.
Comment 4 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2019-08-31 11:55:42 UTC
Please also fix the two old versions or remove them.
Comment 5 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2019-09-08 06:40:35 UTC
Now 0.12.18 is using python-any-r1 but specifying PYTHON_DEPS in RDEPEND, so there's a clash the other way around.

4.9.1 specifies PYTHON_DEPS in RDEPEND conditionally to USE=npm.

Are the dependencies wrong, or did your mass update miss them?
Comment 6 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2019-09-19 09:22:49 UTC
Ping.
Comment 7 Larry the Git Cow gentoo-dev 2019-10-07 09:11:08 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8783d4433a571b08453e95a55f16cdffac827ae5

commit 8783d4433a571b08453e95a55f16cdffac827ae5
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: 2019-09-27 17:17:19 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2019-10-07 09:11:00 +0000

    net-libs/nodejs: [QA] Drop old, broken ebuilds
    
    Closes: https://bugs.gentoo.org/692074
    Closes: https://github.com/gentoo/gentoo/pull/13062
    Signed-off-by: Michał Górny <mgorny@gentoo.org>

 net-libs/nodejs/Manifest              |   2 -
 net-libs/nodejs/nodejs-0.12.18.ebuild | 123 -----------------------------
 net-libs/nodejs/nodejs-4.9.1.ebuild   | 142 ----------------------------------
 3 files changed, 267 deletions(-)