Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 691796 - net-libs/neon-0.30.2[-gnutls,libressl,pkcs11,ssl] fails to build with dev-libs/libressl-3.0.0
Summary: net-libs/neon-0.30.2[-gnutls,libressl,pkcs11,ssl] fails to build with dev-lib...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: Normal normal (vote)
Assignee: Arfrever Frehtes Taifersar Arahesis
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-08-09 02:32 UTC by Arfrever Frehtes Taifersar Arahesis
Modified: 2019-09-29 02:56 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
neonbuild.log (neonbuild.log,19.41 KB, text/plain)
2019-08-16 19:50 UTC, Aaron Bauman (RETIRED)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Arfrever Frehtes Taifersar Arahesis 2019-08-09 02:32:58 UTC
https://ftp.openbsd.org/pub/OpenBSD/LibreSSL/libressl-3.0.0-relnotes.txt:

  * Completed the port of RSA_METHOD accessors from the OpenSSL 1.1 API.



net-libs/neon-0.30.2 ebuild:

	# Support LibreSSL.
	# Functions RSA_meth_get0_app_data() and RSA_meth_set0_app_data() are not implemented in LibreSSL 2.9.1.
	sed -e "1202s/#if OPENSSL_VERSION_NUMBER < 0x10100000L/& || defined(LIBRESSL_VERSION_NUMBER)/" -i src/ne_openssl.c || die "sed failed"
	sed -e "97a #if defined(LIBRESSL_VERSION_NUMBER)\nstatic void *RSA_meth_get0_app_data(const RSA_METHOD *meth)\n{\n    return meth->app_data;\n}\nstatic int RSA_meth_set0_app_data(RSA_METHOD *meth, void *app_data)\n{\n    meth->app_data = app_data;\n    return 1;\n}\n#endif" -i src/ne_pkcs11.c || die "sed failed"



RSA_meth_get0_app_data() and RSA_meth_set0_app_data() are now available in LibreSSL 3.0.0.
Probably Neon would fail to build with LibreSSL 3.0.0.
Above code probably should be made conditional on LibreSSL version (and later deleted when older LibreSSL versions are deleted).
Comment 1 Aaron Bauman (RETIRED) gentoo-dev 2019-08-16 19:50:06 UTC
Created attachment 587068 [details]
neonbuild.log

+pkcs11
Comment 2 Larry the Git Cow gentoo-dev 2019-09-29 02:56:30 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=bb1d232a1eeb428724c2c8e24335ecc17c4a69b7

commit bb1d232a1eeb428724c2c8e24335ecc17c4a69b7
Author:     Arfrever Frehtes Taifersar Arahesis <Arfrever@Apache.Org>
AuthorDate: 2019-09-28 02:29:13 +0000
Commit:     Mike Gilbert <floppym@gentoo.org>
CommitDate: 2019-09-29 02:56:13 +0000

    net-libs/neon: Fix building with dev-libs/libressl-3.0.0.
    
    Fixes: https://bugs.gentoo.org/691796
    Signed-off-by: Arfrever Frehtes Taifersar Arahesis <Arfrever@Apache.Org>
    Signed-off-by: Mike Gilbert <floppym@gentoo.org>

 net-libs/neon/neon-0.30.2.ebuild | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)