Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 691724 - app-i18n/librime bundles headers from dev-libs/darts, dev-libs/utfcpp, x11-base/xorg-proto
Summary: app-i18n/librime bundles headers from dev-libs/darts, dev-libs/utfcpp, x11-ba...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: Normal normal (vote)
Assignee: CJK Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-08-07 23:22 UTC by Arfrever Frehtes Taifersar Arahesis
Modified: 2019-08-09 18:39 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Arfrever Frehtes Taifersar Arahesis 2019-08-07 23:22:24 UTC
thirdparty/include directory contains bundled headers from other packages:

・ x11-base/xorg-proto
     X11/keysym.h
     X11/keysymdef.h

・ dev-libs/darts
     darts.h

・ dev-libs/utfcpp
     utf8.h
     utf8/checked.h
     utf8/core.h
     utf8/unchecked.h

The bundled headers are at least about 8 years old.
These 3 packages are very small, so depending on them should not be a problem.
Comment 1 Arfrever Frehtes Taifersar Arahesis 2019-08-08 01:36:47 UTC
Although ebuilds have dependency on one of these 3 packages (x11-base/xorg-proto), as of now system headers are not used due to this line in CMakeLists.txt:

include_directories(${PROJECT_SOURCE_DIR}/thirdparty/include)
Comment 2 Larry the Git Cow gentoo-dev 2019-08-09 18:39:14 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=19f971b93a9ca2efdf137981449a1958c84c9d40

commit 19f971b93a9ca2efdf137981449a1958c84c9d40
Author:     Arfrever Frehtes Taifersar Arahesis <Arfrever@Apache.Org>
AuthorDate: 2019-08-09 17:02:55 +0000
Commit:     Mike Gilbert <floppym@gentoo.org>
CommitDate: 2019-08-09 18:38:59 +0000

    app-i18n/librime: Use headers of dev-libs/darts, dev-libs/utfcpp and x11-base/xorg-proto.
    
    Fixes: https://bugs.gentoo.org/691724
    Signed-off-by: Arfrever Frehtes Taifersar Arahesis <Arfrever@Apache.Org>
    Signed-off-by: Mike Gilbert <floppym@gentoo.org>

 app-i18n/librime/librime-1.5.3.ebuild | 12 ++++++++++++
 1 file changed, 12 insertions(+)