Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 691562 - net-print/cnijfilter2-5.70 version bump
Summary: net-print/cnijfilter2-5.70 version bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: Normal normal
Assignee: Tupone Alfredo
URL:
Whiteboard:
Keywords: EBUILD, PATCH
Depends on:
Blocks:
 
Reported: 2019-08-06 11:07 UTC by Dag Bakke
Modified: 2019-08-27 06:42 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
cnijfilter2-5.70 (cnijfilter2-5.70.ebuild,1.49 KB, text/plain)
2019-08-06 11:07 UTC, Dag Bakke
Details
cnijfilter2-5.70-gentoo.patch (cnijfilter2-5.70-gentoo.patch,1.77 KB, patch)
2019-08-06 11:09 UTC, Dag Bakke
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dag Bakke 2019-08-06 11:07:49 UTC
Created attachment 585846 [details]
cnijfilter2-5.70

Not really sure if this package matters a lot, seeing how driverless works well. But here it is.

Changes:
* New URL for the new version (5.70)
* Some of the drivers in this package requires cmdtocanonij3, so added that to the dirs.
* Added a modified patch so cmdtocanonij3 ends up in the right place.

I notice that this should have been contributed as a git-formatted patch, with copyright assignment and yadayada. The changes are trivial and unlikely copyrightable. Will do better for the next contribution. For now, I put this here as is.
Comment 1 Dag Bakke 2019-08-06 11:09:51 UTC
Created attachment 585848 [details, diff]
cnijfilter2-5.70-gentoo.patch

patch to put cmdtocanonij3 in the right place
Comment 2 Jonas Stein gentoo-dev 2019-08-10 21:39:29 UTC
Thank you for your contribution. I had a short look on the ebuild. 
Here a few ideas:

* Please test the ebuild with repoman full -d -x https://wiki.gentoo.org/wiki/Repoman
* We always try to use the latest EAPI, please bump to EAPI=7
* KEYWORDS need ~ after a version bump run ekeyword ~all YOUREBUILD
* please fix the header. (see /usr/portage/skel.ebuild and https://devmanual.gentoo.org/ebuild-writing/eapi/)
* A bot can look for additional mistakes, if you upload a PR via github
Comment 3 Larry the Git Cow gentoo-dev 2019-08-27 06:42:54 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5bcb0af746f30ce9bda642d0e4ef153328986206

commit 5bcb0af746f30ce9bda642d0e4ef153328986206
Author:     Tupone Alfredo <tupone@gentoo.org>
AuthorDate: 2019-08-27 06:42:29 +0000
Commit:     Tupone Alfredo <tupone@gentoo.org>
CommitDate: 2019-08-27 06:42:29 +0000

    net-print/cnijfilter2: version bump to 5.70 from Dag Bakke
    
    Closes: https://bugs.gentoo.org/691562
    Closes: https://bugs.gentoo.org/691250
    Package-Manager: Portage-2.3.66, Repoman-2.3.16
    Signed-off-by: Alfredo Tupone <tupone@gentoo.org>

 net-print/cnijfilter2/Manifest                     |  1 +
 net-print/cnijfilter2/cnijfilter2-5.70.ebuild      | 64 ++++++++++++++++++++++
 .../files/cnijfilter2-5.70-gentoo.patch            | 58 ++++++++++++++++++++
 3 files changed, 123 insertions(+)