Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 691412 - sys-kernel/genkernel-4.0.0_beta10: Allow for "+ char in filename
Summary: sys-kernel/genkernel-4.0.0_beta10: Allow for "+ char in filename
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Hosted Projects
Classification: Unclassified
Component: genkernel (show other bugs)
Hardware: All Linux
: Normal major (vote)
Assignee: Gentoo Genkernel Maintainers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-08-04 09:55 UTC by Mariusz Ceier
Modified: 2019-08-07 16:51 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mariusz Ceier 2019-08-04 09:55:20 UTC
Running genkernel with `genkernel --makeopts=-j2 --kernel-config=/usr/src/linux/q-dev.config --firmware --lvm --busybox all` results in:


* Gentoo Linux Genkernel; Version 4.0.0_beta10
* Using genkernel configuration from '/etc/genkernel.conf' ...
* Running with options: --makeopts=-j2 --menuconfig --firmware --lvm --busybox all
* ERROR: GK_FILENAME_INITRAMFS value 'initramfs-5.3.0-rc2-q-dev+.img' does not match regex '^[a-zA-Z0-9_.-]{1,}$'. Check --initramfs-filename option!
* Please consult '/var/log/genkernel.log' for more information and any
* errors that were reported above.
* 
* Report any genkernel bugs to bugs.gentoo.org and
* assign your bug to genkernel@gentoo.org. Please include
* as much information as you can in your bug report; attaching
* '/var/log/genkernel.log' so that your issue can be dealt with effectively.
* 
* Please do *not* report kernel compilation failures as genkernel bugs!


It also fails with --menuconfig instead of --kernel-config with the same error.


Reproducible: Always

Steps to Reproduce:
1. cd /usr/src && git clone git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git && cd linux && git rm Documentation/rbtree.txt && git commit -m "whatever"
2. genkernel --makeopts=-j2 --menuconfig --firmware --lvm --busybox all
3.
Actual Results:  
genkernel prints error and exits

Expected Results:  
genkernel should build the kernel

genkernel log:

>>> Started genkernel v4.0.0_beta10 on: 2019-08-04 11:43:39
* CMD_MAKEOPTS: -j2
* CMD_MENUCONFIG: yes
* CMD_FIRMWARE: yes
* CMD_LVM: yes
* CMD_BUSYBOX: yes
* Gentoo Linux Genkernel; Version 4.0.0_beta10[0m
* Using genkernel configuration from '/etc/genkernel.conf' ...
* Running with options: --makeopts=-j2 --menuconfig --firmware --lvm --busybox all
* Resolving config file, command line, and arch default settings.
*   TMPDIR defaulted to "/var/tmp/genkernel".
*   LOGFILE set in config file to "/var/log/genkernel.log".
*   KERNEL_DIR defaulted to "/usr/src/linux".
*   KERNEL_SOURCES defaulted to "yes".
*   INITRAMFS_FILENAME defaulted to "initramfs-%%KV%%.img".
*   INITRAMFS_SYMLINK_NAME defaulted to "initramfs".
*   KERNEL_FILENAME defaulted to "vmlinuz-%%KV%%".
*   KERNEL_SYMLINK_NAME defaulted to "kernel".
*   SYSTEMMAP_FILENAME defaulted to "System.map-%%KV%%".
*   SYSTEMMAP_SYMLINK_NAME defaulted to "System.map".
*   CHECK_FREE_DISK_SPACE_BOOTDIR not set.
*   CHECK_FREE_DISK_SPACE_KERNELOUTPUTDIR not set.
*   COMPRESS_INITRD defaulted to "yes".
*   COMPRESS_INITRD_TYPE defaulted to "best".
*   MAKEOPTS set on command line to "-j2".
*   NICE defaulted to "10".
*   KERNEL_MAKE defaulted to "make".
*   UTILS_CFLAGS defaulted to "-Os -pipe -fomit-frame-pointer".
*   UTILS_MAKE defaulted to "make".
*   KERNEL_CC defaulted to "gcc".
*   KERNEL_LD defaulted to "ld".
*   KERNEL_AS defaulted to "as".
*   UTILS_CC defaulted to "gcc".
*   UTILS_LD defaulted to "ld".
*   UTILS_AS defaulted to "as".
*   CROSS_COMPILE not set.
*   BOOTDIR defaulted to "/boot".
*   KERNEL_OUTPUTDIR defaulted to "/usr/src/linux".
*   KERNEL_APPEND_LOCALVERSION not set.
*   KERNEL_LOCALVERSION defaulted to "-%%ARCH%%".
*   MODPROBEDIR defaulted to "/etc/modprobe.d".
*   SPLASH defaulted to "no".
*   CLEAR_CACHEDIR defaulted to "no".
*   POSTCLEAR defaulted to "no".
*   MRPROPER defaulted to "yes".
*   MENUCONFIG set on command line to "yes".
*   GCONFIG defaulted to "no".
*   NCONFIG defaulted to "no".
*   XCONFIG defaulted to "no".
*   CLEAN defaulted to "yes".
*   MINKERNPACKAGE not set.
*   MODULESPACKAGE not set.
*   MODULEREBUILD defaulted to "yes".
*   KERNCACHE not set.
*   RAMDISKMODULES defaulted to "yes".
*   ALLRAMDISKMODULES defaulted to "no".
*   INITRAMFS_OVERLAY not set.
*   MOUNTBOOT defaulted to "yes".
*   BUILD_STATIC defaulted to "no".
*   SAVE_CONFIG defaulted to "yes".
*   SYMLINK defaulted to "no".
*   INSTALL_MOD_PATH not set.
*   OLDCONFIG defaulted to "yes".
*   SANDBOX defaulted to "yes".
*   SSH defaulted to "no".
*   SSH_AUTHORIZED_KEYS_FILE defaulted to "/etc/dropbear/authorized_keys".
*   SSH_HOST_KEYS defaulted to "create".
*   STRACE defaulted to "no".
*   BCACHE defaulted to "no".
*   LVM set on command line to "yes".
*   DMRAID defaulted to "no".
*   ISCSI defaulted to "no".
*   HYPERV defaulted to "no".
*   BOOTLOADER defaulted to "no".
*   BUSYBOX set on command line to "yes".
*   BUSYBOX_CONFIG not set.
*   NFS defaulted to "yes".
*   MICROCODE defaulted to "all".
*   MICROCODE_INITRAMFS defaulted to "yes".
*   UNIONFS defaulted to "no".
*   NETBOOT defaulted to "no".
*   REAL_ROOT not set.
*   DISKLABEL defaulted to "yes".
*   LUKS defaulted to "no".
*   GPG defaulted to "no".
*   MDADM defaulted to "no".
*   MDADM_CONFIG not set.
*   E2FSPROGS defaulted to "no".
*   XFSPROGS defaulted to "no".
*   ZFS defaulted to "no".
*   BTRFS defaulted to "no".
*   VIRTIO defaulted to "no".
*   MULTIPATH defaulted to "no".
*   FIRMWARE set on command line to "yes".
*   FIRMWARE_DIR defaulted to "/lib/firmware".
*   FIRMWARE_FILES not set.
*   FIRMWARE_INSTALL defaulted to "no".
*   INTEGRATED_INITRAMFS defaulted to "no".
*   WRAP_INITRD defaulted to "no".
*   GENZIMAGE defaulted to "no".
*   KEYMAP defaulted to "yes".
*   DOKEYMAPAUTO defaulted to "no".
*   BUSYBOX_CONFIG not set.
*   STRIP_TYPE defaulted to "modules".
*   INSTALL defaulted to "yes".
*   CLEANUP defaulted to "yes".

* Read 'x86_64' from 'uname -m' ...
* ARCH 'x86_64' detected ...
* CBUILD set to 'x86_64-pc-linux-gnu' ...
* CHOST set to 'x86_64-pc-linux-gnu' ...

* Sourcing default modules_load from '/usr/share/genkernel/defaults/modules_load' ...
* Sourcing arch-specific config.sh from '/usr/share/genkernel/arch/x86_64/config.sh' ...
* Sourcing arch-specific modules_load from '/usr/share/genkernel/arch/x86_64/modules_load' ...
* Using '/usr/src/linux/include/config/kernel.release' to extract LOCALVERSION ...
* KERNEL_ARCH set to 'x86' ...

* GK_FILENAME_KERNEL set to 'vmlinuz-5.3.0-rc2-q-dev+' (was: 'vmlinuz-%%KV%%')
* GK_FILENAME_KERNEL_SYMLINK set to 'kernel' (was: 'kernel')
* GK_FILENAME_SYSTEMMAP set to 'System.map-5.3.0-rc2-q-dev+' (was: 'System.map-%%KV%%')
* GK_FILENAME_SYSTEMMAP_SYMLINK set to 'System.map' (was: 'System.map')
* GK_FILENAME_INITRAMFS set to 'initramfs-5.3.0-rc2-q-dev+.img' (was: 'initramfs-%%KV%%.img')
* GK_FILENAME_INITRAMFS_SYMLINK set to 'initramfs' (was: 'initramfs')

* ERROR: GK_FILENAME_INITRAMFS value 'initramfs-5.3.0-rc2-q-dev+.img' does not match regex '^[a-zA-Z0-9_.-]{1,}$'. Check --initramfs-filename option!
* Please consult '/var/log/genkernel.log' for more information and any
* errors that were reported above.
* 
* Report any genkernel bugs to bugs.gentoo.org and
* assign your bug to genkernel@gentoo.org. Please include
* as much information as you can in your bug report; attaching
* '/var/log/genkernel.log' so that your issue can be dealt with effectively.
* 
* Please do *not* report kernel compilation failures as genkernel bugs!
* 
>>> Ended on: 2019-08-04 11:43:39 (after 0 days 0 hours 00 minutes 00 seconds)
Comment 1 Mariusz Ceier 2019-08-04 10:12:33 UTC
I also tried genkernel-9999 commit c47369316bd38b737fc2806723049211db2461e1 and it has the same issue.
Comment 2 Thomas Deutschmann (RETIRED) gentoo-dev 2019-08-04 10:54:57 UTC
Message is pretty clear: At the moment we don't allow "+" char. I'll have a look if we should accept "+" char.
Comment 3 Mariusz Ceier 2019-08-04 11:21:45 UTC
(In reply to Thomas Deutschmann from comment #2)
> Message is pretty clear: At the moment we don't allow "+" char. I'll have a
> look if we should accept "+" char.

Well, I was successfully using name with '+' (not appended by me) until today. I have no problem with booting from network nor disk with such name.
Comment 4 Larry the Git Cow gentoo-dev 2019-08-04 11:36:34 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/genkernel.git/commit/?id=117519303e1a91b2e115993b28a886def4771092

commit 117519303e1a91b2e115993b28a886def4771092
Author:     Thomas Deutschmann <whissi@gentoo.org>
AuthorDate: 2019-08-04 11:20:10 +0000
Commit:     Thomas Deutschmann <whissi@gentoo.org>
CommitDate: 2019-08-04 11:35:58 +0000

    gen_determineargs.sh: determine_output_filenames(): Allow "+" char in filename
    
    Allowed in LOCALVERSION and automatically set by kernel's setlocalversion
    script when SCM sources are modified.
    
    Bug: https://bugs.gentoo.org/691412
    Signed-off-by: Thomas Deutschmann <whissi@gentoo.org>

 gen_determineargs.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 5 Thomas Deutschmann (RETIRED) gentoo-dev 2019-08-04 11:37:53 UTC
Thank you for the report, will be in next beta.
Comment 6 Thomas Deutschmann (RETIRED) gentoo-dev 2019-08-07 16:51:31 UTC
Fix is in >=sys-kernel/genkernel-4.0.0_beta11, thank you for the report!