Hmm, I seem to have missed that Python is kinda messy here: https://qa-reports.gentoo.org/output/gentoo-ci/output.html#sci-libs/cantera Could you look into adding PYTHON_DEPS? I think they should go into DEPEND (for scons) + into some USE-conditional in RDEPEND (cti? python?). Also cti? () in REQUIRED_USE seems redundant.
> Could you look into adding PYTHON_DEPS? > I think they should go into DEPEND (for scons) Do you mean that there an explicit `DEPEND="... dev-utils/scons ( ${PYTHON_DEPS} ) ..."` is required despite the `inherit = ... scons-utils ...` ? > + into some USE-conditional in RDEPEND (cti? python?). I could try to add it to RDEPEND like: ``` RDEPEND=" ${PYTHON_DEPS} python? ( dev-python/numpy[${PYTHON_USEDEP}] ) <sci-libs/sundials-4.0.0:0= " ``` Is there a simple way to check that this QA requirement is fulfilled until push it to git and it's CI evaluation? Repoman 2.3.16 (stable portage-2.3.69) doesn't indicate this QA warning. Should it be commited without revision bump? I currently waiting for reviewing of pull request that will add compatibility with `>=sci-libs/sundials-4.0` [1] and there is also another one already merged [2] with the fix for `libdirname` env variable for python installation process. The last seems doesn't actually affect installation process on x32 profile as it should use the system python path but I want to add this fix to `env.patch`. With this both fixes I should then update revision to `-r2` and immediately drop `-r1` revision. Or I could update `env.patch` with additional correction for `libdirname` without revision bump and add second patch `sundials4.patch` for `-r2` revision. [1] https://github.com/Cantera/cantera/pull/672 [2] https://github.com/Cantera/cantera/pull/674
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d1117ab3944b97e8f77fbb9bb98dc205f97cd0f4 commit d1117ab3944b97e8f77fbb9bb98dc205f97cd0f4 Author: band-a-prend <torokhov-s-a@yandex.ru> AuthorDate: 2019-08-09 01:19:28 +0000 Commit: Joonas Niilola <juippis@gentoo.org> CommitDate: 2019-08-09 14:40:50 +0000 sci-libs/cantera: Fix missing RDEPEND="${PYTHON_DEPS}" warning Closes: https://bugs.gentoo.org/691404 Signed-off-by: Sergey Torokhov <torokhov_s_a@mail.ru> Closes: https://github.com/gentoo/gentoo/pull/12650 Signed-off-by: Joonas Niilola <juippis@gentoo.org> sci-libs/cantera/cantera-2.4.0-r1.ebuild | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
