Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 691350 - sys-kernel/linux-firmware: must manually call mount-boot functions in pkg_{preinst,postinst} phase
Summary: sys-kernel/linux-firmware: must manually call mount-boot functions in pkg_{pr...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Thomas Deutschmann (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-08-03 15:42 UTC by Alex Xu (Hello71)
Modified: 2019-08-03 16:07 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Xu (Hello71) 2019-08-03 15:42:53 UTC
if you just install files to /boot it will not work properly on many systems.
Comment 1 Thomas Deutschmann (RETIRED) gentoo-dev 2019-08-03 16:00:41 UTC
I really tested that ;]

I saw the eclass output at the beginning but missed that we were overwriting pkg_preinst and pkg_postinst phase and therefore mount-eclass functions weren't called.

My unmounted /boot mountpoint was also using chmod 755 and therefore I didn't spot the error. With chmod 400 and attr +i the problem became visible.
Comment 2 Larry the Git Cow gentoo-dev 2019-08-03 16:07:02 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ec062d990138a15042619b01261b467beb10df7b

commit ec062d990138a15042619b01261b467beb10df7b
Author:     Thomas Deutschmann <whissi@gentoo.org>
AuthorDate: 2019-08-03 16:06:40 +0000
Commit:     Thomas Deutschmann <whissi@gentoo.org>
CommitDate: 2019-08-03 16:06:55 +0000

    sys-kernel/linux-firmware: manually call mount-boot functions
    
    This is needed because we overwrite these functions in ebuild.
    
    Closes: https://bugs.gentoo.org/691350
    Package-Manager: Portage-2.3.69, Repoman-2.3.16
    Signed-off-by: Thomas Deutschmann <whissi@gentoo.org>

 ...-firmware-20190726-r1.ebuild => linux-firmware-20190726-r2.ebuild} | 4 ++++
 sys-kernel/linux-firmware/linux-firmware-99999999.ebuild              | 4 ++++
 2 files changed, 8 insertions(+)