Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 691276 - app-office/gnucash-3.6 depends on hardcoded ~dev-cpp/gtest-1.8.0
Summary: app-office/gnucash-3.6 depends on hardcoded ~dev-cpp/gtest-1.8.0
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: Normal normal
Assignee: Aaron W. Swenson
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2019-08-02 00:54 UTC by Sergii Parubochiy
Modified: 2020-05-21 11:18 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Suggested 'test' use flag addition to avoid depending on gtest-1.8.0 (gnucash-3.6.ebuild,4.14 KB, text/plain)
2019-08-02 01:05 UTC, Sergii Parubochiy
Details
build.log.xz (build.log.xz,2.29 KB, application/x-xz)
2020-02-19 07:07 UTC, pva
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Sergii Parubochiy 2019-08-02 00:54:18 UTC
Currently gnucash always wants gtest to build.
And depends on gtest-1.8.0 which is marked unstable now.

Can we add 'test' use flag so that we can at least disable testing build so that this dependency can be avoided.

I also noticed that it downloads gtest sources instead of using system one it depends on. Might be worth changing this as well.
Comment 1 Sergii Parubochiy 2019-08-02 01:05:46 UTC
Created attachment 585498 [details]
Suggested 'test' use flag addition to avoid depending on gtest-1.8.0

Here is suggested ebuild changes.
It adds 'test' useflag, which allows at least to disable tests and dependencies.
Comment 2 Arfrever Frehtes Taifersar Arahesis 2019-08-24 19:46:59 UTC
dev-cpp/gtest-1.9.0_pre20190607 is now stable.
Please make app-office/gnucash accept newer dev-cpp/gtest than 1.8.0.
Preferably use only system version of dev-cpp/gtest and stop downloading dev-cpp/gtest tarball.
Comment 3 Larry the Git Cow gentoo-dev 2019-10-13 11:40:57 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=23949ce99d48bdd95a22ad7905a3a8d4a6d4ab1c

commit 23949ce99d48bdd95a22ad7905a3a8d4a6d4ab1c
Author:     Peter Levine <plevine457@gmail.com>
AuthorDate: 2019-08-25 23:16:45 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2019-10-13 11:40:22 +0000

    app-office/gnucash: Don't build gtest from source
    
    With gnucash-3.6, the build now looks for gtest headers and libraries
    and uses them if found.
    
    Closes: https://bugs.gentoo.org/691276
    Package-Manager: Portage-2.3.72, Repoman-2.3.17
    Signed-off-by: Peter Levine <plevine457@gmail.com>
    Closes: https://github.com/gentoo/gentoo/pull/12792
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 app-office/gnucash/gnucash-3.6.ebuild | 11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)
Comment 4 pva 2020-02-19 07:06:26 UTC
Without gtest gnucash fails to build:


-- Checking for GTEST
CMake Error at common/cmake_modules/GncAddTest.cmake:139 (message):
  GTEST not found.  Please install it or set GTEST_ROOT or GMOCK_ROOT
Call Stack (most recent call first):
  CMakeLists.txt:625 (gnc_gtest_configure)
Comment 5 pva 2020-02-19 07:07:00 UTC
Created attachment 614476 [details]
build.log.xz