Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 691246 - app-misc/cfiles: Package added with stable keywords (and without proxy for maintainer)
Summary: app-misc/cfiles: Package added with stable keywords (and without proxy for ma...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Alice Ferrazzi
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-08-01 20:13 UTC by Michał Górny
Modified: 2019-08-09 21:09 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2019-08-01 20:13:55 UTC 
The added package suffers multiple QA issues, in no specific order:

1. Commit message not conforming to GLEP 66.

2. Incorrect (collision-prone) distfile name 'v1.5.tar.gz',

3. Added straight with stable keywords.

4. metadata.xml contains no proxy for the maintainer.

I am going to revert this addition.  Please review ebuilds properly before adding them, and use repoman.
Comment 1 Larry the Git Cow gentoo-dev 2019-08-01 20:14:22 UTC 
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=28b8e3f7d4ab88b58fde623a74be83b4ccbbe606

commit 28b8e3f7d4ab88b58fde623a74be83b4ccbbe606
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: 2019-08-01 20:09:21 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2019-08-01 20:14:17 +0000

    [QA] Revert "app-misc/cfiles: New ebuild"
    
    The package has been added with stable keywords, and without
    a maintainer with commit access.
    
    Bug: https://bugs.gentoo.org/691246
    Signed-off-by: Michał Górny <mgorny@gentoo.org>

 app-misc/cfiles/Manifest          |  1 -
 app-misc/cfiles/cfiles-1.5.ebuild | 27 ---------------------------
 app-misc/cfiles/metadata.xml      | 11 -----------
 3 files changed, 39 deletions(-)
Comment 2 Alice Ferrazzi Gentoo Infrastructure gentoo-dev 2019-08-09 21:07:00 UTC 
closed by 

https://github.com/gentoo/gentoo/commit/94642b1c49e02be215202406a8cbda8b1fed8633

From 94642b1c49e02be215202406a8cbda8b1fed8633 Mon Sep 17 00:00:00 2001
From: Yumi Tanaka <myknt1184@gmail.com>
Date: Fri, 26 Jul 2019 07:03:56 +0000
Subject: [PATCH] app-misc/cfiles: New ebuild

It is a vim like terminal file manager, written in C using the ncurses
library.

Package-Manager: Portage-2.3.62, Repoman-2.3.14
Signed-off-by: Yumi Tanaka <yumi.tanaka@miraclelinux.com>
Signed-off-by: Alice Ferrazzi <alicef@gentoo.org>
---
 app-misc/cfiles/Manifest          |  1 +
 app-misc/cfiles/cfiles-1.5.ebuild | 27 +++++++++++++++++++++++++++
 app-misc/cfiles/metadata.xml      | 15 +++++++++++++++
 3 files changed, 43 insertions(+)
 create mode 100644 app-misc/cfiles/Manifest
 create mode 100644 app-misc/cfiles/cfiles-1.5.ebuild
 create mode 100644 app-misc/cfiles/metadata.xml
Comment 3 Alice Ferrazzi Gentoo Infrastructure gentoo-dev 2019-08-09 21:09:04 UTC 
The added package suffers multiple QA issues, in no specific order:

1. Commit message not conforming to GLEP 66.

2. Incorrect (collision-prone) distfile name 'v1.5.tar.gz',

Pixed

3. Added straight with stable keywords.

Fixed

4. metadata.xml contains no proxy for the maintainer.

Fixed

I am going to revert this addition.  Please review ebuilds properly before adding them, and use repoman.

Reviewed with repoman -dx full