Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 690838 - www-apps/gitea - Provide /usr/lib/tmpfiles.d/gitea.conf
Summary: www-apps/gitea - Provide /usr/lib/tmpfiles.d/gitea.conf
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Felix Neumärker
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2019-07-28 01:25 UTC by Axel Fischer
Modified: 2019-11-07 05:42 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Axel Fischer 2019-07-28 01:25:20 UTC
Hi,

I believe gitea should provide a file /usr/lib/tmpfiles.d/gitea.conf with the content

d /run/gitea 0755 git git

When I restart my machine that uses OpenRc, I need to create that directory manually. Otherwise gitea won't be able to write its socket file.
Comment 1 Felix Neumärker 2019-08-04 19:41:44 UTC
Hi,

I'm not sure about this since it is not mandatory to use a unix-socket - tcp sockets just work fine (there have been issue with unix-socket in the past), right?

Anyway I would be fine to add that, however what are the arguments against using /etc/tmpfiles.d ?
Comment 2 Felix Neumärker 2019-08-05 16:41:32 UTC
okay, included in the next version
Comment 3 Axel Fischer 2019-08-05 23:21:42 UTC
Hi Felix,

thank you. I understand your argument regarding that sockets are not mandatory and therefore the tmpfiles.d configuration would not be needed for auch configuration.

The main argument I see against /etc/tmpfiles.d is that it will override the settings in /usr/lib/tmpfiles.d and therefore I would have to change the configuration file provided by the package in case I want to override the configuration. I believe that putting it in /usr/lib/tmpfiles.d has the advantage that I do not need to merge configurations after an update in case I need to override the defaults provided by the package.

Thank you very much for including it.
Comment 4 Larry the Git Cow gentoo-dev 2019-11-07 05:42:49 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0632e600cea736adec48417e0885d3860dcd1270

commit 0632e600cea736adec48417e0885d3860dcd1270
Author:     Felix Neumärker <xdch47@posteo.de>
AuthorDate: 2019-08-02 10:28:30 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2019-11-07 05:42:29 +0000

    www-apps/gitea: bump to 1.9.5
    
    Closes: https://bugs.gentoo.org/687148
    Closes: https://bugs.gentoo.org/690838
    Closes: https://bugs.gentoo.org/693536
    
    Package-Manager: Portage-2.3.69, Repoman-2.3.16
    Signed-off-by: Felix Neumärker <xdch47@posteo.de>
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 www-apps/gitea/Manifest                     |   1 +
 www-apps/gitea/files/gitea-logflags.patch   |  13 ++++
 www-apps/gitea/files/gitea-mod-vendor.patch |  46 ++++++++++++
 www-apps/gitea/gitea-1.9.5.ebuild           | 111 ++++++++++++++++++++++++++++
 www-apps/gitea/metadata.xml                 |   7 +-
 5 files changed, 174 insertions(+), 4 deletions(-)