Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 690146 - sci-electronics/kicad-5.1 fails to compile with swig-4.0.0
Summary: sci-electronics/kicad-5.1 fails to compile with swig-4.0.0
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Zoltan Puskas
URL:
Whiteboard:
Keywords: PATCH, PullRequest
: 691438 (view as bug list)
Depends on:
Blocks:
 
Reported: 2019-07-18 14:14 UTC by Cedric Godin
Modified: 2019-08-11 10:19 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch to compile kicad-5.1 with swig-4.0.0 (kicad-5.1.2-swig-4.0.0.patch,623 bytes, patch)
2019-07-18 14:14 UTC, Cedric Godin
Details | Diff
update patch with correct relative path (kicad-5.1.2_swig-4.0.0.patch,623 bytes, patch)
2019-08-02 15:16 UTC, jon R-B
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Cedric Godin 2019-07-18 14:14:37 UTC
Created attachment 583388 [details, diff]
Patch to compile kicad-5.1 with swig-4.0.0

When trying to emerge kicad-5.1.2, compilation failed with :


Error: the swig import helper was not fixed, check /var/tmp/portage/sci-electronics/kicad-5.1.2/work/kicad-5.1.2_build/pcbnew/pcbnew.py
       and fix this script: fix_swig_imports.py
make[2]: *** [pcbnew/CMakeFiles/pcbnew_kiface_objects.dir/build.make:108: pcbnew/pcbnew_wrap.cxx] Error 2
make[2]: *** Deleting file 'pcbnew/pcbnew_wrap.cxx'
make[2]: Leaving directory '/var/tmp/portage/sci-electronics/kicad-5.1.2/work/kicad-5.1.2_build'
make[1]: *** [CMakeFiles/Makefile2:1553: pcbnew/CMakeFiles/pcbnew_kiface_objects.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....

A patch was submitted for this : https://lists.launchpad.net/kicad-developers/msg40590.html (attached)

Compiles fine after applying it.
Comment 1 Zoltan Puskas 2019-07-29 06:37:40 UTC
Yes indeed. Thank for reporting and also finding upstream patch. Making amendments to ebuild.
Comment 2 jon R-B 2019-08-02 15:16:29 UTC
Created attachment 585506 [details, diff]
update patch with correct relative path
Comment 3 jon R-B 2019-08-02 15:17:14 UTC
Note: the original patch fails to apply (wrong relative path)
Comment 4 Zoltan Puskas 2019-08-02 20:01:53 UTC
Thanks @jon R-B, that shall help people till PR12568 is merged into the main tree in which I already corrected the patch, but I did not think of posting it here too, which would have been a good idea.
Comment 5 Larry the Git Cow gentoo-dev 2019-08-03 09:28:21 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8b9a5153b00803bc29cd6809f3d7725d0589f3c0

commit 8b9a5153b00803bc29cd6809f3d7725d0589f3c0
Author:     Zoltan Puskas <zoltan@sinustrom.info>
AuthorDate: 2019-07-29 06:58:00 +0000
Commit:     Alexey Shvetsov <alexxy@gentoo.org>
CommitDate: 2019-08-03 09:28:07 +0000

    sci-electronics/kicad: Fix 5.1.x build issues with swig-4.0.0
    
    Closes: https://bugs.gentoo.org/690146
    Signed-off-by: Zoltan Puskas <zoltan@sinustrom.info>
    Package-Manager: Portage-2.3.69, Repoman-2.3.16
    Closes: https://github.com/gentoo/gentoo/pull/12568
    Signed-off-by: Alexey Shvetsov <alexxy@gentoo.org>

 sci-electronics/kicad/files/kicad-5.1.0-swig-4.0.0.patch     | 12 ++++++++++++
 .../kicad/{kicad-5.1.0.ebuild => kicad-5.1.0-r1.ebuild}      |  1 +
 .../kicad/{kicad-5.1.2.ebuild => kicad-5.1.2-r1.ebuild}      |  1 +
 3 files changed, 14 insertions(+)
Comment 6 Zoltan Puskas 2019-08-11 10:19:50 UTC
*** Bug 691438 has been marked as a duplicate of this bug. ***