libfsemu/src/ml/x11.c: In function ‘set_window_icon’: libfsemu/src/ml/x11.c:124:56: error: ‘XA_CARDINAL’ undeclared (first use in this function) 124 | XChangeProperty(g_display, g_window, _NET_WM_ICON, XA_CARDINAL, 32, | ^~~~~~~~~~~ libfsemu/src/ml/x11.c:124:56: note: each undeclared identifier is reported only once for each function it appears in ------------------------------------------------------------------- This is an unstable amd64 chroot image at a tinderbox (==build bot) name: 17.1_no-multilib-20190711-143155 ------------------------------------------------------------------- gcc-config -l: [1] x86_64-pc-linux-gnu-9.1.0 * Available Python interpreters, in order of preference: [1] python3.7 [2] python3.6 [3] python2.7 (fallback) Available Ruby profiles: [1] ruby24 (with Rubygems) * Available Rust versions: [1] rust-1.36.0 * emerge -qpvO app-emulation/fs-uae [ebuild N ] app-emulation/fs-uae-2.8.3 USE="-fmv -glew"
Created attachment 583054 [details] emerge-info.txt
Created attachment 583056 [details] app-emulation:fs-uae-2.8.3:20190716-064553.log
Created attachment 583058 [details] emerge-history.txt
Created attachment 583060 [details] environment
Created attachment 583062 [details] etc.portage.tbz2
Created attachment 583064 [details] logs.tbz2
Created attachment 583066 [details] temp.tbz2
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8da99c730e3f9737f875acdaf614bfcfc47da052 commit 8da99c730e3f9737f875acdaf614bfcfc47da052 Author: James Le Cuirot <chewi@gentoo.org> AuthorDate: 2019-07-21 20:56:33 +0000 Commit: James Le Cuirot <chewi@gentoo.org> CommitDate: 2019-07-21 20:56:33 +0000 app-emulation/fs-uae: Version bump to 3.0.0 Closes: https://bugs.gentoo.org/689994 Package-Manager: Portage-2.3.69, Repoman-2.3.13 Signed-off-by: James Le Cuirot <chewi@gentoo.org> app-emulation/fs-uae/Manifest | 1 + .../fs-uae/files/fs-uae-3.0.0-libmpeg2.patch | 48 +++++++++ app-emulation/fs-uae/fs-uae-3.0.0.ebuild | 117 +++++++++++++++++++++ 3 files changed, 166 insertions(+)
Hi, This is not fixed - I am getting this exact same issue with app-emulation/fs-uae-3.0.0 The missing constant XA_CARDINAL looks like it is from X11/Xatom.h, which does not seem to be pulled in by any of the includes in x11.c (if that helps)
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=07e7677694e74d5410824fa70febbff79d77d5bf commit 07e7677694e74d5410824fa70febbff79d77d5bf Author: James Le Cuirot <chewi@gentoo.org> AuthorDate: 2019-08-27 21:31:42 +0000 Commit: James Le Cuirot <chewi@gentoo.org> CommitDate: 2019-08-27 21:32:29 +0000 app-emulation/fs-uae: Fix missing X11/Xatom.h include I think this was breaking when SDL2 was built with USE=-X. I think it needs USE=X but I have added the missing include anyway and sent the patch upstream. Closes: https://bugs.gentoo.org/689994 Package-Manager: Portage-2.3.73, Repoman-2.3.17 Signed-off-by: James Le Cuirot <chewi@gentoo.org> .../fs-uae/files/fs-uae-3.0.0-Xatom.h.patch | 25 ++++++++++++++++++++++ app-emulation/fs-uae/fs-uae-3.0.0.ebuild | 3 ++- 2 files changed, 27 insertions(+), 1 deletion(-)
(In reply to Larry the Git Cow from comment #10) > The bug has been closed via the following commit(s): > > https://gitweb.gentoo.org/repo/gentoo.git/commit/ > ?id=07e7677694e74d5410824fa70febbff79d77d5bf > > commit 07e7677694e74d5410824fa70febbff79d77d5bf > Author: James Le Cuirot <chewi@gentoo.org> > AuthorDate: 2019-08-27 21:31:42 +0000 > Commit: James Le Cuirot <chewi@gentoo.org> > CommitDate: 2019-08-27 21:32:29 +0000 > > app-emulation/fs-uae: Fix missing X11/Xatom.h include > > I think this was breaking when SDL2 was built with USE=-X. I think it > needs USE=X but I have added the missing include anyway and sent the > patch upstream. > > Closes: https://bugs.gentoo.org/689994 > Package-Manager: Portage-2.3.73, Repoman-2.3.17 > Signed-off-by: James Le Cuirot <chewi@gentoo.org> > > .../fs-uae/files/fs-uae-3.0.0-Xatom.h.patch | 25 > ++++++++++++++++++++++ > app-emulation/fs-uae/fs-uae-3.0.0.ebuild | 3 ++- > 2 files changed, 27 insertions(+), 1 deletion(-)
Please ignore previous post (something weird happened in my browser) > I think this was breaking when SDL2 was built with USE=-X. I think it > needs USE=X but I have added the missing include anyway and sent the > patch upstream. I just wanted to confirm that I had SDL2 without the X use flag, and that your fix worked, and the package now builds successfully. Thanks Good job :)
