689816 – [science] Literal CR in sci-biology/portrait/portrait-1.1.ebuild

Bug 689816 - [science] Literal CR in sci-biology/portrait/portrait-1.1.ebuild

Summary: [science] Literal CR in sci-biology/portrait/portrait-1.1.ebuild

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Overlays (show other bugs)
Hardware:	All Linux

Importance:	Normal normal (vote)
Assignee:	Martin Mokrejš

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2019-07-14 06:36 UTC by Michał Górny
Modified:	2019-07-16 21:53 UTC (History)
CC List:	1 user (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Michał Górny archtester

2019-07-14 06:36:49 UTC

25     sed -e 's/^M//' -i *.pl || die "Failed to convert from DOS line endings to Unix"

That's a recipe for disaster.  Please use '\r'.

Comment 1 Larry the Git Cow gentoo-dev

2019-07-16 21:53:58 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/proj/sci.git/commit/?id=2e1c2e4408aae4d87589293af913dfa588b679d3

commit 2e1c2e4408aae4d87589293af913dfa588b679d3
Author:     Martin Mokrejs <mmokrejs@fold.natur.cuni.cz>
AuthorDate: 2019-07-16 21:53:39 +0000
Commit:     Martin Mokrejs <mmokrejs@fold.natur.cuni.cz>
CommitDate: 2019-07-16 21:53:39 +0000

    sci-biology/portrait: Rewrite sed hackery (aka DOS2Unix)
    
    Thanks to @mgorny for the hint.
    Reported-by: <mgorny@gentoo.org>
    Closes: https://bugs.gentoo.org/689816
    Package-Manager: Portage-2.3.69, Repoman-2.3.16
    Signed-off-by: Martin Mokrejs <mmokrejs@fold.natur.cuni.cz>

 sci-biology/portrait/portrait-1.1.ebuild | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)