Created attachment 582812 [details, diff] diff to 67.0.4 for explain In www-client/firefox-68.0.ebuild, the plugins directory fix code has been removed.
(In reply to nilburn from comment #0) > Created attachment 582812 [details, diff] [details, diff] > diff to 67.0.4 for explain > > In www-client/firefox-68.0.ebuild, > the plugins directory fix code has been removed. You will need to open a bug for each plugin that is failing due to location so we can address it before esr branch gets updated.
(In reply to Jory A. Pratt from comment #1) > (In reply to nilburn from comment #0) > > Created attachment 582812 [details, diff] [details, diff] [details, diff] > > diff to 67.0.4 for explain > > > > In www-client/firefox-68.0.ebuild, > > the plugins directory fix code has been removed. > > You will need to open a bug for each plugin that is failing due to location > so we can address it before esr branch gets updated. To clarify: - Should these bug reports go against the plugins themselves? - How should they fix it (install both to the old and the "new" location to not break compat with older FF and other browsers?). - What is the new location for plugins which FF is looking at? I observe this basically for all plugins: - www-plugins/google-talkplugin - www-plugins/adobe-flash - media-sound/rhythmbox - dev-java/oracle-jdk-bin So I wanted to clarify these questions before opening a load of bug reports.
Created attachment 583658 [details, diff] firefox-68.0.1-nsbrowser_plugins_directory.patch Patch for www-client/firefox which intends to support both styles of directories: /usr/lib(64)/mozilla/plugins /usr/lib(64)/nsbrowser/plugins
(In reply to Jory A. Pratt from comment #1) > (In reply to nilburn from comment #0) > > Created attachment 582812 [details, diff] [details, diff] [details, diff] > > diff to 67.0.4 for explain > > > > In www-client/firefox-68.0.ebuild, > > the plugins directory fix code has been removed. > > You will need to open a bug for each plugin that is failing due to location > so we can address it before esr branch gets updated. Below are my thoughts. Gentoo linux provides a shared directory for sharing plugins between multiple browsers. It is /usr/$(get_libdir)/nsbrowser/plugins. We need to change the original plugin directory to the Gentoo shared plugin directory. www-client/firefox-bin ebuild calls the share_plugins_dir function, which is defined in nsplugins.eclass, at installation time. The former www-client/firefox ebuild has rewritten the directory path written in source code using the sed command. I think there are three options for fixing this bug: 1. Restore the previous sed command. 2. Call share_plugins_dir in the same way as www-client/firefox-bin. 3. Apply a patch like https://bugs.gentoo.org/attachment.cgi?id=583658.
As a temporary work around: # mkdir /usr/lib64/mozilla # ln -s ../nsbrowser/plugins /usr/lib64/mozilla/plugins
*** Bug 690306 has been marked as a duplicate of this bug. ***
If someone wants to test beta15 from the mozilla overlay and confirm it is resolved would be appreciated.
https://gitweb.gentoo.org/proj/mozilla.git/commit/?id=d376ec1b02874fcf768f467c4170f577211beb72 commit d376ec1b02874fcf768f467c4170f577211beb72 Author: Jory Pratt <anarchy@gentoo.org> AuthorDate: 2019-08-22 14:33:36 +0000 Commit: Jory Pratt <anarchy@gentoo.org> CommitDate: 2019-08-22 14:33:36 +0000 www-client/firefox: add patch for multiple plugin locationa Package-Manager: Portage-2.3.72, Repoman-2.3.17 Signed-off-by: Jory Pratt <anarchy@gentoo.org>
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=dec0f75ba9bbabb715c98ffd5d40eea3fa23ef82 commit dec0f75ba9bbabb715c98ffd5d40eea3fa23ef82 Author: Jory Pratt <anarchy@gentoo.org> AuthorDate: 2019-08-28 17:39:52 +0000 Commit: Jory Pratt <anarchy@gentoo.org> CommitDate: 2019-08-28 17:40:57 +0000 www-client/firefox: Add additional plugin dir support Closes: https://bugs.gentoo.org/689810 Package-Manager: Portage-2.3.73, Repoman-2.3.17 Signed-off-by: Jory Pratt <anarchy@gentoo.org> www-client/firefox/Manifest | 94 +--- www-client/firefox/firefox-68.0.1.ebuild | 763 ------------------------------- www-client/firefox/firefox-68.0.2.ebuild | 2 +- 3 files changed, 2 insertions(+), 857 deletions(-)
Feel free to re-emerge firefox now if you can not wait about 7 days for the update to be released. I kept this in mind when I was addressing the issue so users are not rebuilding twice in 7 days when so few are effected.
