Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 689482 - www-client/vivaldi*: invalid local extension to L10N
Summary: www-client/vivaldi*: invalid local extension to L10N
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Jeroen Roovers (RETIRED)
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2019-07-08 12:57 UTC by Michał Górny
Modified: 2019-08-13 22:36 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2019-07-08 12:57:47 UTC
https://qa-reports.gentoo.org/output/gentoo-ci/output.html#www-client/vivaldi

It is invalid to create local flags that collide with USE_EXPAND.  The necessary locales should have been added to l10n.desc.
Comment 1 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2019-07-16 12:37:25 UTC
Ping.
Comment 2 Larry the Git Cow gentoo-dev 2019-08-13 22:25:25 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0907f706ef3ab9b4f5d9e3f446fa6ce3b73993e1

commit 0907f706ef3ab9b4f5d9e3f446fa6ce3b73993e1
Author:     David Seifert <soap@gentoo.org>
AuthorDate: 2019-08-13 22:25:08 +0000
Commit:     David Seifert <soap@gentoo.org>
CommitDate: 2019-08-13 22:25:08 +0000

    profiles/desc: Add L10N locales from www-client/vivaldi*
    
    Bug: https://bugs.gentoo.org/689482
    Signed-off-by: David Seifert <soap@gentoo.org>

 profiles/desc/l10n.desc | 4 ++++
 1 file changed, 4 insertions(+)
Comment 3 Larry the Git Cow gentoo-dev 2019-08-13 22:34:21 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=cb28153621119aecd1c8b771149ff063b0cd05d3

commit cb28153621119aecd1c8b771149ff063b0cd05d3
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: 2019-07-23 16:31:46 +0000
Commit:     David Seifert <soap@gentoo.org>
CommitDate: 2019-08-13 22:33:00 +0000

    www-client/vivaldi-snapshot: [QA] Remove invalid extensions to L10N
    
    Remove the local flags extending L10N.  Per standing policy [1], all
    USE_EXPAND flags must be documented in profiles/desc.
    
    [1] https://devmanual.gentoo.org/general-concepts/use-flags/index.html
    
    Closes: https://bugs.gentoo.org/689482
    Signed-off-by: Michał Górny <mgorny@gentoo.org>
    Signed-off-by: David Seifert <soap@gentoo.org>

 www-client/vivaldi-snapshot/metadata.xml | 14 ++++----------
 1 file changed, 4 insertions(+), 10 deletions(-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d9c1b56b397e13fecfbc5cec3f58b2606d02f9ad

commit d9c1b56b397e13fecfbc5cec3f58b2606d02f9ad
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: 2019-07-23 16:30:24 +0000
Commit:     David Seifert <soap@gentoo.org>
CommitDate: 2019-08-13 22:32:57 +0000

    www-client/vivaldi: [QA] Remove invalid extensions to L10N
    
    Remove the local flags extending L10N.  Per standing policy [1], all
    USE_EXPAND flags must be documented in profiles/desc.
    
    [1] https://devmanual.gentoo.org/general-concepts/use-flags/index.html
    
    Closes: https://bugs.gentoo.org/689482
    Closes: https://github.com/gentoo/gentoo/pull/12521
    Signed-off-by: Michał Górny <mgorny@gentoo.org>
    Signed-off-by: David Seifert <soap@gentoo.org>

 www-client/vivaldi/metadata.xml | 14 ++++----------
 1 file changed, 4 insertions(+), 10 deletions(-)
Comment 4 David Seifert gentoo-dev 2019-08-13 22:36:47 UTC
Dear jer,
this is your last warning. Should you ignore QA's advice again in the future, we will consider revoking your commit access. Please work with QA in improving the quality of the tree.