The package introduces local extension to L10N which is forbidden by PMS. Please fix that.
(In reply to Michał Górny from comment #0) > The package introduces local extension to L10N which is forbidden by PMS. > Please fix that. Please provide a citation. I haven't been able to find the relevant part with what you've given, so I can't further familiarize myself on this particular topic.
Policy reference: https://devmanual.gentoo.org/general-concepts/use-flags/index.html#use-flag-descriptions "All USE flags must be described in either use.desc in the profiles/ directory or metadata.xml in the package's directory. [...] The exceptions to this are USE_EXPAND flags, which must be documented in the profiles/desc/ directory. [...]"
Also note, on top of l10n.desc: # Keep it sorted. Entries must be valid IETF language tags (BCP 47): # https://www.iana.org/assignments/language-subtag-registry which 'C' isn't. Normally support for 'C' locale should be installed unconditionally. However, if this is kind of special case, 'en' is more correct.
(In reply to Ulrich Müller from comment #2) > Policy reference: > https://devmanual.gentoo.org/general-concepts/use-flags/index.html#use-flag- > descriptions > > "All USE flags must be described in either use.desc in the profiles/ > directory or metadata.xml in the package's directory. [...] > > The exceptions to this are USE_EXPAND flags, which must be documented in the > profiles/desc/ directory. [...]" That's much clearer. Thank you.
(In reply to Michał Górny from comment #3) > Also note, on top of l10n.desc: > > # Keep it sorted. Entries must be valid IETF language tags (BCP 47): > # https://www.iana.org/assignments/language-subtag-registry > > which 'C' isn't. This is good to know, but this doesn't really forbid an entry in metadata.xml. > Normally support for 'C' locale should be installed > unconditionally. However, if this is kind of special case, 'en' is more > correct. Hm. C is English, but for this package there are two languages that don't have a translations. Therefore we unconditionally install C-locale for those languages. So, I'm not certain now that it should be given a special case. I think I'll go ahead and always install it. It'll be cleaner, and it will still take less space than it did before I introduced using l10n.
Ping. Is there anything blocking making it unconditional? Would it help if I made a patch?
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=893017730e5189c09ad38083286b7ee1ed2613b2 commit 893017730e5189c09ad38083286b7ee1ed2613b2 Author: Michał Górny <mgorny@gentoo.org> AuthorDate: 2019-07-18 06:58:40 +0000 Commit: Aaron W. Swenson <titanofold@gentoo.org> CommitDate: 2019-07-18 12:55:59 +0000 app-doc/gnucash-docs: Sanitize L10N handling - remove L10N=C, C locale is now installed unconditionally - remove unused l10n.eclass - simplify the code Bug: https://bugs.gentoo.org/689474 Signed-off-by: Michał Górny <mgorny@gentoo.org> Closes: https://github.com/gentoo/gentoo/pull/12465 Closes: https://bugs.gentoo.org/689474 Signed-off-by: Aaron W. Swenson <titanofold@gentoo.org> ...-docs-3.6.ebuild => gnucash-docs-3.6-r1.ebuild} | 31 +++++----------------- 1 file changed, 6 insertions(+), 25 deletions(-) Additionally, it has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=893017730e5189c09ad38083286b7ee1ed2613b2 commit 893017730e5189c09ad38083286b7ee1ed2613b2 Author: Michał Górny <mgorny@gentoo.org> AuthorDate: 2019-07-18 06:58:40 +0000 Commit: Aaron W. Swenson <titanofold@gentoo.org> CommitDate: 2019-07-18 12:55:59 +0000 app-doc/gnucash-docs: Sanitize L10N handling - remove L10N=C, C locale is now installed unconditionally - remove unused l10n.eclass - simplify the code Bug: https://bugs.gentoo.org/689474 Signed-off-by: Michał Górny <mgorny@gentoo.org> Closes: https://github.com/gentoo/gentoo/pull/12465 Closes: https://bugs.gentoo.org/689474 Signed-off-by: Aaron W. Swenson <titanofold@gentoo.org> ...-docs-3.6.ebuild => gnucash-docs-3.6-r1.ebuild} | 31 +++++----------------- 1 file changed, 6 insertions(+), 25 deletions(-)
I just hadn't dug into it yet, and I wasn't happy with how it was looking when I started on it. Your PR is what I was going to arrive at (close enough anyway). Thanks!
