Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 689434 - dev-libs/libical: Add "glib" USE flag
Summary: dev-libs/libical: Add "glib" USE flag
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: Normal normal
Assignee: Andreas Sturmlechner
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-07-08 06:45 UTC by Joakim Tjernlund
Modified: 2020-06-17 09:42 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Joakim Tjernlund 2019-07-08 06:50:42 UTC
hmm, glib is mentioned in libical too, is it included therein now?
Comment 2 Arfrever Frehtes Taifersar Arahesis 2019-07-09 02:15:17 UTC
(In reply to Joakim Tjernlund from comment #1)
> glib is mentioned in libical too, is it included therein now?

Yes:
https://github.com/libical/libical/tree/master/src/libical-glib
https://github.com/libical/libical/blob/8b9765553c2a6a7155f824a29d5271242530b800/src/libical-glib/CMakeLists.txt#L96
Comment 3 Andreas Sturmlechner gentoo-dev 2019-07-09 06:27:03 UTC
I'm sure Gnome project will call as soon as they need it.
Comment 4 Joakim Tjernlund 2019-07-09 08:45:05 UTC
(In reply to Andreas Sturmlechner from comment #3)
> I'm sure Gnome project will call as soon as they need it.

That will take forever and I want to use newer evolution sooner.
I do my own ebuild for evo, basically just renaming the in the the tree.
Comment 5 Joakim Tjernlund 2019-08-12 12:14:02 UTC
Ping ?

Any chance you can add glib USE soonish? I need it and am hoping to avoid
cloning libical ebuild just to add this USE flag.
Comment 6 Larry the Git Cow gentoo-dev 2019-08-16 22:19:32 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=90c3e358250f3c76c625fd120432db1caa070479

commit 90c3e358250f3c76c625fd120432db1caa070479
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2019-08-16 22:18:45 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2019-08-16 22:19:20 +0000

    dev-libs/libical: Add USE glib
    
    Bug: https://bugs.gentoo.org/689434
    Package-Manager: Portage-2.3.71, Repoman-2.3.17
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 dev-libs/libical/libical-3.0.5.ebuild | 13 ++++++-------
 dev-libs/libical/metadata.xml         |  3 +++
 2 files changed, 9 insertions(+), 7 deletions(-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8215b32e5162cbb654c977fbd487eb74a6dee4be

commit 8215b32e5162cbb654c977fbd487eb74a6dee4be
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2019-08-16 21:59:15 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2019-08-16 22:19:19 +0000

    profiles: base: Add dev-libs/libical[glib] to package.use.stable.mask
    
    Bug: https://bugs.gentoo.org/689434
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 profiles/base/package.use.stable.mask | 4 ++++
 1 file changed, 4 insertions(+)
Comment 7 Joakim Tjernlund 2019-08-17 11:47:59 UTC
Thanks a lot!
Comment 8 Joakim Tjernlund 2019-08-23 10:31:47 UTC
I just tried to build evolution-data-server-3.33.91 and got this error:

Couldn't find include 'ICalGLib-3.0.gir' (search path: '['/var/tmp/portage/gnome-extra/evolution-data-server-3.33.91/work/evolution-data-server-3.33.91_build', '/var/tmp/portage/gnome-extra/evolution-data-server-3.33.91/work/evolution-data-server-3.33.91_build/src', '/var/tmp/portage/gnome-extra/evolution-data-server-3.33.91/work/evolution-data-server-3.33.91', '/var/tmp/portage/gnome-extra/evolution-data-server-3.33.91/work/evolution-data-server-3.33.91/src', '/var/tmp/portage/gnome-extra/evolution-data-server-3.33.91/work/evolution-data-server-3.33.91_build/src/calendar/libecal', '/var/tmp/portage/gnome-extra/evolution-data-server-3.33.91/work/evolution-data-server-3.33.91/src/calendar/libecal', '/usr/share/gir-1.0', '/usr/local/share/gir-1.0', '/usr/share/gir-1.0', '/usr/share/gir-1.0', '/usr/share/gir-1.0', '/usr/share/gir-1.0']')
[ 68%] Generating evolution-source-registry-resource.c
make[2]: *** [src/calendar/libecal/CMakeFiles/gir-girs-ECal_2_0_gir.dir/build.make:113: src/calendar/libecal/ECal-2.0.gir] Error 1
make[1]: *** [CMakeFiles/Makefile2:5203: src/calendar/libecal/CMakeFiles/gir-girs-ECal_2_0_gir.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....

Any idea what might be wrong?
Comment 9 Joakim Tjernlund 2019-08-23 11:49:14 UTC
(In reply to Joakim Tjernlund from comment #8)
> I just tried to build evolution-data-server-3.33.91 and got this error:
> 
> Couldn't find include 'ICalGLib-3.0.gir' (search path:
> '['/var/tmp/portage/gnome-extra/evolution-data-server-3.33.91/work/evolution-
> data-server-3.33.91_build',
> '/var/tmp/portage/gnome-extra/evolution-data-server-3.33.91/work/evolution-
> data-server-3.33.91_build/src',
> '/var/tmp/portage/gnome-extra/evolution-data-server-3.33.91/work/evolution-
> data-server-3.33.91',
> '/var/tmp/portage/gnome-extra/evolution-data-server-3.33.91/work/evolution-
> data-server-3.33.91/src',
> '/var/tmp/portage/gnome-extra/evolution-data-server-3.33.91/work/evolution-
> data-server-3.33.91_build/src/calendar/libecal',
> '/var/tmp/portage/gnome-extra/evolution-data-server-3.33.91/work/evolution-
> data-server-3.33.91/src/calendar/libecal', '/usr/share/gir-1.0',
> '/usr/local/share/gir-1.0', '/usr/share/gir-1.0', '/usr/share/gir-1.0',
> '/usr/share/gir-1.0', '/usr/share/gir-1.0']')
> [ 68%] Generating evolution-source-registry-resource.c
> make[2]: ***
> [src/calendar/libecal/CMakeFiles/gir-girs-ECal_2_0_gir.dir/build.make:113:
> src/calendar/libecal/ECal-2.0.gir] Error 1
> make[1]: *** [CMakeFiles/Makefile2:5203:
> src/calendar/libecal/CMakeFiles/gir-girs-ECal_2_0_gir.dir/all] Error 2
> make[1]: *** Waiting for unfinished jobs....
> 
> Any idea what might be wrong?

Figured it out, evolution-data-server-3.33.x needs
	-DGOBJECT_INTROSPECTION=$(usex glib)
	-DICAL_GLIB_VAPI=$(usex glib)
in libical to build.
Could these two depends on USE=glib as well?
Comment 10 Joakim Tjernlund 2019-08-23 12:03:41 UTC
(In reply to Joakim Tjernlund from comment #9)
> (In reply to Joakim Tjernlund from comment #8)
> > I just tried to build evolution-data-server-3.33.91 and got this error:
> > 
> > Couldn't find include 'ICalGLib-3.0.gir' (search path:
> > '['/var/tmp/portage/gnome-extra/evolution-data-server-3.33.91/work/evolution-
> > data-server-3.33.91_build',
> > '/var/tmp/portage/gnome-extra/evolution-data-server-3.33.91/work/evolution-
> > data-server-3.33.91_build/src',
> > '/var/tmp/portage/gnome-extra/evolution-data-server-3.33.91/work/evolution-
> > data-server-3.33.91',
> > '/var/tmp/portage/gnome-extra/evolution-data-server-3.33.91/work/evolution-
> > data-server-3.33.91/src',
> > '/var/tmp/portage/gnome-extra/evolution-data-server-3.33.91/work/evolution-
> > data-server-3.33.91_build/src/calendar/libecal',
> > '/var/tmp/portage/gnome-extra/evolution-data-server-3.33.91/work/evolution-
> > data-server-3.33.91/src/calendar/libecal', '/usr/share/gir-1.0',
> > '/usr/local/share/gir-1.0', '/usr/share/gir-1.0', '/usr/share/gir-1.0',
> > '/usr/share/gir-1.0', '/usr/share/gir-1.0']')
> > [ 68%] Generating evolution-source-registry-resource.c
> > make[2]: ***
> > [src/calendar/libecal/CMakeFiles/gir-girs-ECal_2_0_gir.dir/build.make:113:
> > src/calendar/libecal/ECal-2.0.gir] Error 1
> > make[1]: *** [CMakeFiles/Makefile2:5203:
> > src/calendar/libecal/CMakeFiles/gir-girs-ECal_2_0_gir.dir/all] Error 2
> > make[1]: *** Waiting for unfinished jobs....
> > 
> > Any idea what might be wrong?
> 
> Figured it out, evolution-data-server-3.33.x needs
> 	-DGOBJECT_INTROSPECTION=$(usex glib)
> 	-DICAL_GLIB_VAPI=$(usex glib)
> in libical to build.
> Could these two depends on USE=glib as well?

Forgot to say, adding inherit vala and
   -DVALAC=${VALAC}
   -DVAPIGEN=${VAPIGEN}
to mycmakeargs is needed to make libical build with -DICAL_GLIB_VAPI=$(usex glib)
Comment 11 Andreas Sturmlechner gentoo-dev 2019-08-23 12:12:23 UTC
sigh. anything else involved with adding vala eclass?
Comment 12 Joakim Tjernlund 2019-08-23 12:25:13 UTC
(In reply to Andreas Sturmlechner from comment #11)
> sigh. anything else involved with adding vala eclass?

I have no real knowledge about vala, I just looked around and found
a solution.

I do note that a few ebuilds also has 
  VALA_USE_DEPEND="vapigen"
and libical uses vapigen too so maybe that needs added?
Comment 13 Joakim Tjernlund 2019-08-23 12:45:54 UTC
Just to be clear, with the above changes evolution-3.33.91, 
evolution-data-server-3.33.91 and evolution-ews-3.33.91 build
and runs.
Comment 14 Larry the Git Cow gentoo-dev 2019-09-18 18:13:39 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1c6e0593af245703205da5109eb46721cc0e542a

commit 1c6e0593af245703205da5109eb46721cc0e542a
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2019-09-17 16:15:09 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2019-09-18 18:13:22 +0000

    dev-libs/libical: 3.0.6 version bump, add USE introspection,vala
    
    Merge USE glib into introspection.
    
    Bug: https://bugs.gentoo.org/689434
    Closes: https://bugs.gentoo.org/694588
    Package-Manager: Portage-2.3.76, Repoman-2.3.17
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 dev-libs/libical/Manifest             |  1 +
 dev-libs/libical/libical-3.0.6.ebuild | 94 +++++++++++++++++++++++++++++++++++
 2 files changed, 95 insertions(+)
Comment 15 Arfrever Frehtes Taifersar Arahesis 2019-09-20 06:13:43 UTC
Separate USE flags (IUSE="glib introspection vala ...") would be better.
REQUIRED_USE="vala? ( introspection )" would still be correct.

Anyway dev-libs/gobject-introspection dependency and $(vala_depend) should be in BDEPEND, not DEPEND+RDEPEND.

(In reply to Joakim Tjernlund from comment #12)
> I do note that a few ebuilds also has 
>   VALA_USE_DEPEND="vapigen"
> and libical uses vapigen too so maybe that needs added?

This would generate dev-lang/vala:${slot}[vapigen(+)] dependency, but currently no ebuilds of dev-lang/vala have "vapigen" USE flag.
Comment 16 Nuno Silva 2020-06-17 09:42:50 UTC
Shouldn't USE=glib also depend on something more (gtk-doc?) when USE=doc?