Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 689178 - dev-python/python-musicbrainz-ngs-0.6 compiles/works with python 3.7
Summary: dev-python/python-musicbrainz-ngs-0.6 compiles/works with python 3.7
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: gerion
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2019-07-02 21:47 UTC by Stefan Briesenick
Modified: 2019-07-16 15:33 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan Briesenick 2019-07-02 21:47:50 UTC 
see summary. Please add 3.7 to PYTHON_COMPAT.

I've tested it with python 3.7 and one of my scripts. Works perfect.

Thanks!
Comment 1 Jonas Stein gentoo-dev 2019-07-03 15:27:07 UTC 
Which tests did you run exactly?
What is the statement about 3.7 by upstream?
Comment 2 Stefan Briesenick 2019-07-03 15:32:55 UTC 
I don't know anything about upstream.

but: in arch linux, it's already for python 3.7

and regarding my tests: I've written some scripts for tagging my audio files, using this lib. And it worked w/o any problems with python 3.7 and this lib build for 3.7.

just adding 3_7 to PYTHON_COMPAT is enough. Works perfect.
Comment 3 Stefan Briesenick 2019-07-08 14:13:18 UTC 
no further comments/questions?
Comment 4 gerion 2019-07-08 16:11:02 UTC 
My mail server was down but I will look into it.
Comment 5 Larry the Git Cow gentoo-dev 2019-07-16 15:33:06 UTC 
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c7c44e7d68910acacef6d3c2efdfca980c44098c

commit c7c44e7d68910acacef6d3c2efdfca980c44098c
Author:     Gerion Entrup <entrup@sra.uni-hannover.de>
AuthorDate: 2019-07-12 22:02:45 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2019-07-16 15:22:18 +0000

    dev-python/python-musicbrainz-ngs: python3.7 and fix test cases
    
    Closes: https://bugs.gentoo.org/689178
    Closes: https://bugs.gentoo.org/653426
    Package-Manager: Portage-2.3.66, Repoman-2.3.11
    Signed-off-by: Gerion Entrup <gerion.entrup@flump.de>
    Closes: https://github.com/gentoo/gentoo/pull/12436
    Signed-off-by: Michał Górny <mgorny@gentoo.org>

 .../files/0.6-fix-test-submit.patch                | 32 ++++++++++++++++++++++
 .../python-musicbrainz-ngs-0.6.ebuild              |  8 ++++--
 2 files changed, 37 insertions(+), 3 deletions(-)