Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 689124 - games-strategy/0ad-0.0.23b_alpha: allow using system library dev-lang/spidermonkey:38
Summary: games-strategy/0ad-0.0.23b_alpha: allow using system library dev-lang/spiderm...
Status: RESOLVED CANTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Deadline: 2020-10-09
Assignee: Gentoo Games
URL:
Whiteboard:
Keywords: PATCH, PMASKED
Depends on:
Blocks:
 
Reported: 2019-07-02 01:16 UTC by Samuel Bauer
Modified: 2021-02-12 20:19 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
0ad-system_mozjs.patch (0ad.ebuild.patch,1.74 KB, patch)
2019-07-02 01:16 UTC, Samuel Bauer
Details | Diff
0ad-mandatory-system-mozjs.patch (0ad.ebuild.2.patch,1.06 KB, patch)
2019-07-02 01:24 UTC, Samuel Bauer
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Samuel Bauer 2019-07-02 01:16:46 UTC
Created attachment 581740 [details, diff]
0ad-system_mozjs.patch

This patch allows compiling and running 0ad with "system" spidermonkey.
Rather than a mandatory unbundling, it is done via a flag.
Comment 1 Samuel Bauer 2019-07-02 01:24:03 UTC
Created attachment 581742 [details, diff]
0ad-mandatory-system-mozjs.patch

A mandatory alternative to the previous patch
Comment 2 Larry the Git Cow gentoo-dev 2021-02-12 20:18:54 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=815ab784f5f549e0f4cb803bbd813199d2c94c90

commit 815ab784f5f549e0f4cb803bbd813199d2c94c90
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2021-02-12 20:18:08 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2021-02-12 20:18:47 +0000

    games-strategy/0ad: revert to bundled libraries
    
    * SpiderMonkey changes the consumed interfaces
      even within minor versions, so using
      the system version is a no go.
    
    * nvtt is abandoned upstream and using the
      system version results in segfaults.
    
      Use 0ad's version which has fixes instead.
    
    Bug: https://bugs.gentoo.org/735352
    Bug: https://bugs.gentoo.org/689124
    Closes: https://bugs.gentoo.org/768840
    Closes: https://bugs.gentoo.org/759934
    Closes: https://bugs.gentoo.org/768930
    Package-Manager: Portage-3.0.14, Repoman-3.0.2
    Signed-off-by: Sam James <sam@gentoo.org>

 ...> 0ad-0.0.24_alpha_pre20210116040036-r1.ebuild} | 28 ++++++++++++++++++----
 1 file changed, 23 insertions(+), 5 deletions(-)
Comment 3 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2021-02-12 20:19:24 UTC
I'm sorry, I don't think we can do this with :78 for now (see the commit message).