Bug 688778 – net-dns/dnsmasq-2.80 with dev-libs/nettle-3.5: nettle_secp_256r1 undeclared

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Craig Andrews 2019-06-26 20:17:50 UTC]

Created attachment 581118 [details]
build.log

crypto.c: In function ‘dnsmasq_ecdsa_verify’:
crypto.c:297:36: error: ‘nettle_secp_256r1’ undeclared (first use in this function); did you mean ‘nettle_get_secp_256r1’?
  297 |    nettle_ecc_point_init(key_256, &nettle_secp_256r1);
      |                                    ^~~~~~~~~~~~~~~~~
      |                                    nettle_get_secp_256r1
crypto.c:297:36: note: each undeclared identifier is reported only once for each function it appears in
crypto.c:310:36: error: ‘nettle_secp_384r1’ undeclared (first use in this function); did you mean ‘nettle_get_secp_384r1’?
  310 |    nettle_ecc_point_init(key_384, &nettle_secp_384r1);
      |                                    ^~~~~~~~~~~~~~~~~
      |                                    nettle_get_secp_384r1
make[1]: *** [/var/tmp/portage/net-dns/dnsmasq-2.80/work/dnsmasq-2.80/Makefile:161: crypto.o] Error 1
make[1]: Leaving directory '/var/tmp/portage/net-dns/dnsmasq-2.80/work/dnsmasq-2.80/src'
make: *** [Makefile:110: all-i18n] Error 2

[Comment 1 Craig Andrews 2019-06-26 20:23:52 UTC]

Here's the issue discussed on the mailing list:
http://lists.thekelleys.org.uk/pipermail/dnsmasq-discuss/2019q2/013095.html

And a patch:
https://github.com/themiron/dnsmasq/commit/6fd9aba7abe1e084123bc5002959350897774ace from http://lists.thekelleys.org.uk/pipermail/dnsmasq-discuss/2019q2/013096.html

[Comment 2 Jeff Kowalczyk 2019-07-01 19:03:56 UTC]

Created attachment 581724 [details, diff]
dnsmasq-2.80.ebuild applying patch nettle-3.5.patch

[Comment 3 Jeff Kowalczyk 2019-07-01 19:04:37 UTC]

Created attachment 581726 [details, diff]
nettle-3.5.patch to allow build of net-dns/dnsmasq-3.80

[Comment 4 Jeff Kowalczyk 2019-07-01 19:05:44 UTC]

Created attachment 581728 [details]
net-dns/dnsmasq-3.80.ebuild patched to apply nettle-3.5.patch

[Comment 5 Jeff Kowalczyk 2019-07-01 19:07:35 UTC]

Supplied patch is the same pointed to by Craig:
https://github.com/themiron/dnsmasq/commit/6fd9aba7abe1e084123bc5002959350897774ace from http://lists.thekelleys.org.uk/pipermail/dnsmasq-discuss/2019q2/013096.html

[Comment 6 Craig Andrews 2019-07-01 19:13:23 UTC]

(In reply to Jeff Kowalczyk from comment #5)
> Supplied patch is the same pointed to by Craig:
> https://github.com/themiron/dnsmasq/commit/
> 6fd9aba7abe1e084123bc5002959350897774ace from
> http://lists.thekelleys.org.uk/pipermail/dnsmasq-discuss/2019q2/013096.html

I provided this in a PR a few days ago :)
https://github.com/gentoo/gentoo/pull/12342

[Comment 7 Larry the Git Cow 2019-07-03 21:36:55 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=232e5f1c871dffeddf6dce91d803a4e8354c0b9c

commit 232e5f1c871dffeddf6dce91d803a4e8354c0b9c
Author:     Craig Andrews <[e-mail]>
AuthorDate: 2019-06-27 16:32:12 +0000
Commit:     Patrick McLean <[e-mail]>
CommitDate: 2019-07-03 21:35:59 +0000

    net-dns/dnsmasq: Compatibility with dev-libs/nettle-3.5
    
    Closes: https://bugs.gentoo.org/688778
    Package-Manager: Portage-2.3.67, Repoman-2.3.16
    Signed-off-by: Craig Andrews <[e-mail]>
    Closes: https://github.com/gentoo/gentoo/pull/12342
    Signed-off-by: Patrick McLean <[e-mail]>

 net-dns/dnsmasq/dnsmasq-2.80-r1.ebuild             | 213 +++++++++++++++++++++
 .../dnsmasq/files/dnsmasq-2.80-nettle-3.5.patch    |  42 ++++
 2 files changed, 255 insertions(+)