Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 688516 - [kde overlay] kde-apps/gwenview-9999 USE=-share commit 6d2ad4860 broken
Summary: [kde overlay] kde-apps/gwenview-9999 USE=-share commit 6d2ad4860 broken
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Overlays (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Linux bug wranglers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-06-22 22:58 UTC by Duncan
Modified: 2019-06-23 07:58 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
build log (kde-apps:gwenview-9999:20190622-222728.log,6.31 KB, text/x-log)
2019-06-22 22:58 UTC, Duncan
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Duncan 2019-06-22 22:58:06 UTC
Created attachment 580472 [details]
build log

KDE overlay commit 6d2ad4860 added USE=share to kde-apps/gwenview, conditionally pulling in kde-frameworks/purpose.

But the mentioned gwenview upstream commit, d20a1533d, put purpose under REQUIRED COMPONENTS, not optional (relevant chunk):

diff --git a/CMakeLists.txt b/CMakeLists.txt
index bc61c9684..63d364f32 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -68,6 +68,7 @@ find_package(KF5 ${KF5_MIN_VERSION} REQUIRED COMPONENTS
WindowSystem
IconThemes
Notifications
+    Purpose
)
find_package(KF5 ${KF5_MIN_VERSION} OPTIONAL_COMPONENTS
Activities

And gentoo/kde's commit doesn't seem to patch that to optional (unless of course required doesn't actually mean required...).

So with USE=-share (and without purpose framework installed) I get an error:

-- Could NOT find KF5Purpose: found neither KF5PurposeConfig.cmake nor kf5purpose-config.cmake 
CMake Error at /share/cmake/Modules/FindPackageHandleStandardArgs.cmake:137 (message):
Could NOT find KF5 (missing: Purpose) (found suitable version "5.60.0",
minimum required is "5.43.0")
Call Stack (most recent call first):
/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:378 (_FPHSA_FAILURE_MESSAGE)
//share/ECM/find-modules/FindKF5.cmake:110 (find_package_handle_standard_args)
CMakeLists.txt:62 (find_package)
-- Configuring incomplete, errors occurred!
See also "/tmp/portage/kde-apps/gwenview-9999/work/gwenview-9999_build/CMakeFiles/CMakeOutput.log".
* ERROR: kde-apps/gwenview-9999::kde failed (configure phase):
*   cmake failed

While with USE=share (and purpose installed), the build configures fine (but still fails in compile due to an apparent upstream bug, undeclared mShareAction, seems they've already committed one fix to the new purpose/share related code since d20a1533d, but there's more needed).

Note that I do apply one old user patch that changes the zoomstep, but it's unrelated and has been working for "ages", since upstream changed the zoomstep several years ago and I used the commit to generate a patch of my own.
Comment 1 Larry the Git Cow gentoo-dev 2019-06-23 07:58:53 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/proj/kde.git/commit/?id=29edcc4353a71544d1dff19cfcbb6a7d253de6d6

commit 29edcc4353a71544d1dff19cfcbb6a7d253de6d6
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2019-06-23 07:58:32 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2019-06-23 07:58:32 +0000

    kde-apps/gwenview: kde-frameworks/purpose is indeed not optional
    
    Reported-by: Duncan <1i5t5.duncan@cox.net>
    Closes: https://bugs.gentoo.org/688516
    Package-Manager: Portage-2.3.67, Repoman-2.3.15
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 kde-apps/gwenview/gwenview-9999.ebuild | 5 ++---
 kde-apps/gwenview/metadata.xml         | 1 -
 2 files changed, 2 insertions(+), 4 deletions(-)