Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 688448 - dev-lang/spidermonkey-52.9.1_pre1 fails to compile with gcc-9.1.0
Summary: dev-lang/spidermonkey-52.9.1_pre1 fails to compile with gcc-9.1.0
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Mozilla Gentoo Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-06-21 17:30 UTC by Evan Teran
Modified: 2019-07-25 15:37 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
build log (build.log.gz,153.25 KB, application/gzip)
2019-06-21 17:30 UTC, Evan Teran
Details
gcc-9 overflow fix (0001-gcc-9-overflow-fix.patch,821 bytes, patch)
2019-07-25 15:12 UTC, Jory A. Pratt
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Evan Teran 2019-06-21 17:30:12 UTC
Created attachment 580312 [details]
build log

dev-lang/spidermonkey-52.9.1_pre1 fails to compile with gcc-9.1.0. The issue appears to be the following:

In member function 'void js::jit::X86Encoding::BaseAssemblerX64::movq_mr(int32_t, js::jit::X86Encoding::RegisterID, js::jit::X86Encoding::RegisterID, int, js::jit::X86Encoding::RegisterID)',
    inlined from 'void js::jit::Assembler::movq(const js::jit::Operand&, js::jit::Register)' at /var/tmp/portage/dev-lang/spidermonkey-52.9.1_pre1/work/mozjs-52.9.1pre1/js/src/jit/x64/Assembler-x64.h:397:25:
/var/tmp/portage/dev-lang/spidermonkey-52.9.1_pre1/work/mozjs-52.9.1pre1/js/src/jit/x64/BaseAssembler-x64.h:596:13: error: '%s' directive argument is null [-Werror=format-overflow=]
  596 |         spew("movq       " MEM_obs ", %s", ADDR_obs(offset, base, index, scale), GPReg64Name(dst));



In member function 'void js::jit::X86Encoding::BaseAssemblerX64::movq_mr(int32_t, js::jit::X86Encoding::RegisterID, js::jit::X86Encoding::RegisterID, int, js::jit::X86Encoding::RegisterID)',
    inlined from 'void js::jit::Assembler::movq(const js::jit::Operand&, js::jit::Register)' at /var/tmp/portage/dev-lang/spidermonkey-52.9.1_pre1/work/mozjs-52.9.1pre1/js/src/jit/x64/Assembler-x64.h:397:25:
/var/tmp/portage/dev-lang/spidermonkey-52.9.1_pre1/work/mozjs-52.9.1pre1/js/src/jit/x64/BaseAssembler-x64.h:596:13: error: '%s' directive argument is null [-Werror=format-overflow=]
  596 |         spew("movq       " MEM_obs ", %s", ADDR_obs(offset, base, index, scale), GPReg64Name(dst));


In member function 'void js::jit::X86Encoding::BaseAssemblerX64::movq_mr(int32_t, js::jit::X86Encoding::RegisterID, js::jit::X86Encoding::RegisterID, int, js::jit::X86Encoding::RegisterID)',
    inlined from 'void js::jit::Assembler::movq(const js::jit::Operand&, js::jit::Register)' at /var/tmp/portage/dev-lang/spidermonkey-52.9.1_pre1/work/mozjs-52.9.1pre1/js/src/jit/x64/Assembler-x64.h:397:25:
/var/tmp/portage/dev-lang/spidermonkey-52.9.1_pre1/work/mozjs-52.9.1pre1/js/src/jit/x64/BaseAssembler-x64.h:596:13: error: '%s' directive argument is null [-Werror=format-overflow=]
  596 |         spew("movq       " MEM_obs ", %s", ADDR_obs(offset, base, index, scale), GPReg64Name(dst));
Comment 1 Jory A. Pratt gentoo-dev 2019-06-22 04:28:09 UTC
emerge --info spidermonkey, we do not support mixing stable with testing. Patches are welcomed and will be applied if they are properly created via git diff with a signed off line.
Comment 2 Evan Teran 2019-06-24 14:22:28 UTC
I was thinking that it would need to be added to the gcc-9 porting tracker.

https://bugs.gentoo.org/show_bug.cgi?id=gcc-9
Comment 3 Evan Teran 2019-06-24 14:23:19 UTC
# emerge --info spidermonkey
Portage 2.3.66 (python 3.6.5-final-0, default/linux/amd64/17.1/desktop, gcc-9.1.0, glibc-2.29-r2, 5.1.9-gentoo x86_64)
=================================================================
                         System Settings
=================================================================
System uname: Linux-5.1.9-gentoo-x86_64-Intel-R-_Core-TM-_i7-8750H_CPU_@_2.20GHz-with-gentoo-2.6
KiB Mem:    32586332 total,  26926252 free
KiB Swap:   33554428 total,  33554428 free
Timestamp of repository gentoo: Mon, 24 Jun 2019 14:00:01 +0000
Head commit of repository gentoo: 6b96296c587c1909b642b0d22a33e3060776e45e
sh bash 4.4_p23-r1
ld GNU ld (Gentoo 2.31.1 p7) 2.31.1
ccache version 3.6 [disabled]
app-shells/bash:          4.4_p23-r1::gentoo
dev-java/java-config:     2.2.0-r4::gentoo
dev-lang/perl:            5.28.2-r1::gentoo
dev-lang/python:          2.7.15::gentoo, 3.6.5::gentoo
dev-util/ccache:          3.6::gentoo
dev-util/cmake:           3.14.3::gentoo
dev-util/pkgconfig:       0.29.2::gentoo
sys-apps/baselayout:      2.6-r1::gentoo
sys-apps/openrc:          0.41.2::gentoo
sys-apps/sandbox:         2.13::gentoo
sys-devel/autoconf:       2.13-r1::gentoo, 2.69-r4::gentoo
sys-devel/automake:       1.11.6-r3::gentoo, 1.16.1-r1::gentoo
sys-devel/binutils:       2.31.1-r6::gentoo
sys-devel/gcc:            8.3.0-r1::gentoo, 9.1.0-r1::gentoo
sys-devel/gcc-config:     2.0::gentoo
sys-devel/libtool:        2.4.6-r3::gentoo
sys-devel/make:           4.2.1-r4::gentoo
sys-kernel/linux-headers: 5.1::gentoo (virtual/os-headers)
sys-libs/glibc:           2.29-r2::gentoo
Repositories:

gentoo
    location: /usr/portage
    sync-type: rsync
    sync-uri: rsync://rsync.gentoo.org/gentoo-portage
    priority: -1000
    sync-rsync-verify-metamanifest: yes
    sync-rsync-extra-opts: 
    sync-rsync-verify-jobs: 1
    sync-rsync-verify-max-age: 24

gentoo-overlay
    location: /home/eteran/projects/gentoo-overlay
    masters: gentoo
    priority: 0

eclipse
    location: /var/lib/layman/eclipse
    masters: gentoo
    priority: 50

ACCEPT_KEYWORDS="amd64"
ACCEPT_LICENSE="*"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-march=skylake -O2 -finline-functions -ftree-vectorize -fipa-cp-clone -pipe -ggdb"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/config /usr/share/gnupg/qualified.txt /usr/share/maven-bin-3.6/conf"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo"
CXXFLAGS="-march=skylake -O2 -finline-functions -ftree-vectorize -fipa-cp-clone -pipe -ggdb"
DISTDIR="/usr/portage/distfiles"
EMERGE_DEFAULT_OPTS="--with-bdeps=y --exclude=sys-kernel/gentoo-sources"
ENV_UNSET="DBUS_SESSION_BUS_ADDRESS DISPLAY GOBIN PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR"
FCFLAGS="-march=skylake -O2 -finline-functions -ftree-vectorize -fipa-cp-clone -pipe -ggdb"
FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs collision-protect compressdebug config-protect-if-modified distlocks ebuild-locks fixlafiles ipc-sandbox merge-sync multilib-strict network-sandbox news parallel-fetch pid-sandbox preserve-libs protect-owned sandbox sfperms splitdebug strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS="-march=skylake -O2 -finline-functions -ftree-vectorize -fipa-cp-clone -pipe -ggdb"
GENTOO_MIRRORS="http://distfiles.gentoo.org"
LANG="en_US.utf8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
PKGDIR="/usr/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/var/tmp"
USE="X a52 aac acl acpi alsa alsa-plugin amd64 apache2 autotools berkdb binary-drivers bluetooth branding bzip2 cairo cdda cgroups clang clangcodemodel clangstaticanalyzer cli cmake consolekit cppcheck crypt cups cxx dbus display-manager dns dri dri3 dts dvd dvdr elfutils emboss encode exif fam farstream ffmpeg flac fontconfig fortran frei0r fuse gdbm gif git glamor gpm graph grub gstreamer iconv icu inotify inspector ipv6 javafx jpeg json jumbo-build kde kdenlive lapack lcms ldap libnotify libtirpc llvm lm_sensors logrotate lz4 lzma mad melt minizip mng mp3 mp4 mpeg multilib mysql mysqli ncurses networkmanager nls nptl ogg opengl openmp otr pam pango pcre pdf php pm-utils png policykit postproc ppds pulseaudio python qt5 readline samba scripttools sdl seccomp sodium spell sqlite ssl startup-notification svg tcpd theora tiff tools truetype udev udisks unicode upower usb uuid v4l valgrind vorbis wallpapers widgets wifi wireless wxwidgets x264 xattr xcb xml xv xvid zenmap zeroconf zip zlib" ABI_X86="64" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="karbon sheets words" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="mmx mmxext sse sse2 aes avx avx2 f16c fma3 pclmul popcnt sse3 sse4_1 sse4_2 ssse3" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="evdev wacom keyboard mouse libinput synaptics" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" NETBEANS_MODULES="apisupport cnd groovy gsf harness ide identity j2ee java mobility nb php profiler soa visualweb webcommon websvccommon xml" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php7-2" POSTGRES_TARGETS="postgres10 postgres11" PYTHON_SINGLE_TARGET="python3_6" PYTHON_TARGETS="python2_7 python3_6" QEMU_SOFTMMU_TARGETS="arm x86_64 mips" QEMU_USER_TARGETS="arm x86_64 mips" RUBY_TARGETS="ruby24" USERLAND="GNU" VIDEO_CARDS="intel i965 nvidia" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CC, CPPFLAGS, CTARGET, CXX, INSTALL_MASK, LC_ALL, LINGUAS, MAKEOPTS, PORTAGE_BINHOST, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS

=================================================================
                        Package Settings
=================================================================

dev-lang/spidermonkey-52.9.1_pre1::gentoo was built with the following:
USE="system-icu -custom-cflags -custom-optimization -debug -minimal -test" ABI_X86="(64)"
Comment 4 tt_1 2019-07-05 16:01:04 UTC
If you need the old spidermonkey-52 for a reason, you can have a look at what the people from arch have done to fix this:

https://aur.archlinux.org/packages/firefox-esr52/
Comment 5 Jory A. Pratt gentoo-dev 2019-07-25 15:12:54 UTC
Created attachment 584474 [details, diff]
gcc-9 overflow fix

Feel free to test, spidermonkey:60 is stable on most archs and being worked on to stabilize on the remainder. If you absolutely need 52 please patch it locally and I will add the patch to tree soon as i have time.
Comment 6 Larry the Git Cow gentoo-dev 2019-07-25 15:37:23 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e93d86a969ee2957a2805450c008599521689cf6

commit e93d86a969ee2957a2805450c008599521689cf6
Author:     Jory Pratt <anarchy@gentoo.org>
AuthorDate: 2019-07-25 15:36:58 +0000
Commit:     Jory Pratt <anarchy@gentoo.org>
CommitDate: 2019-07-25 15:37:12 +0000

    dev-lang/spidermonkey: Fix gcc-9 support in :52
    
    Closes: https://bugs.gentoo.org/688448
    Package-Manager: Portage-2.3.69, Repoman-2.3.16
    Signed-off-by: Jory Pratt <anarchy@gentoo.org>

 .../files/spidermonkey-52.0-gcc9-overflow.patch    | 24 ++++++++++++++++++++++
 .../spidermonkey/spidermonkey-52.9.1_pre1.ebuild   |  1 +
 2 files changed, 25 insertions(+)