Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 688126 - dev-util/vulkan-tools should have RDEPEND
Summary: dev-util/vulkan-tools should have RDEPEND
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: Normal normal
Assignee: Nick Sarnie
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-06-15 19:56 UTC by Arfrever Frehtes Taifersar Arahesis
Modified: 2019-06-15 23:20 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Arfrever Frehtes Taifersar Arahesis 2019-06-15 19:56:07 UTC
All ebuilds of dev-util/vulkan-tools set only DEPEND, not RDEPEND.

Run-time linking for dev-util/vulkan-tools-1.1.106[X,cube,vulkaninfo,wayland]:

# scanelf -qyF "%F: %n" $(qlist dev-util/vulkan-tools | sort)
/usr/bin/x86_64-pc-linux-gnu-vkcube: libxcb.so.1,libm.so.6,libvulkan.so.1,librt.so.1,libc.so.6
/usr/bin/x86_64-pc-linux-gnu-vkcubepp: libxcb.so.1,libvulkan.so.1,libstdc++.so.6,libm.so.6,libgcc_s.so.1,libc.so.6
/usr/bin/x86_64-pc-linux-gnu-vulkaninfo: libxcb.so.1,libX11.so.6,libwayland-client.so.0,libvulkan.so.1,libc.so.6


This means that the following dependencies should be also in RDEPEND:
  dev-libs/wayland          (libwayland-client.so.0)
  media-libs/vulkan-loader  (libvulkan.so.1)
  x11-libs/libX11           (libX11.so.6)
  x11-libs/libxcb           (libxcb.so.1)


If ebuild was updated to use EAPI="7", then dependency on dev-util/glslang should be in BDEPEND only (for /usr/bin/glslangValidator executable which is called by build system).


I do not yet know how x11-libs/libXrandr is used... Build system seems to define VK_USE_PLATFORM_XLIB_XRANDR_EXT, but no headers/libraries from x11-libs/libXrandr seem to be directly used. (No dlopen() used.)
Comment 1 Larry the Git Cow gentoo-dev 2019-06-15 21:43:52 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0ec0e6c8507f3015935e9cb8b1a99eba4cf73d4c

commit 0ec0e6c8507f3015935e9cb8b1a99eba4cf73d4c
Author:     Nick Sarnie <sarnex@gentoo.org>
AuthorDate: 2019-06-15 21:32:27 +0000
Commit:     Nick Sarnie <sarnex@gentoo.org>
CommitDate: 2019-06-15 21:43:22 +0000

    dev-util/vulkan-tools: Fix dependencies
    
    Fixes: https://bugs.gentoo.org/688126
    Package-Manager: Portage-2.3.67, Repoman-2.3.14
    Signed-off-by: Nick Sarnie <sarnex@gentoo.org>

 .../vulkan-tools/vulkan-tools-1.1.106-r1.ebuild    | 93 ++++++++++++++++++++++
 dev-util/vulkan-tools/vulkan-tools-9999.ebuild     | 15 ++--
 2 files changed, 101 insertions(+), 7 deletions(-)
Comment 2 Arfrever Frehtes Taifersar Arahesis 2019-06-15 23:16:08 UTC
${PYTHON_DEPS} should be moved from DEPEND to BDEPEND:

-BDEPEND="cube? ( dev-util/glslang:=[${MULTILIB_USEDEP}] )"
-DEPEND="${PYTHON_DEPS}
-       ${COMMON_DEPEND}"
+BDEPEND="${PYTHON_DEPS}
+       cube? ( dev-util/glslang:=[${MULTILIB_USEDEP}] )"
+DEPEND="${COMMON_DEPEND}"
 RDEPEND="${COMMON_DEPEND}"
Comment 3 Larry the Git Cow gentoo-dev 2019-06-15 23:20:14 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ec4043a0128114fdf0a00c8ad6fa2dae850039cf

commit ec4043a0128114fdf0a00c8ad6fa2dae850039cf
Author:     Nick Sarnie <sarnex@gentoo.org>
AuthorDate: 2019-06-15 23:19:05 +0000
Commit:     Nick Sarnie <sarnex@gentoo.org>
CommitDate: 2019-06-15 23:19:05 +0000

    dev-util/vulkan-tools: Move python to build deps
    
    Based on idea from Arfrever Frehtes Taifersar Arahesis <arfrever.fta@gmail.com>
    
    Bug: https://bugs.gentoo.org/688126
    Package-Manager: Portage-2.3.67, Repoman-2.3.14
    Signed-off-by: Nick Sarnie <sarnex@gentoo.org>

 dev-util/vulkan-tools/vulkan-tools-1.1.106-r1.ebuild | 6 +++---
 dev-util/vulkan-tools/vulkan-tools-9999.ebuild       | 6 +++---
 2 files changed, 6 insertions(+), 6 deletions(-)