Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 688024 - net-p2p/deluge-2.0.3 version bump
Summary: net-p2p/deluge-2.0.3 version bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal with 1 vote (vote)
Assignee: Paolo Pedroni
URL: https://deluge.readthedocs.io/en/late...
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2019-06-13 20:30 UTC by Diogo Pereira
Modified: 2019-10-16 20:04 UTC (History)
14 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Ebuild for deluge-2.0.3 (deluge-2.0.3.ebuild,4.25 KB, text/plain)
2019-06-16 13:26 UTC, thulle
Details

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Jonas Stein gentoo-dev 2019-06-13 21:19:32 UTC
Thank you for the bump request, but please wait at least 48h next time. 
https://wiki.gentoo.org/wiki/Zero-day_bump_requests
Comment 2 thulle 2019-06-16 09:42:35 UTC
> Thank you for the bump request, but please wait at least 48h next time. 
> https://wiki.gentoo.org/wiki/Zero-day_bump_requests

At the time of posting it had been a week since the release of the incompatible deluge 2.0-series.
Comment 3 thulle 2019-06-16 13:26:52 UTC
Created attachment 579898 [details]
Ebuild for deluge-2.0.3

Started with an old ebuild, after removing an old patch and updating dependencies i got it running with this resulting ebuild. Only tested with local and with thin client.
Comment 4 Alexander Kurakin 2019-06-18 07:32:47 UTC
> PYTHON_COMPAT=( python2_7 )

but

> Ported to Python 3

Is it Python 2.7- or 3.x-compatible?
Comment 5 Joël 2019-06-30 16:29:15 UTC
Thank you for the package! Has anyone tried it yet? Is it a smooth upgrade (ie: are settings, labels and file states preserved)?

As for the Python 2.x dependency, it looks incorrect to me - but I haven't tried the package yet.
Comment 6 thulle 2019-06-30 16:36:56 UTC
(In reply to Alexander Kurakin from comment #4)
> > PYTHON_COMPAT=( python2_7 )
> 
> but
> 
> > Ported to Python 3
> 
> Is it Python 2.7- or 3.x-compatible?

"Migrated to Python 3 with minimal support retained for Python 2.7."



(In reply to Joël from comment #5)
> Thank you for the package! Has anyone tried it yet? Is it a smooth upgrade
> (ie: are settings, labels and file states preserved)?
> 
> As for the Python 2.x dependency, it looks incorrect to me - but I haven't
> tried the package yet.

I'm running it on python 2.7. I took the shortest route possible to a running program and haven't tried changing dependencies to 3.x. Please report the results if you do.
I had no labels, but settings and filestates migrated fine. Plugins stop working since they're incompatible between 1.x and 2.0. The builtin extractor works fine, so no external plugin needed for that anymore.
Comment 7 Alexander Kurakin 2019-06-30 16:49:03 UTC
(In reply to thulle from comment #6)
> "Migrated to Python 3 with minimal support retained for Python 2.7."
> 
> I'm running it on python 2.7. I took the shortest route possible to a
> running program and haven't tried changing dependencies to 3.x.

IMHO we have to have two options: for Python 2.7 systems and for Python 3.x. Right? (I mean I don't know Gentoo rules about this.)
Comment 8 thulle 2019-06-30 17:01:03 UTC
(In reply to Alexander Kurakin from comment #7)
> (In reply to thulle from comment #6)
> > "Migrated to Python 3 with minimal support retained for Python 2.7."
> > 
> > I'm running it on python 2.7. I took the shortest route possible to a
> > running program and haven't tried changing dependencies to 3.x.
> 
> IMHO we have to have two options: for Python 2.7 systems and for Python 3.x.
> Right? (I mean I don't know Gentoo rules about this.)

Yes, read my comment as "changing dependencies to allow it to run on 3.x". 
I just did the minimal work necessary to be able to control deluged 2.x on a remote host.
Comment 9 Andreas Sturmlechner gentoo-dev 2019-07-01 06:58:47 UTC
Key changes:

> Migrated to Python 3 with minimal support retained for Python 2.7.
> GTK UI migrated to GTK3 with UI improvements and additions.
> Fully support libtorrent 1.2 release.
The attached ebuild falls short on all of them.
Comment 10 Paolo Pedroni 2019-07-01 12:53:25 UTC
I'll take a look at everything and I hope I can have something working for the end of next week at the latest.

Thanks for everyone's patience.
Comment 11 Joël 2019-07-06 16:58:29 UTC
Sounds great, thanks Paolo! :-)
Comment 12 Paolo Pedroni 2019-07-17 09:55:53 UTC
(In reply to Paolo Pedroni from comment #10)
> I'll take a look at everything and I hope I can have something working for
> the end of next week at the latest.
> 
> Thanks for everyone's patience.

I've been delayed by an unexpected bereavement.

Please be patient, I expect to complete this task in a week or so.
Comment 13 Joël 2019-07-17 11:38:42 UTC
My sincere condolences Paolo.
Regarding the ebuild - no rush - I'll be happy to try it out once you're ready.
Comment 14 Ștefan Talpalaru 2019-07-25 19:12:38 UTC
A working ebuild is available in my overlay: https://github.com/stefantalpalaru/gentoo-overlay

Tested with Python 2.7 and 3.6, libtorrent-rasterbar 1.1.13 and 1.2.1 (found a bug in the latter library's ebuild, in the process: https://bugs.gentoo.org/690726).
Comment 15 Paolo Pedroni 2019-07-26 13:42:57 UTC
Please note that I'm leaving for a three weeks holiday tomorrow. I'll have limited connectivity while I'm away, I'll take care of any issue as soon as I'm back.
Comment 16 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2019-10-05 09:53:10 UTC
Ping.
Comment 17 Larry the Git Cow gentoo-dev 2019-10-11 15:07:16 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0636a6c1baa2467b6642ea60227ba5af62388bb0

commit 0636a6c1baa2467b6642ea60227ba5af62388bb0
Author:     Craig Andrews <candrews@gentoo.org>
AuthorDate: 2019-10-09 20:52:51 +0000
Commit:     Craig Andrews <candrews@gentoo.org>
CommitDate: 2019-10-11 15:07:09 +0000

    net-p2p/deluge: 2.0.3 version bump
    
    Closes: https://bugs.gentoo.org/688024
    Closes: https://github.com/gentoo/gentoo/pull/12548
    Closes: https://github.com/gentoo/gentoo/pull/9327
    Closes: https://github.com/gentoo/gentoo/pull/13243
    Package-Manager: Portage-2.3.76, Repoman-2.3.17
    Signed-off-by: Craig Andrews <candrews@gentoo.org>

 net-p2p/deluge/Manifest                           |   1 +
 net-p2p/deluge/deluge-2.0.3.ebuild                | 133 ++++++++++++++++++++++
 net-p2p/deluge/deluge-9999.ebuild                 |  56 ++++-----
 net-p2p/deluge/files/deluge-2.0.3-UI-status.patch |  31 +++++
 net-p2p/deluge/files/deluge-2.0.3-setup.py.patch  |  11 ++
 net-p2p/deluge/metadata.xml                       |   4 +
 6 files changed, 205 insertions(+), 31 deletions(-)
Comment 18 Gerald 2019-10-14 19:54:51 UTC
New version does not start for me - "ModuleNotFoundError: No module named 'deluge.libtorrent'"

I've tried reemerging libtorrent-rasterbar, didn't help. emerge @preserved-rebuild also didn't help. Python 3.6 is the selected version with 2.7 as fallback.

Log output:
Oct 14 21:49:46 tux systemd[1]: Started Deluge BitTorrent client.
Oct 14 21:49:46 tux deluged[471]: Traceback (most recent call last):
Oct 14 21:49:46 tux deluged[471]:   File "/usr/lib64/python3.6/site-packages/deluge/_libtorrent.py", line 23, in <module>
Oct 14 21:49:46 tux deluged[471]:     import deluge.libtorrent as lt
Oct 14 21:49:46 tux deluged[471]: ModuleNotFoundError: No module named 'deluge.libtorrent'
Oct 14 21:49:46 tux deluged[471]: During handling of the above exception, another exception occurred:
Oct 14 21:49:46 tux deluged[471]: Traceback (most recent call last):
Oct 14 21:49:46 tux deluged[471]:   File "/usr/bin/deluged", line 11, in <module>
Oct 14 21:49:46 tux deluged[471]:     load_entry_point('deluge==2.0.3', 'console_scripts', 'deluged')()
Oct 14 21:49:46 tux deluged[471]:   File "/usr/lib64/python3.6/site-packages/deluge/core/daemon_entry.py", line 90, in start_daemon
Oct 14 21:49:46 tux deluged[471]:     from deluge.core.daemon import is_daemon_running
Oct 14 21:49:46 tux deluged[471]:   File "/usr/lib64/python3.6/site-packages/deluge/core/daemon.py", line 22, in <module>
Oct 14 21:49:46 tux deluged[471]:     from deluge.core.core import Core
Oct 14 21:49:46 tux deluged[471]:   File "/usr/lib64/python3.6/site-packages/deluge/core/core.py", line 28, in <module>
Oct 14 21:49:46 tux deluged[471]:     from deluge._libtorrent import LT_VERSION, lt
Oct 14 21:49:46 tux deluged[471]:   File "/usr/lib64/python3.6/site-packages/deluge/_libtorrent.py", line 25, in <module>
Oct 14 21:49:46 tux deluged[471]:     import libtorrent as lt
Oct 14 21:49:46 tux deluged[471]: ImportError: /usr/lib64/python3.6/site-packages/libtorrent.cpython-36m-x86_64-linux-gnu.so: undefined symbol: _ZN5boost6python6detail11init_moduleER11PyModuleDefPFvvE
Oct 14 21:49:46 tux systemd[1]: deluged.service: Main process exited, code=exited, status=1/FAILURE
Oct 14 21:49:46 tux systemd[1]: deluged.service: Failed with result 'exit-code'.
Comment 19 Gerald 2019-10-15 02:06:55 UTC
Update regarding my "ModuleNotFoundError: No module named 'deluge.libtorrent'" Problem.

I think it was the version of dev-util/boost-build or of dev-libs/boost. After upgrading those from stable 1.65 to the latest ~amd64 unstable 1.71 it finally started working. I guess this ebuild should have a >= version requirement for those, but not quite sure what minimum version is necessary.
Comment 20 Alexander Kurakin 2019-10-16 20:04:23 UTC
(In reply to Gerald from comment #19)
> Update regarding my "ModuleNotFoundError: No module named
> 'deluge.libtorrent'" Problem.
> 
> I think it was the version of dev-util/boost-build or of dev-libs/boost.
> After upgrading those from stable 1.65 to the latest ~amd64 unstable 1.71 it
> finally started working. I guess this ebuild should have a >= version
> requirement for those, but not quite sure what minimum version is necessary.

Open a new bug, please?