Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 687972 - mail-filter/opendkim: clean up automatically-enabled configure flags
Summary: mail-filter/opendkim: clean up automatically-enabled configure flags
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Ralph Seichter
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2019-06-12 23:37 UTC by Michael Orlitzky
Modified: 2019-07-04 01:55 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Orlitzky gentoo-dev 2019-06-12 23:37:20 UTC
While investigating bug 684958, I noticed that there are three unrelated flags enabled with USE=berkdb,

  if use berkdb ; then
   ...
      --enable-popauth
      --enable-query_cache
      --enable-stats

As I reported on that bug,

  * It looks like popauth and query_cache do need BerkeleyDB.
  * POP-before-SMTP (popauth) is obsolete anyway, and can likely be removed.
  * The statistics can use any database, not just a BerkeleyDB.

So, for a rainy day:

  * Drop the --enable-popauth entirely.
  * Add a local USE flag that enables the query cache.
  * Add a local USE flag "stats" that depends on some database being present
    (see how mail-filter/spamassassin does this).
Comment 1 Larry the Git Cow gentoo-dev 2019-06-14 13:39:40 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=52b8aa248f2d4dd8e6c55bd1b710535e5806b66f

commit 52b8aa248f2d4dd8e6c55bd1b710535e5806b66f
Author:     Michael Orlitzky <mjo@gentoo.org>
AuthorDate: 2019-06-14 13:32:58 +0000
Commit:     Michael Orlitzky <mjo@gentoo.org>
CommitDate: 2019-06-14 13:38:35 +0000

    mail-filter/opendkim: drop --enable-popauth flag.
    
    The "--enable-popauth" flag was enabled automatically when USE=berkdb
    was set, which already doesn't make any sense. This was noticed while
    investigating bug 684958. However, "popauth" refers to POP-before-SMTP,
    which is an outdated and altogether ridiculous way of authenticating.
    No one competent has used it since the 1990s. Instead of converting it
    to an independent local USE flag, this new -r15 just drops it.
    
    Bug: https://bugs.gentoo.org/687972
    Signed-off-by: Michael Orlitzky <mjo@gentoo.org>
    Package-Manager: Portage-2.3.66, Repoman-2.3.11

 .../opendkim/{opendkim-2.10.3-r14.ebuild => opendkim-2.10.3-r15.ebuild}  | 1 -
 1 file changed, 1 deletion(-)
Comment 2 Michael Orlitzky gentoo-dev 2019-06-14 13:44:58 UTC
Note for the future: --enable-stats requires OpenDBX:

  configure: WARNING: opendbx is needed to import statistics into
  a SQL database - disabling opendkim-importstats and opendkim-spam
Comment 3 Ralph Seichter 2019-06-29 16:31:16 UTC
Added ebuild -r16 with support for new USE flags "querycache" and "stats".
Comment 4 Larry the Git Cow gentoo-dev 2019-07-04 01:55:07 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=37776b38953dc2012dad7413487a33c794a605fa

commit 37776b38953dc2012dad7413487a33c794a605fa
Author:     Ralph Seichter <github@seichter.de>
AuthorDate: 2019-06-29 16:19:23 +0000
Commit:     Michael Orlitzky <mjo@gentoo.org>
CommitDate: 2019-07-04 01:52:51 +0000

    mail-filter/opendkim: Added query_cache and stats USE flags
    
    Added new USE flags "query_cache" to enable query caching and "stats"
    to enable statistics. In previous ebuild versions, these features were
    always enabled.
    
    Closes: https://bugs.gentoo.org/687972
    Signed-off-by: Ralph Seichter <gentoo@seichter.de>
    Package-Manager: Portage-2.3.66, Repoman-2.3.11
    Signed-off-by: Michael Orlitzky <mjo@gentoo.org>

 mail-filter/opendkim/metadata.xml               |   6 +
 mail-filter/opendkim/opendkim-2.10.3-r16.ebuild | 230 ++++++++++++++++++++++++
 2 files changed, 236 insertions(+)