Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 687904 - app-arch/xz-utils: please stop removing *.a files, breaks Cygwin and is needless with libtool anyway
Summary: app-arch/xz-utils: please stop removing *.a files, breaks Cygwin and is needl...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-06-12 08:20 UTC by Michael Haubenwallner (RETIRED)
Modified: 2019-06-12 08:35 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
proposed patch (0001-app-arch-xz-utils-stop-removing-.a-files.patch,1.62 KB, patch)
2019-06-12 08:20 UTC, Michael Haubenwallner (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Haubenwallner (RETIRED) gentoo-dev 2019-06-12 08:20:29 UTC
Created attachment 579592 [details, diff]
proposed patch

Please do not remove *.a files from $ED when properly using libtool:

Cygwin does use *.dll.a for the import library, required to link against the "shared library".

Upon configure --disable-static, libtool does not create the static library at all - as long as it is able to create the shared library.

Thoughts?

OK to push attached patch (with revbump for the non-live ebuild)?

Thanks!
Comment 1 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2019-06-12 08:26:58 UTC
Ok to push
Comment 2 Larry the Git Cow gentoo-dev 2019-06-12 08:35:06 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ad4a5f5695f9d93e1dceeae7cc943b916c9ab61e

commit ad4a5f5695f9d93e1dceeae7cc943b916c9ab61e
Author:     Michael Haubenwallner <haubi@gentoo.org>
AuthorDate: 2019-06-12 08:32:44 +0000
Commit:     Michael Haubenwallner <haubi@gentoo.org>
CommitDate: 2019-06-12 08:34:38 +0000

    app-arch/xz-utils: stop removing *.a files
    
    Upon configure --disable-static, libtool does not create the static
    library at all, as long as it is able to create the shared library.
    And the *.a file name may be used with shared libraries too (*.dll.a
    on Cygwin), so we may end up without any library when removing *.a.
    
    Closes: https://bugs.gentoo.org/687904
    Package-Manager: Portage-2.3.66, Repoman-2.3.11
    Signed-off-by: Michael Haubenwallner <haubi@gentoo.org>

 app-arch/xz-utils/xz-utils-5.2.4-r3.ebuild | 91 ++++++++++++++++++++++++++++++
 app-arch/xz-utils/xz-utils-9999.ebuild     |  2 +-
 2 files changed, 92 insertions(+), 1 deletion(-)