687622 – media-sound/kid3-3.7.1 - add USE=dbus

Bug 687622 - media-sound/kid3-3.7.1 - add USE=dbus

Summary: media-sound/kid3-3.7.1 - add USE=dbus

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Current packages (show other bugs)
Hardware:	All Linux

Importance:	Normal normal (vote)
Assignee:	Gentoo KDE team

URL:
Whiteboard:
Keywords:	PATCH

Depends on:
Blocks:

Reported:	2019-06-08 09:15 UTC by Martin Cihlář
Modified:	2019-07-16 21:04 UTC (History)
CC List:	1 user (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
kid3-3.7.1.ebuild patch (kid3-3.7.1-dbus.patch,887 bytes, patch) 2019-06-08 09:16 UTC, Martin Cihlář	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Martin Cihlář 2019-06-08 09:15:27 UTC

The package does not hard-depend on dev-qt/qtdbus:5, it provides a CMake argument "-DWITH_DBUS" to enable or disable D-Bus. The changes to the ebuild are trivial therefore I'm only providing a patch in the attatchment below.

Reproducible: Always

Comment 1 Martin Cihlář 2019-06-08 09:16:27 UTC

Created attachment 579192 [details, diff]
kid3-3.7.1.ebuild patch

Comment 2 Andreas Sturmlechner gentoo-dev

2019-07-16 19:54:36 UTC

Thanks for your report, when I first made the error of looking at its build system I backed away from this change. Will add this as USE mpris though.

Comment 3 Larry the Git Cow gentoo-dev

2019-07-16 21:04:23 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=85bb5c1d514a8bd5ae121d6fbb208283d2383fd9

commit 85bb5c1d514a8bd5ae121d6fbb208283d2383fd9
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2019-07-16 19:37:51 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2019-07-16 21:04:09 +0000

    media-sound/kid3: Add USE mpris
    
    Thanks-to: Martin Cihlář <martin.cibule@seznam.cz>
    Closes: https://bugs.gentoo.org/687622
    Package-Manager: Portage-2.3.69, Repoman-2.3.16
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 media-sound/kid3/kid3-3.7.1.ebuild | 5 +++--
 media-sound/kid3/metadata.xml      | 4 ++--
 2 files changed, 5 insertions(+), 4 deletions(-)