Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 687186 - net-misc/openvswitch-2.10.0-r1 patch to run with sys-kernel/gentoo-sources-4.14.120
Summary: net-misc/openvswitch-2.10.0-r1 patch to run with sys-kernel/gentoo-sources-4....
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: AMD64 Linux
: Normal normal (vote)
Assignee: Tiziano Müller (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-06-02 10:25 UTC by Giuseppe Vitillaro
Modified: 2019-06-04 18:11 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Report about versions 2.10.2/2.11.1 bump. (BUG687186.txt,1.61 KB, text/plain)
2019-06-03 09:28 UTC, Giuseppe Vitillaro
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Giuseppe Vitillaro 2019-06-02 10:25:18 UTC
Stable package net-misc/openvswitch-2.10.0-r1 modules can't be compiled succesfully under stable kernel sys-kernel/gentoo-sources-4.14.120 withouth this user patch installed:

https://github.com/openwrt/packages/blob/master/net/openvswitch/patches/0005-datapath-conntrack-fix-include-for-IP6_DEFRAG_CONNTR.patch

Unfortunately while this patch works nicely under sys-kernel/gentoo-sources-4.14.120, it doesn't work with previous stable 4.14.xx kernels, like 4.14.105-r1.

The patch is rather simple, a declaration of a data structure has been moved in a new include file, apparently:

+#include <net/ipv6_frag.h>

which doesn't exist in previous kernels, as far as I can see,
Comment 1 Larry the Git Cow gentoo-dev 2019-06-02 17:22:05 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0d74f18fa38281b3391a535b0b8d1d44eab260a6

commit 0d74f18fa38281b3391a535b0b8d1d44eab260a6
Author:     Matthew Thode <prometheanfire@gentoo.org>
AuthorDate: 2019-06-02 17:14:52 +0000
Commit:     Matthew Thode <prometheanfire@gentoo.org>
CommitDate: 2019-06-02 17:14:52 +0000

    net-misc/openvswitch: 2.10.2 and 2.11.1 bump
    
    Bug: https://bugs.gentoo.org/687186
    Package-Manager: Portage-2.3.66, Repoman-2.3.13
    Signed-off-by: Matthew Thode <prometheanfire@gentoo.org>

 net-misc/openvswitch/Manifest                  |   2 +
 net-misc/openvswitch/openvswitch-2.10.2.ebuild | 147 +++++++++++++++++++++++++
 net-misc/openvswitch/openvswitch-2.11.1.ebuild | 147 +++++++++++++++++++++++++
 3 files changed, 296 insertions(+)
Comment 2 Matthew Thode ( prometheanfire ) archtester Gentoo Infrastructure gentoo-dev Security 2019-06-02 17:22:41 UTC
can you test one of the new versions just in case?
Comment 3 Giuseppe Vitillaro 2019-06-03 09:28:05 UTC
Created attachment 578504 [details]
Report about versions 2.10.2/2.11.1 bump.

I verified the new versions 2.10.2/2.11.1, apologies for the delay, this morning, with negative results, as you can see in the attached report.

The very same error about an "incomplete type", while compiling modules.

The problem solved by the referenced upstream patch, using the new include file.

Hope it helps, Regards, G. Vitillaro.
Comment 4 Giuseppe Vitillaro 2019-06-03 09:35:23 UTC
Ops. Forgot to mention, with kernel sys-kernel/gentoo-sources-4.14.120:

Available kernel symlink targets:
  [1]   linux-4.14.105-gentoo-r1
  [2]   linux-4.14.120-gentoo *

and with these use flags active:

(modules ssl -debug -monitor KERNEL="linux" PYTHON_TARGETS="python2_7 python3_6 -python3_5")

for openvswitch.
Comment 5 Larry the Git Cow gentoo-dev 2019-06-03 14:50:53 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=9bf6443396a2c0cc12843670c920fc7ff7cb979b

commit 9bf6443396a2c0cc12843670c920fc7ff7cb979b
Author:     Matthew Thode <prometheanfire@gentoo.org>
AuthorDate: 2019-06-03 14:49:48 +0000
Commit:     Matthew Thode <prometheanfire@gentoo.org>
CommitDate: 2019-06-03 14:50:48 +0000

    net-misc/openvswitch: fix building on newer kernels
    
    Fixes: https://bugs.gentoo.org/687186
    
    Package-Manager: Portage-2.3.66, Repoman-2.3.13
    Signed-off-by: Matthew Thode <prometheanfire@gentoo.org>

 ...nntrack-fix-include-for-IP6_DEFRAG_CONNTR.patch | 46 ++++++++++++++++++++++
 ...-2.11.1.ebuild => openvswitch-2.11.1-r1.ebuild} |  5 ++-
 2 files changed, 50 insertions(+), 1 deletion(-)
Comment 6 Giuseppe Vitillaro 2019-06-04 18:04:21 UTC
I'm not completely sure I understood how the referenced patch has been applied in the new ebuild openvswitch-2.11.1-r1, but, if I got it, there is still a problem for "old" kernels, kernels which are still tagged "stable" in portage, like 4.14.105-gentoo-r1.

Without an ifdef in the patch, kernels < 4.14.120-gentoo wouldn't emerge modules with this patch, as it is, because they lack the new include file.

Apologies for commenting a CLOSED BUG.

Regards, G. Vitillaro.
Comment 7 Matthew Thode ( prometheanfire ) archtester Gentoo Infrastructure gentoo-dev Security 2019-06-04 18:11:46 UTC
you are right, I did think about it but decided to just roll forward, if there are bugs I'll point people at updating their kernels if anything.