Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 686870 - app-crypt/nitrocli-0.2.3-r1 : error: unused doc comment
Summary: app-crypt/nitrocli-0.2.3-r1 : error: unused doc comment
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: deso
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2019-05-27 17:46 UTC by Toralf Förster
Modified: 2019-05-28 02:36 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
emerge-info.txt (emerge-info.txt,15.05 KB, text/plain)
2019-05-27 17:46 UTC, Toralf Förster
Details
app-crypt:nitrocli-0.2.3-r1:20190527-150630.log (app-crypt:nitrocli-0.2.3-r1:20190527-150630.log,5.90 KB, text/plain)
2019-05-27 17:46 UTC, Toralf Förster
Details
emerge-history.txt (emerge-history.txt,124.45 KB, text/plain)
2019-05-27 17:47 UTC, Toralf Förster
Details
environment (environment,25.64 KB, text/plain)
2019-05-27 17:47 UTC, Toralf Förster
Details
etc.portage.tbz2 (etc.portage.tbz2,11.23 KB, application/x-bzip)
2019-05-27 17:47 UTC, Toralf Förster
Details
temp.tbz2 (temp.tbz2,9.53 KB, application/x-bzip)
2019-05-27 17:47 UTC, Toralf Förster
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Toralf Förster gentoo-dev 2019-05-27 17:46:50 UTC
   Compiling nitrokey v0.3.4
   Compiling nitrocli v0.2.3 (/var/tmp/portage/app-crypt/nitrocli-0.2.3-r1/work/nitrocli-0.2.3)
error: unused doc comment
  --> src/args.rs:62:1
   |
62 |   /// The available Nitrokey models.

  -------------------------------------------------------------------

  This is an unstable amd64 chroot image at a tinderbox (==build bot)
  name: 17.1_20190525-112106

  -------------------------------------------------------------------

gcc-config -l:
 [1] x86_64-pc-linux-gnu-7.3.1
 [2] x86_64-pc-linux-gnu-9.1.0 *

Available Python interpreters, in order of preference:
  [1]   python3.6
  [2]   python2.7 (fallback)
  [3]   pypy (fallback)
Available Ruby profiles:
  [1]   ruby24 (with Rubygems) *
Available Rust versions:
  [1]   rust-1.35.0 *



emerge -qpvO app-crypt/nitrocli
[ebuild  N    ] app-crypt/nitrocli-0.2.3-r1  USE="-debug"
Comment 1 Toralf Förster gentoo-dev 2019-05-27 17:46:53 UTC
Created attachment 577894 [details]
emerge-info.txt
Comment 2 Toralf Förster gentoo-dev 2019-05-27 17:46:56 UTC
Created attachment 577896 [details]
app-crypt:nitrocli-0.2.3-r1:20190527-150630.log
Comment 3 Toralf Förster gentoo-dev 2019-05-27 17:47:00 UTC
Created attachment 577898 [details]
emerge-history.txt
Comment 4 Toralf Förster gentoo-dev 2019-05-27 17:47:04 UTC
Created attachment 577900 [details]
environment
Comment 5 Toralf Förster gentoo-dev 2019-05-27 17:47:07 UTC
Created attachment 577902 [details]
etc.portage.tbz2
Comment 6 Toralf Förster gentoo-dev 2019-05-27 17:47:09 UTC
Created attachment 577904 [details]
temp.tbz2
Comment 7 deso 2019-05-27 17:57:50 UTC
Thanks for the report, Toralf. This problem has been fixed upstream at 5383aa73b339e6a53ff027ee6012a3428f67466a (https://github.com/d-e-s-o/nitrocli/commit/5383aa73b339e6a53ff027ee6012a3428f67466a). I hope to be able to cut a new release by the end of the week. Meanwhile, I'll probably have to blacklist Rust 1.35 (or higher).
Comment 8 Larry the Git Cow gentoo-dev 2019-05-28 02:36:30 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e2f4fcdd819a8b4812c2aacd303a28654d575ece

commit e2f4fcdd819a8b4812c2aacd303a28654d575ece
Author:     Daniel Mueller <deso@posteo.net>
AuthorDate: 2019-05-27 18:18:32 +0000
Commit:     Georgy Yakovlev <gyakovlev@gentoo.org>
CommitDate: 2019-05-28 02:36:21 +0000

    app-crypt/nitrocli: Add patch for build failure with Rust 1.35
    
    With dev-lang/rust-1.35 (or higher, presumably) nitrocli fails to build
    because of a unused comments that are flagged starting with this
    version.
    The change has been fixed upstream and with this change we add a patch
    back porting the fix to 0.2.3.
    
    Closes: https://bugs.gentoo.org/686870
    Signed-off-by: Daniel Müller <deso@posteo.net>
    Closes: https://github.com/gentoo/gentoo/pull/12119
    Signed-off-by: Georgy Yakovlev <gyakovlev@gentoo.org>

 .../files/nitrocli_-_fix-rust-1.35-build.patch     | 52 ++++++++++++++++++++++
 app-crypt/nitrocli/nitrocli-0.2.3-r1.ebuild        |  5 +++
 2 files changed, 57 insertions(+)