Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 686500 - dev-util/lsuio: EAPI=7 bump
Summary: dev-util/lsuio: EAPI=7 bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Andrew Savchenko
URL:
Whiteboard:
Keywords: PATCH, PullRequest
Depends on:
Blocks:
 
Reported: 2019-05-21 19:02 UTC by Michael Mair-Keimberger (iamnr3)
Modified: 2019-11-04 21:13 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
lsuio.patch (lsuio.patch,1.24 KB, patch)
2019-05-21 19:02 UTC, Michael Mair-Keimberger (iamnr3)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Mair-Keimberger (iamnr3) 2019-05-21 19:02:01 UTC
Hi,

This is another simple EAPI=7 bump. Also fixes the HOMEPAGE to use https.
Comment 1 Michael Mair-Keimberger (iamnr3) 2019-05-21 19:02:04 UTC
Created attachment 577510 [details, diff]
lsuio.patch

git diff for dev-util/lsuio
Comment 2 Larry the Git Cow gentoo-dev 2019-11-04 21:01:58 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=cf028e4d6567fb12957c5a54157bfac498ea43dc

commit cf028e4d6567fb12957c5a54157bfac498ea43dc
Author:     Andrew Savchenko <bircoph@gentoo.org>
AuthorDate: 2019-11-04 20:44:34 +0000
Commit:     Andrew Savchenko <bircoph@gentoo.org>
CommitDate: 2019-11-04 20:59:58 +0000

    dev-util/lsuio: bump to EAPI 7
    
    Bug: https://bugs.gentoo.org/686500
    Closes: https://bugs.gentoo.org/697330
    Package-Manager: Portage-2.3.78, Repoman-2.3.17
    Signed-off-by: Andrew Savchenko <bircoph@gentoo.org>

 dev-util/lsuio/files/lsuio-0.2.0-build.patch |  4 ++--
 dev-util/lsuio/lsuio-0.2.0-r1.ebuild         | 15 +++++++++++++++
 2 files changed, 17 insertions(+), 2 deletions(-)
Comment 3 Andrew Savchenko gentoo-dev 2019-11-04 21:13:23 UTC
Hi!

Thank you for the interest to this package, but you made several mistakes during EAPI 7 bump, so I committed a different fix in cf028e4d6567fb12957c5a54157bfac498ea43dc.

What's wrong with you patch?

1) The lsuio-0.2.0-build.patch was dropped.
While the package will build without it, a serious QA issue will be present which may result into run-time failures:

 * QA Notice: Package triggers severe warnings which indicate that it
 *            may exhibit random runtime failures.
 * lsuio.c:82:17: warning: implicit declaration of function 'uio_mmap_test' [-Wimplicit-function-declaration]

Please be careful in future not to drop patches just because a package may be built without them.

2) HOMEPAGE was updated to use https, but SRC_URI doesn't.
In this case s/http/https/ doesn't work for SRC_URI, but it is still possible to find a new address.

Both issues above are fixed in cf028e4d6567fb12957c5a54157bfac498ea43dc. However, there is a third issue which is not yet fixed, since it doesn't block EAPI 7 bump: update to libuio-0.2.1.

Actually lsuio is a subset of a larger project now, containing libuio library, lsuio and rwuio tools:
https://sourceforge.net/projects/libuio/files/libuio-0.2.1.tar.bz2/download

There are some forks available on github with more patches.

So pkgmove will be necessary as well. The whole job is easy, but requires some time and I have difficulty with that right now. So if you are interested in the project, patches are welcome :)