/opt/google/chrome-remote-desktop/chrome-remote-desktop:569 > with open(os.devnull, "r+") as devnull: > exit_code = subprocess.call("xrandr", env=self.child_env, > stdout=devnull, stderr=devnull) The call fails if xrandr is not installed
the code dynamically handles the missing xrandr fine. that's why it saves to exit_code & then checks it right after. i can still add the dep so users don't have to figure it out by reading the code.
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=54be6912a15cac0c27226e51384c7aad66e73e44 commit 54be6912a15cac0c27226e51384c7aad66e73e44 Author: Mike Frysinger <vapier@gentoo.org> AuthorDate: 2019-09-14 06:55:24 +0000 Commit: Mike Frysinger <vapier@gentoo.org> CommitDate: 2019-09-14 07:10:54 +0000 net-misc/chrome-remote-desktop: add USE=xrandr The daemon looks for the xrandr program during launch to enable dynamic resizing. Add a USE flag for it so users don't have to read the code to figure it out. Closes: https://bugs.gentoo.org/686002 Signed-off-by: Mike Frysinger <vapier@gentoo.org> .../chrome-remote-desktop-63.0.3239.17-r1.ebuild | 5 +++-- net-misc/chrome-remote-desktop/metadata.xml | 3 +++ 2 files changed, 6 insertions(+), 2 deletions(-)